All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Hans de Goede <hdegoede@redhat.com>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	Jun Nie <jun.nie@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC/RFT 05/10] i2c: zx2967: use core helper to mark adapter suspended
Date: Tue, 11 Dec 2018 10:12:06 +0800	[thread overview]
Message-ID: <20181211021205.GS3987@dragon> (raw)
In-Reply-To: <20181210210310.12677-6-wsa+renesas@sang-engineering.com>

On Mon, Dec 10, 2018 at 10:03:03PM +0100, Wolfram Sang wrote:
> Rejecting transfers should be handled by the core. Also, this will
> ensure proper locking which was forgotten in this open coded version
> and make sure resume mark is set after enabling clocks (not before).
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Acked-by: Shawn Guo <shawnguo@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	Hans de Goede <hdegoede@redhat.com>,
	linux-i2c@vger.kernel.org, Jun Nie <jun.nie@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC/RFT 05/10] i2c: zx2967: use core helper to mark adapter suspended
Date: Tue, 11 Dec 2018 10:12:06 +0800	[thread overview]
Message-ID: <20181211021205.GS3987@dragon> (raw)
In-Reply-To: <20181210210310.12677-6-wsa+renesas@sang-engineering.com>

On Mon, Dec 10, 2018 at 10:03:03PM +0100, Wolfram Sang wrote:
> Rejecting transfers should be handled by the core. Also, this will
> ensure proper locking which was forgotten in this open coded version
> and make sure resume mark is set after enabling clocks (not before).
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Acked-by: Shawn Guo <shawnguo@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-12-11  2:13 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 21:02 [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core Wolfram Sang
2018-12-10 21:02 ` Wolfram Sang
2018-12-10 21:02 ` Wolfram Sang
2018-12-10 21:02 ` [RFC/RFT 01/10] i2c: add 'is_suspended' flag for i2c adapters Wolfram Sang
2018-12-10 21:02   ` Wolfram Sang
2018-12-10 22:03   ` Peter Rosin
2018-12-10 22:03     ` Peter Rosin
2018-12-10 22:03     ` Peter Rosin
2018-12-18 23:33     ` Wolfram Sang
2018-12-18 23:33       ` Wolfram Sang
2018-12-18 23:33       ` Wolfram Sang
2018-12-19  9:39       ` Geert Uytterhoeven
2018-12-19  9:39         ` Geert Uytterhoeven
2018-12-19  9:39         ` Geert Uytterhoeven
2018-12-19 16:31         ` Wolfram Sang
2018-12-19 16:31           ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 02/10] i2c: reject new transfers when adapters are suspended Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 03/10] i2c: synquacer: remove unused is_suspended flag Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:04   ` Ard Biesheuvel
2018-12-10 21:04     ` Ard Biesheuvel
2018-12-10 21:03 ` [RFC/RFT 04/10] i2c: brcmstb: use core helper to mark adapter suspended Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-11 16:44   ` Kamal Dasu
2018-12-11 16:44     ` Kamal Dasu
2018-12-10 21:03 ` [RFC/RFT 05/10] i2c: zx2967: " Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-11  2:12   ` Shawn Guo [this message]
2018-12-11  2:12     ` Shawn Guo
2018-12-10 21:03 ` [RFC/RFT 06/10] i2c: sprd: don't use pdev as variable name for struct device * Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 07/10] i2c: sprd: use core helper to mark adapter suspended Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 08/10] i2c: exynos5: " Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-18 11:23   ` Marek Szyprowski
2018-12-18 11:23     ` Marek Szyprowski
2018-12-18 19:52     ` Wolfram Sang
2018-12-18 19:52       ` Wolfram Sang
2018-12-10 21:03 ` [RFC/RFT 09/10] i2c: s3c2410: " Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-18 11:24   ` Marek Szyprowski
2018-12-18 11:24     ` Marek Szyprowski
2018-12-10 21:03 ` [RFC/RFT 10/10] i2c: rcar: add suspend/resume support Wolfram Sang
2018-12-10 21:03   ` Wolfram Sang
2018-12-10 21:52   ` Peter Rosin
2018-12-10 21:52     ` Peter Rosin
2018-12-10 21:52     ` Peter Rosin
2018-12-18 23:47     ` Wolfram Sang
2018-12-18 23:47       ` Wolfram Sang
2018-12-18 23:47       ` Wolfram Sang
2018-12-11 19:24 ` [RFC/RFT 00/10] i2c: move handling of suspended adapters to the core Hans de Goede
2018-12-11 19:24   ` Hans de Goede
2018-12-11 19:24   ` Hans de Goede
2018-12-11 23:41   ` Wolfram Sang
2018-12-11 23:41     ` Wolfram Sang
2018-12-12 10:09     ` Hans de Goede
2018-12-12 10:09       ` Hans de Goede
2018-12-18 20:17       ` Wolfram Sang
2018-12-18 20:17         ` Wolfram Sang
2018-12-18 21:44         ` Hans de Goede
2018-12-18 21:44           ` Hans de Goede
2018-12-18 23:32           ` Wolfram Sang
2018-12-18 23:32             ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211021205.GS3987@dragon \
    --to=shawnguo@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=jun.nie@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.