From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 05/15] pinctrl: sh-pfc: r8a77990: Fix MOD_SEL0 SEL_I2C1 field width
Date: Mon, 17 Dec 2018 14:58:56 +0100 [thread overview]
Message-ID: <20181217135856.ppxujqr3t2zak3pn@verge.net.au> (raw)
In-Reply-To: <20181213182714.26094-6-geert+renesas@glider.be>
On Thu, Dec 13, 2018 at 07:27:04PM +0100, Geert Uytterhoeven wrote:
> The SEL_I2C1 (MOD_SEL0[21:20]) field in Module Select Register 0 has a
> width of 2 bits, i.e. it allows programming one out of 4 different
> configurations.
> However, the MOD_SEL0_21_20 macro contains 8 values instead of 4,
> overflowing into the subsequent fields in the register, and thus breaking
> the configuration of the latter.
>
> Fix this by dropping the bogus last 4 values, including the non-existent
> SEL_I2C1_4 configuration.
>
> Fixes: 6d4036a1e3b3ac0f ("pinctrl: sh-pfc: Initial R8A77990 PFC support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 05/15] pinctrl: sh-pfc: r8a77990: Fix MOD_SEL0 SEL_I2C1 field width
Date: Mon, 17 Dec 2018 13:58:56 +0000 [thread overview]
Message-ID: <20181217135856.ppxujqr3t2zak3pn@verge.net.au> (raw)
In-Reply-To: <20181213182714.26094-6-geert+renesas@glider.be>
On Thu, Dec 13, 2018 at 07:27:04PM +0100, Geert Uytterhoeven wrote:
> The SEL_I2C1 (MOD_SEL0[21:20]) field in Module Select Register 0 has a
> width of 2 bits, i.e. it allows programming one out of 4 different
> configurations.
> However, the MOD_SEL0_21_20 macro contains 8 values instead of 4,
> overflowing into the subsequent fields in the register, and thus breaking
> the configuration of the latter.
>
> Fix this by dropping the bogus last 4 values, including the non-existent
> SEL_I2C1_4 configuration.
>
> Fixes: 6d4036a1e3b3ac0f ("pinctrl: sh-pfc: Initial R8A77990 PFC support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
next prev parent reply other threads:[~2018-12-17 13:59 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 18:26 [PATCH 00/15] pinctrl: sh-pfc: Fix config register descriptions Geert Uytterhoeven
2018-12-13 18:26 ` Geert Uytterhoeven
2018-12-13 18:27 ` [PATCH 01/15] pinctrl: sh-pfc: r8a77994: Remove bogus IPSR9 field Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-14 8:00 ` Sergei Shtylyov
2018-12-14 8:00 ` Sergei Shtylyov
2018-12-14 9:38 ` Geert Uytterhoeven
2018-12-14 9:38 ` Geert Uytterhoeven
2018-12-17 13:38 ` Simon Horman
2018-12-17 13:38 ` Simon Horman
2018-12-13 18:27 ` [PATCH 02/15] pinctrl: sh-pfc: r8a779970: Add missing MOD_SEL0 field Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 13:47 ` Simon Horman
2018-12-17 13:47 ` Simon Horman
2018-12-13 18:27 ` [PATCH 03/15] pinctrl: sh-pfc: r8a779980: " Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 13:48 ` Simon Horman
2018-12-17 13:48 ` Simon Horman
2018-12-13 18:27 ` [PATCH 04/15] pinctrl: sh-pfc: sh7734: Add missing IPSR11 field Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 14:03 ` Simon Horman
2018-12-17 14:03 ` Simon Horman
2018-12-13 18:27 ` [PATCH 05/15] pinctrl: sh-pfc: r8a77990: Fix MOD_SEL0 SEL_I2C1 field width Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 13:58 ` Simon Horman [this message]
2018-12-17 13:58 ` Simon Horman
2018-12-13 18:27 ` [PATCH 06/15] pinctrl: sh-pfc: r8a77995: Remove bogus SEL_PWM[0-3]_3 configurations Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 14:07 ` Simon Horman
2018-12-17 14:07 ` Simon Horman
2018-12-17 14:12 ` Geert Uytterhoeven
2018-12-17 14:12 ` Geert Uytterhoeven
2018-12-17 19:58 ` Simon Horman
2018-12-17 19:58 ` Simon Horman
2018-12-13 18:27 ` [PATCH 07/15] pinctrl: sh-pfc: sh7264: Fix PFCR3 and PFCR0 register configuration Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 14:24 ` Simon Horman
2018-12-17 14:24 ` Simon Horman
2018-12-13 18:27 ` [PATCH 08/15] pinctrl: sh-pfc: sh7269: Add missing PCIOR0 field Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 14:29 ` Simon Horman
2018-12-17 14:29 ` Simon Horman
2018-12-13 18:27 ` [PATCH 09/15] pinctrl: sh-pfc: sh7734: Remove bogus IPSR10 value Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 14:31 ` Simon Horman
2018-12-17 14:31 ` Simon Horman
2018-12-13 18:27 ` [PATCH 10/15] pinctrl: sh-pfc: sh7734: Fix shifted values in IPSR10 Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 14:37 ` Simon Horman
2018-12-17 14:37 ` Simon Horman
2018-12-17 14:45 ` Geert Uytterhoeven
2018-12-17 14:45 ` Geert Uytterhoeven
2018-12-17 15:18 ` Simon Horman
2018-12-17 15:18 ` Simon Horman
2018-12-13 18:27 ` [PATCH 11/15] pinctrl: sh-pfc: Print actual field width for variable-width fields Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 14:46 ` Simon Horman
2018-12-17 14:46 ` Simon Horman
2018-12-17 14:58 ` Geert Uytterhoeven
2018-12-17 14:58 ` Geert Uytterhoeven
2018-12-17 15:17 ` Simon Horman
2018-12-17 15:17 ` Simon Horman
2018-12-13 18:27 ` [PATCH 12/15] pinctrl: sh-pfc: Make pinmux_cfg_reg.var_field_width[] variable-length Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-17 14:47 ` Simon Horman
2018-12-17 14:47 ` Simon Horman
2018-12-13 18:27 ` [PATCH 13/15] [RFC] pinctrl: sh-pfc: Absorb enum IDs in PINMUX_CFG_REG() macro Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-13 18:27 ` [PATCH 14/15] [RFC] pinctrl: sh-pfc: Absorb enum IDs in PINMUX_CFG_REG_VAR() macro Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
2018-12-13 18:27 ` [PATCH 15/15] [RFC] pinctrl: sh-pfc: Validate pinmux tables at runtime when debugging Geert Uytterhoeven
2018-12-13 18:27 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217135856.ppxujqr3t2zak3pn@verge.net.au \
--to=horms@verge.net.au \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.