All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
	tglx@linutronix.de, alexander.shishkin@linux.intel.com,
	schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
	will.deacon@arm.com, mark.rutland@arm.com, jolsa@redhat.com,
	namhyung@kernel.org, adrian.hunter@intel.com, ast@kernel.org,
	hpa@zytor.com, suzuki.poulosi@arm.com,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH v5 1/6] perf: Introduce ioctl to communicate driver configuration to kernel
Date: Wed, 19 Dec 2018 09:29:06 +0100	[thread overview]
Message-ID: <20181219082906.GA31670@kroah.com> (raw)
In-Reply-To: <1545067306-31687-2-git-send-email-mathieu.poirier@linaro.org>

On Mon, Dec 17, 2018 at 10:21:41AM -0700, Mathieu Poirier wrote:
> Adding a new IOCTL command to communicate PMU specific configuration to
> PMU kernel drivers.  This can be anything a PMU might need for
> configuration that doesn't fit in the perf_event_attr structure, such
> as the CoreSight sink to use for a session.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  include/uapi/linux/perf_event.h       | 1 +
>  tools/include/uapi/linux/perf_event.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index 9de8780ac8d9..a39d8dc2e7a9 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -462,6 +462,7 @@ struct perf_event_query_bpf {
>  #define PERF_EVENT_IOC_PAUSE_OUTPUT		_IOW('$', 9, __u32)
>  #define PERF_EVENT_IOC_QUERY_BPF		_IOWR('$', 10, struct perf_event_query_bpf *)
>  #define PERF_EVENT_IOC_MODIFY_ATTRIBUTES	_IOW('$', 11, struct perf_event_attr *)
> +#define PERF_EVENT_IOC_SET_DRV_CONFIG		_IOW('$', 12, __u64 *)
>  
>  enum perf_event_ioc_flags {
>  	PERF_IOC_FLAG_GROUP		= 1U << 0,
> diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h
> index 9de8780ac8d9..a39d8dc2e7a9 100644
> --- a/tools/include/uapi/linux/perf_event.h
> +++ b/tools/include/uapi/linux/perf_event.h
> @@ -462,6 +462,7 @@ struct perf_event_query_bpf {
>  #define PERF_EVENT_IOC_PAUSE_OUTPUT		_IOW('$', 9, __u32)
>  #define PERF_EVENT_IOC_QUERY_BPF		_IOWR('$', 10, struct perf_event_query_bpf *)
>  #define PERF_EVENT_IOC_MODIFY_ATTRIBUTES	_IOW('$', 11, struct perf_event_attr *)
> +#define PERF_EVENT_IOC_SET_DRV_CONFIG		_IOW('$', 12, __u64 *)

A pointer to an unknown structure?  That's just asking for abuse :(


WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: mark.rutland@arm.com, linux-s390@vger.kernel.org,
	peterz@infradead.org, will.deacon@arm.com,
	heiko.carstens@de.ibm.com, adrian.hunter@intel.com,
	acme@kernel.org, ast@kernel.org,
	alexander.shishkin@linux.intel.com, mingo@redhat.com,
	linux-arm-kernel@lists.infradead.org, hpa@zytor.com,
	schwidefsky@de.ibm.com, namhyung@kernel.org, tglx@linutronix.de,
	suzuki.poulosi@arm.com, jolsa@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v5 1/6] perf: Introduce ioctl to communicate driver configuration to kernel
Date: Wed, 19 Dec 2018 09:29:06 +0100	[thread overview]
Message-ID: <20181219082906.GA31670@kroah.com> (raw)
In-Reply-To: <1545067306-31687-2-git-send-email-mathieu.poirier@linaro.org>

On Mon, Dec 17, 2018 at 10:21:41AM -0700, Mathieu Poirier wrote:
> Adding a new IOCTL command to communicate PMU specific configuration to
> PMU kernel drivers.  This can be anything a PMU might need for
> configuration that doesn't fit in the perf_event_attr structure, such
> as the CoreSight sink to use for a session.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
>  include/uapi/linux/perf_event.h       | 1 +
>  tools/include/uapi/linux/perf_event.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
> index 9de8780ac8d9..a39d8dc2e7a9 100644
> --- a/include/uapi/linux/perf_event.h
> +++ b/include/uapi/linux/perf_event.h
> @@ -462,6 +462,7 @@ struct perf_event_query_bpf {
>  #define PERF_EVENT_IOC_PAUSE_OUTPUT		_IOW('$', 9, __u32)
>  #define PERF_EVENT_IOC_QUERY_BPF		_IOWR('$', 10, struct perf_event_query_bpf *)
>  #define PERF_EVENT_IOC_MODIFY_ATTRIBUTES	_IOW('$', 11, struct perf_event_attr *)
> +#define PERF_EVENT_IOC_SET_DRV_CONFIG		_IOW('$', 12, __u64 *)
>  
>  enum perf_event_ioc_flags {
>  	PERF_IOC_FLAG_GROUP		= 1U << 0,
> diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h
> index 9de8780ac8d9..a39d8dc2e7a9 100644
> --- a/tools/include/uapi/linux/perf_event.h
> +++ b/tools/include/uapi/linux/perf_event.h
> @@ -462,6 +462,7 @@ struct perf_event_query_bpf {
>  #define PERF_EVENT_IOC_PAUSE_OUTPUT		_IOW('$', 9, __u32)
>  #define PERF_EVENT_IOC_QUERY_BPF		_IOWR('$', 10, struct perf_event_query_bpf *)
>  #define PERF_EVENT_IOC_MODIFY_ATTRIBUTES	_IOW('$', 11, struct perf_event_attr *)
> +#define PERF_EVENT_IOC_SET_DRV_CONFIG		_IOW('$', 12, __u64 *)

A pointer to an unknown structure?  That's just asking for abuse :(


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-12-19  8:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 17:21 [RESEND PATCH v5 0/6] perf: Add ioctl for PMU driver configuration Mathieu Poirier
2018-12-17 17:21 ` Mathieu Poirier
2018-12-17 17:21 ` [RESEND PATCH v5 1/6] perf: Introduce ioctl to communicate driver configuration to kernel Mathieu Poirier
2018-12-17 17:21   ` Mathieu Poirier
2018-12-19  8:29   ` Greg KH [this message]
2018-12-19  8:29     ` Greg KH
2018-12-17 17:21 ` [RESEND PATCH v5 2/6] perf/core: Use " Mathieu Poirier
2018-12-17 17:21   ` Mathieu Poirier
2018-12-19  8:31   ` Greg KH
2018-12-19  8:31     ` Greg KH
2018-12-24  0:52   ` [LKP] [perf/core] fae9e65dbd: BUG:kernel_reboot-without-warning_in_early-boot_stage, last_printk:early_console_in_setup_code kernel test robot
2018-12-24  0:52     ` kernel test robot
2018-12-17 17:21 ` [RESEND PATCH v5 3/6] perf/aux: Make perf_event accessible to setup_aux() Mathieu Poirier
2018-12-17 17:21   ` Mathieu Poirier
2018-12-17 17:21 ` [RESEND PATCH v5 4/6] coresight: Use PMU driver configuration for sink selection Mathieu Poirier
2018-12-17 17:21   ` Mathieu Poirier
2018-12-18 14:14   ` Suzuki K Poulose
2018-12-18 14:14     ` Suzuki K Poulose
2018-12-18 15:21     ` Alexander Shishkin
2018-12-18 15:21       ` Alexander Shishkin
2018-12-18 18:20       ` Mathieu Poirier
2018-12-18 18:20         ` Mathieu Poirier
2018-12-18 17:34     ` Mathieu Poirier
2018-12-18 17:34       ` Mathieu Poirier
2018-12-19  9:40       ` Suzuki K Poulose
2018-12-19  9:40         ` Suzuki K Poulose
2019-01-07 18:18         ` Mathieu Poirier
2019-01-07 18:18           ` Mathieu Poirier
2019-01-09 14:55           ` Suzuki K Poulose
2019-01-09 14:55             ` Suzuki K Poulose
2018-12-17 17:21 ` [RESEND PATCH v5 5/6] perf tools: Make perf_evsel accessible to PMU driver configuration code Mathieu Poirier
2018-12-17 17:21   ` Mathieu Poirier
2018-12-17 17:21 ` [RESEND PATCH v5 6/6] perf tools: Use ioctl function to send sink information to kernel Mathieu Poirier
2018-12-17 17:21   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219082906.GA31670@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ast@kernel.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=suzuki.poulosi@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.