From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Tony Lindgren <tony@atomide.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH v6 13/14] mtd: onenand: omap2: Configure driver from DT
Date: Sun, 23 Dec 2018 14:51:50 +0200 [thread overview]
Message-ID: <20181223125149.GE27785@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <20181222101938.GA30696@lenoch>
Hi,
On Sat, Dec 22, 2018 at 11:19:38AM +0100, Ladislav Michl wrote:
> Well, DT timings for onenand node seems to be copied over without actually
> verifying correctness. I do not know which chip comes with N950, so please
> verify timings in you DT according chip used. Idea is to use timings for
> slowest chip used and driver will ask for faster one if possible.
Hmm, right. I thought we had some dumped values in the DT, but apparently
wrong ones. What is the method for dumping the "right" values? If I just
enable GPMC debug with old kernel, it's dumping the DT entries twice,
but neither set works with the new kernel.
Then I tried the "before" values from the new kernel, and they seem to
work (patch below)...
A.
diff --git a/arch/arm/boot/dts/omap3-n950-n9.dtsi b/arch/arm/boot/dts/omap3-n950-n9.dtsi
index 0d9b85317529..6323a6d21e4a 100644
--- a/arch/arm/boot/dts/omap3-n950-n9.dtsi
+++ b/arch/arm/boot/dts/omap3-n950-n9.dtsi
@@ -379,25 +379,25 @@
gpmc,device-width = <2>;
gpmc,mux-add-data = <2>;
gpmc,cs-on-ns = <0>;
- gpmc,cs-rd-off-ns = <87>;
- gpmc,cs-wr-off-ns = <87>;
+ gpmc,cs-rd-off-ns = <122>;
+ gpmc,cs-wr-off-ns = <122>;
gpmc,adv-on-ns = <0>;
- gpmc,adv-rd-off-ns = <10>;
- gpmc,adv-wr-off-ns = <10>;
- gpmc,oe-on-ns = <15>;
- gpmc,oe-off-ns = <87>;
+ gpmc,adv-rd-off-ns = <15>;
+ gpmc,adv-wr-off-ns = <15>;
+ gpmc,oe-on-ns = <20>;
+ gpmc,oe-off-ns = <122>;
gpmc,we-on-ns = <0>;
- gpmc,we-off-ns = <87>;
- gpmc,rd-cycle-ns = <112>;
- gpmc,wr-cycle-ns = <112>;
- gpmc,access-ns = <81>;
+ gpmc,we-off-ns = <122>;
+ gpmc,rd-cycle-ns = <148>;
+ gpmc,wr-cycle-ns = <148>;
+ gpmc,access-ns = <117>;
gpmc,page-burst-access-ns = <15>;
gpmc,bus-turnaround-ns = <0>;
gpmc,cycle2cycle-delay-ns = <0>;
gpmc,wait-monitoring-ns = <0>;
- gpmc,clk-activation-ns = <5>;
- gpmc,wr-data-mux-bus-ns = <30>;
- gpmc,wr-access-ns = <81>;
+ gpmc,clk-activation-ns = <10>;
+ gpmc,wr-data-mux-bus-ns = <40>;
+ gpmc,wr-access-ns = <117>;
gpmc,sync-clk-ps = <15000>;
/*
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Aaro Koskinen <aaro.koskinen@iki.fi>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Roger Quadros <rogerq@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v6 13/14] mtd: onenand: omap2: Configure driver from DT
Date: Sun, 23 Dec 2018 14:51:50 +0200 [thread overview]
Message-ID: <20181223125149.GE27785@darkstar.musicnaut.iki.fi> (raw)
In-Reply-To: <20181222101938.GA30696@lenoch>
Hi,
On Sat, Dec 22, 2018 at 11:19:38AM +0100, Ladislav Michl wrote:
> Well, DT timings for onenand node seems to be copied over without actually
> verifying correctness. I do not know which chip comes with N950, so please
> verify timings in you DT according chip used. Idea is to use timings for
> slowest chip used and driver will ask for faster one if possible.
Hmm, right. I thought we had some dumped values in the DT, but apparently
wrong ones. What is the method for dumping the "right" values? If I just
enable GPMC debug with old kernel, it's dumping the DT entries twice,
but neither set works with the new kernel.
Then I tried the "before" values from the new kernel, and they seem to
work (patch below)...
A.
diff --git a/arch/arm/boot/dts/omap3-n950-n9.dtsi b/arch/arm/boot/dts/omap3-n950-n9.dtsi
index 0d9b85317529..6323a6d21e4a 100644
--- a/arch/arm/boot/dts/omap3-n950-n9.dtsi
+++ b/arch/arm/boot/dts/omap3-n950-n9.dtsi
@@ -379,25 +379,25 @@
gpmc,device-width = <2>;
gpmc,mux-add-data = <2>;
gpmc,cs-on-ns = <0>;
- gpmc,cs-rd-off-ns = <87>;
- gpmc,cs-wr-off-ns = <87>;
+ gpmc,cs-rd-off-ns = <122>;
+ gpmc,cs-wr-off-ns = <122>;
gpmc,adv-on-ns = <0>;
- gpmc,adv-rd-off-ns = <10>;
- gpmc,adv-wr-off-ns = <10>;
- gpmc,oe-on-ns = <15>;
- gpmc,oe-off-ns = <87>;
+ gpmc,adv-rd-off-ns = <15>;
+ gpmc,adv-wr-off-ns = <15>;
+ gpmc,oe-on-ns = <20>;
+ gpmc,oe-off-ns = <122>;
gpmc,we-on-ns = <0>;
- gpmc,we-off-ns = <87>;
- gpmc,rd-cycle-ns = <112>;
- gpmc,wr-cycle-ns = <112>;
- gpmc,access-ns = <81>;
+ gpmc,we-off-ns = <122>;
+ gpmc,rd-cycle-ns = <148>;
+ gpmc,wr-cycle-ns = <148>;
+ gpmc,access-ns = <117>;
gpmc,page-burst-access-ns = <15>;
gpmc,bus-turnaround-ns = <0>;
gpmc,cycle2cycle-delay-ns = <0>;
gpmc,wait-monitoring-ns = <0>;
- gpmc,clk-activation-ns = <5>;
- gpmc,wr-data-mux-bus-ns = <30>;
- gpmc,wr-access-ns = <81>;
+ gpmc,clk-activation-ns = <10>;
+ gpmc,wr-data-mux-bus-ns = <40>;
+ gpmc,wr-access-ns = <117>;
gpmc,sync-clk-ps = <15000>;
/*
next prev parent reply other threads:[~2018-12-23 12:51 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 13:11 [PATCH v6 00/14] OMAP2+ OneNAND driver update Ladislav Michl
2018-01-12 13:11 ` Ladislav Michl
2018-01-12 13:11 ` [PATCH v6 01/14] dt-bindings: mtd: gpmc-onenand: Update properties description Ladislav Michl
2018-01-12 13:11 ` Ladislav Michl
2018-01-12 13:12 ` [PATCH v6 02/14] ARM: dts: OMAP2+: Add compatible property to onenand node Ladislav Michl
2018-01-12 13:12 ` Ladislav Michl
2018-01-12 13:13 ` [PATCH v6 03/14] ARM: dts: omap3-igep: Update onenand node timings Ladislav Michl
2018-01-12 13:13 ` Ladislav Michl
2018-01-12 13:13 ` [PATCH v6 04/14] mtd: onenand: omap2: Remove regulator support Ladislav Michl
2018-01-12 13:13 ` Ladislav Michl
2018-01-12 13:13 ` [PATCH v6 05/14] mtd: onenand: omap2: Remove skip initial unlocking support Ladislav Michl
2018-01-12 13:13 ` Ladislav Michl
2018-01-12 13:14 ` [PATCH v6 06/14] mtd: onenand: omap2: Remove partitioning support from platform data Ladislav Michl
2018-01-12 13:14 ` Ladislav Michl
2018-01-12 13:14 ` [PATCH v6 07/14] mtd: onenand: omap2: Account waiting time as waiting on IO Ladislav Michl
2018-01-12 13:14 ` Ladislav Michl
2018-01-12 13:15 ` [PATCH v6 08/14] mtd: onenand: omap2: Simplify the DMA setup for various paths Ladislav Michl
2018-01-12 13:15 ` Ladislav Michl
2018-01-12 13:15 ` [PATCH v6 09/14] mtd: onenand: omap2: Unify OMAP2 and OMAP3 DMA implementation Ladislav Michl
2018-01-12 13:15 ` Ladislav Michl
2018-01-12 13:16 ` [PATCH v6 10/14] mtd: onenand: omap2: Convert to use dmaengine for memcpy Ladislav Michl
2018-01-12 13:16 ` Ladislav Michl
2018-01-12 13:16 ` [PATCH v6 11/14] mtd: onenand: omap2: Do not make delay for GPIO OMAP3 specific Ladislav Michl
2018-01-12 13:16 ` Ladislav Michl
2018-01-12 13:16 ` [PATCH v6 12/14] mtd: onenand: omap2: Decouple DMA enabling from INT pin availability Ladislav Michl
2018-01-12 13:16 ` Ladislav Michl
2018-01-12 13:46 ` Roger Quadros
2018-01-12 13:46 ` Roger Quadros
2018-01-12 13:56 ` Roger Quadros
2018-01-12 13:56 ` Roger Quadros
2018-01-12 13:17 ` [PATCH v6 13/14] mtd: onenand: omap2: Configure driver from DT Ladislav Michl
2018-01-12 13:17 ` Ladislav Michl
2018-01-12 13:47 ` Roger Quadros
2018-01-12 13:47 ` Roger Quadros
2018-12-22 1:02 ` Aaro Koskinen
2018-12-22 1:02 ` Aaro Koskinen
2018-12-22 10:19 ` Ladislav Michl
2018-12-22 10:19 ` Ladislav Michl
2018-12-23 12:51 ` Aaro Koskinen [this message]
2018-12-23 12:51 ` Aaro Koskinen
2018-12-23 15:56 ` Tony Lindgren
2018-12-23 15:56 ` Tony Lindgren
2018-01-12 13:18 ` [PATCH v6 14/14] ARM: OMAP2+: Remove gpmc-onenand Ladislav Michl
2018-01-12 13:18 ` Ladislav Michl
2018-01-12 14:03 ` [PATCH v6 00/14] OMAP2+ OneNAND driver update Boris Brezillon
2018-01-12 14:03 ` Boris Brezillon
2018-01-12 14:20 ` Tony Lindgren
2018-01-12 14:20 ` Tony Lindgren
2018-01-12 15:03 ` Roger Quadros
2018-01-12 15:03 ` Roger Quadros
2018-01-13 17:31 ` Boris Brezillon
2018-01-13 17:31 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181223125149.GE27785@darkstar.musicnaut.iki.fi \
--to=aaro.koskinen@iki.fi \
--cc=boris.brezillon@free-electrons.com \
--cc=kyungmin.park@samsung.com \
--cc=ladis@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.