From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Viorel Suman <viorel.suman@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Cosmin Samoila <cosmin.samoila@nxp.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
dl-linux-imx <linux-imx@nxp.com>,
Viorel Suman <viorel.suman@gmail.com>
Subject: Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers
Date: Thu, 17 Jan 2019 14:24:58 -0800 [thread overview]
Message-ID: <20190117222458.GG16918@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190117222218.GF16918@Asurada-Nvidia.nvidia.com>
On Thu, Jan 17, 2019 at 02:22:18PM -0800, Nicolin Chen wrote:
> On Thu, Jan 17, 2019 at 12:46:25PM +0000, Viorel Suman wrote:
> > The patchset adds NXP Audio Mixer (AUDMIX) device and machine
> > drivers and related DT bindings documentation.
> >
> > Changes since V2:
> > 1. Moved "dais" node from machine driver DTS node to device driver DTS node
> > as suggested by Rob.
>
> Yea, it makes a lot of sense. Otherwise, since the connection
> between IP blocks is fixed inside the SoC, the virtual sound
> node would need to be put in the soc-level dtsi, which sounds
> odd to me.
>
> > Changes since V1:
> > 1. Original patch split into distinct patches for the device driver and
> > DT binding documentation.
> > 2. Replaced AMIX with AUDMIX in both code and file names as it looks more
> > RM-compliant.
> > 3. Removed polarity control from CPU DAI driver as suggested by Nicolin.
> > 4. Added machine driver and related DT binding documentation.
> >
> > Viorel Suman (4):
> > ASoC: fsl: Add Audio Mixer CPU DAI driver
> > ASoC: add fsl_audmix DT binding documentation
> > ASoC: fsl: Add Audio Mixer machine driver
> > ASoC: add imx-audmix DT binding documentation
>
> Reviewed-by: Nicolin Chen <nicoleotsuka@gmail.com>
Oops. Just saw Rob's new reply. The drivers look good to me though.
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Viorel Suman <viorel.suman@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Timur Tabi <timur@kernel.org>, Xiubo Li <Xiubo.Lee@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"S.j. Wang" <shengjiu.wang@nxp.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Viorel Suman <viorel.suman@gmail.com>,
Cosmin Samoila <cosmin.samoila@nxp.com>,
Mark Brown <broonie@kernel.org>, dl-linux-imx <linux-imx@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Jaroslav Kysela <perex@perex.cz>,
Daniel Baluta <daniel.baluta@nxp.com>
Subject: Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers
Date: Thu, 17 Jan 2019 14:24:58 -0800 [thread overview]
Message-ID: <20190117222458.GG16918@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20190117222218.GF16918@Asurada-Nvidia.nvidia.com>
On Thu, Jan 17, 2019 at 02:22:18PM -0800, Nicolin Chen wrote:
> On Thu, Jan 17, 2019 at 12:46:25PM +0000, Viorel Suman wrote:
> > The patchset adds NXP Audio Mixer (AUDMIX) device and machine
> > drivers and related DT bindings documentation.
> >
> > Changes since V2:
> > 1. Moved "dais" node from machine driver DTS node to device driver DTS node
> > as suggested by Rob.
>
> Yea, it makes a lot of sense. Otherwise, since the connection
> between IP blocks is fixed inside the SoC, the virtual sound
> node would need to be put in the soc-level dtsi, which sounds
> odd to me.
>
> > Changes since V1:
> > 1. Original patch split into distinct patches for the device driver and
> > DT binding documentation.
> > 2. Replaced AMIX with AUDMIX in both code and file names as it looks more
> > RM-compliant.
> > 3. Removed polarity control from CPU DAI driver as suggested by Nicolin.
> > 4. Added machine driver and related DT binding documentation.
> >
> > Viorel Suman (4):
> > ASoC: fsl: Add Audio Mixer CPU DAI driver
> > ASoC: add fsl_audmix DT binding documentation
> > ASoC: fsl: Add Audio Mixer machine driver
> > ASoC: add imx-audmix DT binding documentation
>
> Reviewed-by: Nicolin Chen <nicoleotsuka@gmail.com>
Oops. Just saw Rob's new reply. The drivers look good to me though.
next prev parent reply other threads:[~2019-01-17 22:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 12:46 [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers Viorel Suman
2019-01-17 12:46 ` Viorel Suman
2019-01-17 12:46 ` [PATCH v3 1/4] ASoC: fsl: Add Audio Mixer CPU DAI driver Viorel Suman
2019-01-17 12:46 ` Viorel Suman
2019-01-17 12:46 ` [PATCH v3 2/4] ASoC: add fsl_audmix DT binding documentation Viorel Suman
2019-01-17 12:46 ` Viorel Suman
2019-01-26 1:49 ` Nicolin Chen
2019-01-26 1:49 ` Nicolin Chen
2019-01-17 12:46 ` [PATCH v3 3/4] ASoC: fsl: Add Audio Mixer machine driver Viorel Suman
2019-01-17 12:46 ` Viorel Suman
2019-01-17 12:46 ` [PATCH v3 4/4] ASoC: add imx-audmix DT binding documentation Viorel Suman
2019-01-17 12:46 ` Viorel Suman
2019-01-17 16:18 ` [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers Rob Herring
2019-01-17 16:18 ` Rob Herring
2019-01-18 13:16 ` Viorel Suman
2019-01-18 13:16 ` Viorel Suman
2019-01-18 13:16 ` Viorel Suman
2019-01-18 19:46 ` Nicolin Chen
2019-01-18 19:46 ` Nicolin Chen
2019-01-18 19:46 ` Nicolin Chen
2019-01-21 15:23 ` Rob Herring
2019-01-21 15:23 ` Rob Herring
2019-01-21 15:23 ` Rob Herring
2019-01-22 11:39 ` Viorel Suman
2019-01-22 11:39 ` Viorel Suman
2019-01-22 11:39 ` Viorel Suman
2019-01-22 11:19 ` Viorel Suman
2019-01-22 11:19 ` Viorel Suman
2019-01-22 11:19 ` Viorel Suman
2019-01-17 22:22 ` Nicolin Chen
2019-01-17 22:22 ` Nicolin Chen
2019-01-17 22:24 ` Nicolin Chen [this message]
2019-01-17 22:24 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117222458.GG16918@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cosmin.samoila@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=viorel.suman@gmail.com \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.