From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> To: Neil Horman <nhorman@tuxdriver.com> Cc: Kent Overstreet <kent.overstreet@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>, linux-sctp@vger.kernel.org Subject: Re: [PATCH 6/7] sctp: Convert to genradix Date: Fri, 18 Jan 2019 11:35:34 -0200 [thread overview] Message-ID: <20190118133534.GD666@localhost.localdomain> (raw) In-Reply-To: <20190118131022.GA22165@hmswarspite.think-freely.org> On Fri, Jan 18, 2019 at 08:10:22AM -0500, Neil Horman wrote: > On Tue, Jan 15, 2019 at 12:29:26PM -0200, Marcelo Ricardo Leitner wrote: > > On Mon, Dec 17, 2018 at 04:00:21PM -0500, Kent Overstreet wrote: > > > On Mon, Dec 17, 2018 at 12:50:01PM -0800, Andrew Morton wrote: > > > > On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet <kent.overstreet@gmail.com> wrote: > > > > > > > > > @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc, > > > > > goto out; > > > > > } > > > > > > > > > > - stream->incnt = incnt; > > > > > - stream->outcnt = outcnt; > > > > > - > > > > > asoc->strreset_outstanding = !!out + !!in; > > > > > > > > > > > > > I'm seeing a reject here for some reason. Using todays's linux-next, > > > > but there are no changes against net/sctp/stream.c in -next. The > > > > assignment to stream->incnt has disappeared. I did this: > > > > > > > > @@ -535,8 +470,6 @@ int sctp_send_add_streams(struct sctp_as > > > > goto out; > > > > } > > > > > > > > - stream->outcnt = outcnt; > > > > - > > > > asoc->strreset_outstanding = !!out + !!in; > > > > > > > > out: > > > > > > > > > > > > We're at 4.20-rc7 and this series is rather large. I'll merge them all > > > > to see what happens, but I don't think it's 4.21-rc1 material? > > > > > > Yeah, agreed. Thanks! > > > > Ping? Where did this go? > > > As I recall kent reposted his series convirting flex_arrays to radix trees such > that it included sctp's uses. That should be this patchset already. Or you mean another (re)post, v2 or so? If yes then I missed it somehow but I still see the flex_array in v5.0-rc2: net-next]$ git ls-tree v5.0-rc2 -- lib/flex_array.c 100644 blob 2eed22fa507c7cb0756d7ef643f8a3454eb455ec lib/flex_array.c and missing the convertion on sctp stack. Current patch is the only one I could find with sctp being included: https://lore.kernel.org/lkml/20181217210021.GA7144@kmo-pixel/T/#re4f8656af37431a376044399681a8771375a4405 > > I think xin needs to repost the sctp reallocation patch to make use of those > radix trees appropriately still (assuming any additional work still needs to be > done) This came up on another converstation with him and the lack of this convertion is blocking him on at least one fix, on one that the fix using flex_arrays is one and genradix is another. Marcelo > > Neil > > > Marcelo > >
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> To: Neil Horman <nhorman@tuxdriver.com> Cc: Kent Overstreet <kent.overstreet@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>, linux-sctp@vger.kernel.org Subject: Re: [PATCH 6/7] sctp: Convert to genradix Date: Fri, 18 Jan 2019 13:35:34 +0000 [thread overview] Message-ID: <20190118133534.GD666@localhost.localdomain> (raw) In-Reply-To: <20190118131022.GA22165@hmswarspite.think-freely.org> On Fri, Jan 18, 2019 at 08:10:22AM -0500, Neil Horman wrote: > On Tue, Jan 15, 2019 at 12:29:26PM -0200, Marcelo Ricardo Leitner wrote: > > On Mon, Dec 17, 2018 at 04:00:21PM -0500, Kent Overstreet wrote: > > > On Mon, Dec 17, 2018 at 12:50:01PM -0800, Andrew Morton wrote: > > > > On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet <kent.overstreet@gmail.com> wrote: > > > > > > > > > @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc, > > > > > goto out; > > > > > } > > > > > > > > > > - stream->incnt = incnt; > > > > > - stream->outcnt = outcnt; > > > > > - > > > > > asoc->strreset_outstanding = !!out + !!in; > > > > > > > > > > > > > I'm seeing a reject here for some reason. Using todays's linux-next, > > > > but there are no changes against net/sctp/stream.c in -next. The > > > > assignment to stream->incnt has disappeared. I did this: > > > > > > > > @@ -535,8 +470,6 @@ int sctp_send_add_streams(struct sctp_as > > > > goto out; > > > > } > > > > > > > > - stream->outcnt = outcnt; > > > > - > > > > asoc->strreset_outstanding = !!out + !!in; > > > > > > > > out: > > > > > > > > > > > > We're at 4.20-rc7 and this series is rather large. I'll merge them all > > > > to see what happens, but I don't think it's 4.21-rc1 material? > > > > > > Yeah, agreed. Thanks! > > > > Ping? Where did this go? > > > As I recall kent reposted his series convirting flex_arrays to radix trees such > that it included sctp's uses. That should be this patchset already. Or you mean another (re)post, v2 or so? If yes then I missed it somehow but I still see the flex_array in v5.0-rc2: net-next]$ git ls-tree v5.0-rc2 -- lib/flex_array.c 100644 blob 2eed22fa507c7cb0756d7ef643f8a3454eb455ec lib/flex_array.c and missing the convertion on sctp stack. Current patch is the only one I could find with sctp being included: https://lore.kernel.org/lkml/20181217210021.GA7144@kmo-pixel/T/#re4f8656af37431a376044399681a8771375a4405 > > I think xin needs to repost the sctp reallocation patch to make use of those > radix trees appropriately still (assuming any additional work still needs to be > done) This came up on another converstation with him and the lack of this convertion is blocking him on at least one fix, on one that the fix using flex_arrays is one and genradix is another. Marcelo > > Neil > > > Marcelo > >
next prev parent reply other threads:[~2019-01-18 13:35 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-17 13:19 [PATCH 0/7] generic radix trees; drop flex arrays Kent Overstreet 2018-12-17 13:19 ` [PATCH 1/7] openvswitch: convert to kvmalloc Kent Overstreet 2018-12-17 13:19 ` [PATCH 2/7] md: " Kent Overstreet 2018-12-17 13:19 ` [PATCH 3/7] selinux: " Kent Overstreet 2018-12-17 13:44 ` Fwd: " Stephen Smalley 2018-12-18 7:44 ` peter enderborg 2018-12-17 13:19 ` [PATCH 4/7] Generic radix trees Kent Overstreet 2018-12-17 13:19 ` [PATCH 5/7] proc: commit to genradix Kent Overstreet 2018-12-17 13:19 ` [PATCH 6/7] sctp: Convert " Kent Overstreet 2018-12-17 13:19 ` Kent Overstreet 2018-12-17 20:50 ` Andrew Morton 2018-12-17 20:50 ` Andrew Morton 2018-12-17 20:59 ` Marcelo Ricardo Leitner 2018-12-17 20:59 ` Marcelo Ricardo Leitner 2018-12-17 21:00 ` Kent Overstreet 2018-12-17 21:00 ` Kent Overstreet 2019-01-15 14:29 ` Marcelo Ricardo Leitner 2019-01-15 14:29 ` Marcelo Ricardo Leitner 2019-01-18 13:10 ` Neil Horman 2019-01-18 13:10 ` Neil Horman 2019-01-18 13:35 ` Marcelo Ricardo Leitner [this message] 2019-01-18 13:35 ` Marcelo Ricardo Leitner 2019-01-18 14:51 ` Neil Horman 2019-01-18 14:51 ` Neil Horman 2018-12-17 13:19 ` [PATCH 7/7] Drop flex_arrays Kent Overstreet
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190118133534.GD666@localhost.localdomain \ --to=marcelo.leitner@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=kent.overstreet@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sctp@vger.kernel.org \ --cc=nhorman@tuxdriver.com \ --cc=vyasevich@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.