✗ Fi.CI.CHECKPATCH: warning for drm/i915: GTT remapping for display

From: Patchwork <patchwork@emeril.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for drm/i915: GTT remapping for display
Date: Fri, 18 Jan 2019 15:41:47 -0000	[thread overview]
Message-ID: <20190118154147.22164.73771@emeril.freedesktop.org> (raw)
In-Reply-To: <20190118152720.24643-1-ville.syrjala@linux.intel.com>

== Series Details ==

Series: drm/i915: GTT remapping for display
URL   : https://patchwork.freedesktop.org/series/55415/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6c45cc6e9157 drm/i915: Add a new "remapped" gtt_view
-:96: CHECK:LINE_SPACING: Please don't use multiple blank lines
#96: FILE: drivers/gpu/drm/i915/i915_gem.c:5685:
+
+

-:244: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#244: FILE: drivers/gpu/drm/i915/i915_gem_gtt.h:195:
+	BUILD_BUG_ON(sizeof(struct intel_remapped_info) != 9*sizeof(unsigned int));
 	                                                    ^

total: 0 errors, 0 warnings, 2 checks, 286 lines checked
e5cab34e27df drm/i915/selftests: Add mock selftest for remapped vmas
-:78: CHECK:SPACING: spaces preferred around that '-' (ctx:VxV)
#78: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:438:
+			if (left < PAGE_SIZE || left & (PAGE_SIZE-1)) {
 			                                         ^

-:97: CHECK:LINE_SPACING: Please don't use multiple blank lines
#97: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:457:
+
+

-:133: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#133: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:511:
+	for (t = types; *t; t++) {
 	for (a = planes; a->width; a++) {

-:177: WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#177: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:581:
+						if (view.type == I915_GGTT_VIEW_ROTATED)

-:178: WARNING:LONG_LINE: line over 100 characters
#178: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:582:
+							sg = assert_rotated(obj, &view.rotated, n, sg);

-:179: WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#179: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:583:
+						else

-:180: WARNING:LONG_LINE: line over 100 characters
#180: FILE: drivers/gpu/drm/i915/selftests/i915_vma.c:584:
+							sg = assert_remapped(obj, &view.remapped, n, sg);

total: 0 errors, 5 warnings, 2 checks, 172 lines checked
2fe756c3f657 drm/i915/selftests: Add live vma selftest
6d769ecac679 drm/i915: Overcome display engine stride limits via GTT remapping
67f25d52d1f2 drm/i915: Bump gen4+ fb stride limit to 256KiB
-:40: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
#40: FILE: drivers/gpu/drm/i915/intel_display.c:2484:
+		return 256*1024;
 		          ^

total: 0 errors, 0 warnings, 1 checks, 19 lines checked
3203cda3c436 drm/i915: Bump gen7+ fb size limits to 16kx16k
792906e7f600 hack: drm/i915: Always remap gtt
-:8: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:47: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 35 lines checked
796dff7bd3da hack: align dumb buffer stride to 4k to allow for gtt remapping
-:9: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

-:20: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 1 warnings, 0 checks, 8 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx