From: Ming Lei <ming.lei@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Mike Snitzer <snitzer@redhat.com>,
linux-mm@kvack.org, dm-devel@redhat.com,
Christoph Hellwig <hch@lst.de>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Omar Sandoval <osandov@fb.com>,
cluster-devel@redhat.com, linux-ext4@vger.kernel.org,
Kent Overstreet <kent.overstreet@gmail.com>,
Boaz Harrosh <ooo@electrozaur.com>,
Gao Xiang <gaoxiang25@huawei.com>, Coly Li <colyli@suse.de>,
linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Sterba <dsterba@suse.com>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH V14 00/18] block: support multi-page bvec
Date: Tue, 22 Jan 2019 10:01:30 +0800 [thread overview]
Message-ID: <20190122020128.GB2490@ming.t460p> (raw)
In-Reply-To: <61dfaa1e-e7bf-75f1-410b-ed32f97d0782@grimberg.me>
On Mon, Jan 21, 2019 at 01:43:21AM -0800, Sagi Grimberg wrote:
>
> > V14:
> > - drop patch(patch 4 in V13) for renaming bvec helpers, as suggested by Jens
> > - use mp_bvec_* as multi-page bvec helper name
> > - fix one build issue, which is caused by missing one converion of
> > bio_for_each_segment_all in fs/gfs2
> > - fix one 32bit ARCH specific issue caused by segment boundary mask
> > overflow
>
> Hey Ming,
>
> So is nvme-tcp also affected here? The only point where I see nvme-tcp
> can be affected is when initializing a bvec iter using bio_segments() as
> everywhere else we use iters which should transparently work..
>
> I see that loop was converted, does it mean that nvme-tcp needs to
> call something like?
> --
> bio_for_each_mp_bvec(bv, bio, iter)
> nr_bvecs++;
bio_for_each_segment()/bio_segments() still works, just not as efficient
as bio_for_each_mp_bvec() given each multi-page bvec(very similar with scatterlist)
is returned in each loop.
I don't look at nvme-tcp code yet. But if nvme-tcp supports this way,
it can benefit from bio_for_each_mp_bvec().
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Theodore Ts'o <tytso@mit.edu>,
Omar Sandoval <osandov@fb.com>,
Dave Chinner <dchinner@redhat.com>,
Kent Overstreet <kent.overstreet@gmail.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org,
"Darrick J . Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, Gao Xiang <gaoxiang25@huawei.com>,
Christoph Hellwig <hch@lst.de>,
linux-ext4@vger.kernel.org, Coly Li <colyli@suse.de>,
linux-bcache@vger.kernel.org, Boaz Harrosh <ooo@electrozaur.com>,
Bob Peterson <rpeterso@redhat.com>,
cluster-devel@redhat.com
Subject: Re: [PATCH V14 00/18] block: support multi-page bvec
Date: Tue, 22 Jan 2019 10:01:30 +0800 [thread overview]
Message-ID: <20190122020128.GB2490@ming.t460p> (raw)
In-Reply-To: <61dfaa1e-e7bf-75f1-410b-ed32f97d0782@grimberg.me>
On Mon, Jan 21, 2019 at 01:43:21AM -0800, Sagi Grimberg wrote:
>
> > V14:
> > - drop patch(patch 4 in V13) for renaming bvec helpers, as suggested by Jens
> > - use mp_bvec_* as multi-page bvec helper name
> > - fix one build issue, which is caused by missing one converion of
> > bio_for_each_segment_all in fs/gfs2
> > - fix one 32bit ARCH specific issue caused by segment boundary mask
> > overflow
>
> Hey Ming,
>
> So is nvme-tcp also affected here? The only point where I see nvme-tcp
> can be affected is when initializing a bvec iter using bio_segments() as
> everywhere else we use iters which should transparently work..
>
> I see that loop was converted, does it mean that nvme-tcp needs to
> call something like?
> --
> bio_for_each_mp_bvec(bv, bio, iter)
> nr_bvecs++;
bio_for_each_segment()/bio_segments() still works, just not as efficient
as bio_for_each_mp_bvec() given each multi-page bvec(very similar with scatterlist)
is returned in each loop.
I don't look at nvme-tcp code yet. But if nvme-tcp supports this way,
it can benefit from bio_for_each_mp_bvec().
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH V14 00/18] block: support multi-page bvec
Date: Tue, 22 Jan 2019 10:01:30 +0800 [thread overview]
Message-ID: <20190122020128.GB2490@ming.t460p> (raw)
In-Reply-To: <61dfaa1e-e7bf-75f1-410b-ed32f97d0782@grimberg.me>
On Mon, Jan 21, 2019 at 01:43:21AM -0800, Sagi Grimberg wrote:
>
> > V14:
> > - drop patch(patch 4 in V13) for renaming bvec helpers, as suggested by Jens
> > - use mp_bvec_* as multi-page bvec helper name
> > - fix one build issue, which is caused by missing one converion of
> > bio_for_each_segment_all in fs/gfs2
> > - fix one 32bit ARCH specific issue caused by segment boundary mask
> > overflow
>
> Hey Ming,
>
> So is nvme-tcp also affected here? The only point where I see nvme-tcp
> can be affected is when initializing a bvec iter using bio_segments() as
> everywhere else we use iters which should transparently work..
>
> I see that loop was converted, does it mean that nvme-tcp needs to
> call something like?
> --
> bio_for_each_mp_bvec(bv, bio, iter)
> nr_bvecs++;
bio_for_each_segment()/bio_segments() still works, just not as efficient
as bio_for_each_mp_bvec() given each multi-page bvec(very similar with scatterlist)
is returned in each loop.
I don't look at nvme-tcp code yet. But if nvme-tcp supports this way,
it can benefit from bio_for_each_mp_bvec().
Thanks,
Ming
next prev parent reply other threads:[~2019-01-22 2:01 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 8:17 [PATCH V14 00/18] block: support multi-page bvec Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 01/18] btrfs: look at bi_size for repair decisions Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 02/18] block: don't use bio->bi_vcnt to figure out segment number Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 03/18] block: remove bvec_iter_rewind() Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 04/18] block: introduce multi-page bvec helpers Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 05/18] block: introduce bio_for_each_mp_bvec() and rq_for_each_mp_bvec() Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 06/18] block: use bio_for_each_mp_bvec() to compute multi-page bvec count Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 07/18] block: use bio_for_each_mp_bvec() to map sg Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 08/18] block: introduce mp_bvec_last_segment() Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 09/18] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 10/18] btrfs: use mp_bvec_last_segment to get bio's last page Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 11/18] block: loop: pass multi-page bvec to iov_iter Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:17 ` [PATCH V14 12/18] bcache: avoid to use bio_for_each_segment_all() in bch_bio_alloc_pages() Ming Lei
2019-01-21 8:17 ` [Cluster-devel] " Ming Lei
2019-01-21 8:17 ` Ming Lei
2019-01-21 8:18 ` [PATCH V14 13/18] block: allow bio_for_each_segment_all() to iterate over multi-page bvec Ming Lei
2019-01-21 8:18 ` [Cluster-devel] " Ming Lei
2019-01-21 8:18 ` Ming Lei
2019-01-21 8:18 ` [PATCH V14 14/18] block: enable multipage bvecs Ming Lei
2019-01-21 8:18 ` [Cluster-devel] " Ming Lei
2019-01-21 8:18 ` Ming Lei
2019-01-21 8:18 ` [PATCH V14 15/18] block: always define BIO_MAX_PAGES as 256 Ming Lei
2019-01-21 8:18 ` [Cluster-devel] " Ming Lei
2019-01-21 8:18 ` Ming Lei
2019-01-21 8:18 ` [PATCH V14 16/18] block: document usage of bio iterator helpers Ming Lei
2019-01-21 8:18 ` [Cluster-devel] " Ming Lei
2019-01-21 8:18 ` Ming Lei
2019-01-21 8:18 ` [PATCH V14 17/18] block: kill QUEUE_FLAG_NO_SG_MERGE Ming Lei
2019-01-21 8:18 ` [Cluster-devel] " Ming Lei
2019-01-21 8:18 ` Ming Lei
2019-01-21 8:18 ` [PATCH V14 18/18] block: kill BLK_MQ_F_SG_MERGE Ming Lei
2019-01-21 8:18 ` [Cluster-devel] " Ming Lei
2019-01-21 8:18 ` Ming Lei
2019-01-21 8:22 ` [PATCH V14 00/18] block: support multi-page bvec Christoph Hellwig
2019-01-21 8:22 ` [Cluster-devel] " Christoph Hellwig
2019-01-21 8:22 ` Christoph Hellwig
2019-01-21 8:37 ` Ming Lei
2019-01-21 8:37 ` [Cluster-devel] " Ming Lei
2019-01-21 8:37 ` Ming Lei
2019-01-21 8:38 ` Christoph Hellwig
2019-01-21 8:38 ` [Cluster-devel] " Christoph Hellwig
2019-01-21 8:38 ` Christoph Hellwig
2019-01-21 8:40 ` Ming Lei
2019-01-21 8:40 ` [Cluster-devel] " Ming Lei
2019-01-21 8:40 ` Ming Lei
2019-01-21 9:43 ` Sagi Grimberg
2019-01-21 9:43 ` [Cluster-devel] " Sagi Grimberg
2019-01-22 2:01 ` Ming Lei [this message]
2019-01-22 2:01 ` Ming Lei
2019-01-22 2:01 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122020128.GB2490@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=cluster-devel@redhat.com \
--cc=colyli@suse.de \
--cc=darrick.wong@oracle.com \
--cc=dm-devel@redhat.com \
--cc=dsterba@suse.com \
--cc=gaoxiang25@huawei.com \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ooo@electrozaur.com \
--cc=osandov@fb.com \
--cc=sagi@grimberg.me \
--cc=snitzer@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.