From: Kevin Wolf <kwolf@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>,
"eblake@redhat.com" <eblake@redhat.com>,
"fam@euphon.net" <fam@euphon.net>,
"armbru@redhat.com" <armbru@redhat.com>,
"mreitz@redhat.com" <mreitz@redhat.com>,
"jsnow@redhat.com" <jsnow@redhat.com>,
Denis Lunev <den@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH v11 3/3] qemu-img info: bitmaps extension new test 239
Date: Mon, 4 Feb 2019 10:36:27 +0100 [thread overview]
Message-ID: <20190204093627.GA5855@linux.fritz.box> (raw)
In-Reply-To: <ab88488a-a715-5109-7f82-9de0919777f8@virtuozzo.com>
Am 04.02.2019 um 08:53 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 01.02.2019 20:14, Kevin Wolf wrote:
> > Am 31.01.2019 um 14:46 hat Andrey Shinkevich geschrieben:
> >> A new test file 239 added to the qemu-iotests set. It checks
> >> the output format of 'qemu-img info' for bitmaps extension of
> >> qcow2 specific information.
> >>
> >> Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
> >
> > 239 is already taken, so please rename this one. I usually search the
> > mailing list for "239.out" etc. until I find a number that nobody has
> > used even in a patch series yet.
> >
> > Kevin
> >
>
> Interesting, wasn't it considered to give meaningful names to iotest files?
> like migrate.bitmaps or qemu-img.qcow2-bitmaps, namespace.test? And then
> we'll be able to ./check -qcow2 qemu-img.*. And all these conflicts in list
> will be resolved
You're not the first one to suggest this, and I don't think people ever
fundamentally objected to the idea. But noone implemented it either -
the current system is ugly, but it does kind of work in practice and
renaming files in the repo always comes with some cost like 'git blame'
and 'git log' stopping at the rename by default.
Kevin
next prev parent reply other threads:[~2019-02-04 9:46 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 13:46 [Qemu-devel] [PATCH v11 0/3] qemu-img info lists bitmap directory entries Andrey Shinkevich
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 1/3] bdrv_query_image_info Error parameter added Andrey Shinkevich
2019-02-01 14:42 ` Vladimir Sementsov-Ogievskiy
2019-02-01 14:46 ` Daniel P. Berrangé
2019-02-01 17:13 ` Kevin Wolf
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries Andrey Shinkevich
2019-02-01 15:19 ` Vladimir Sementsov-Ogievskiy
2019-02-01 17:08 ` Eric Blake
2019-02-01 17:19 ` Kevin Wolf
2019-02-01 18:39 ` Markus Armbruster
2019-02-01 19:04 ` Eric Blake
2019-02-01 19:23 ` Markus Armbruster
2019-02-01 19:28 ` Eric Blake
2019-02-04 13:05 ` Markus Armbruster
2019-02-04 16:03 ` Vladimir Sementsov-Ogievskiy
2019-02-04 16:24 ` Eric Blake
2019-02-04 16:35 ` Vladimir Sementsov-Ogievskiy
2019-02-04 16:46 ` Vladimir Sementsov-Ogievskiy
2019-02-04 17:33 ` Eric Blake
2019-02-04 17:37 ` Eric Blake
2019-02-04 7:49 ` Vladimir Sementsov-Ogievskiy
2019-02-04 15:23 ` Eric Blake
2019-02-04 9:46 ` Kevin Wolf
2019-02-04 13:45 ` Markus Armbruster
2019-02-04 15:36 ` Vladimir Sementsov-Ogievskiy
2019-02-05 10:00 ` Kevin Wolf
2019-02-05 13:16 ` Vladimir Sementsov-Ogievskiy
2019-02-05 14:28 ` Kevin Wolf
2019-02-05 14:38 ` Eric Blake
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 3/3] qemu-img info: bitmaps extension new test 239 Andrey Shinkevich
2019-02-01 15:57 ` Vladimir Sementsov-Ogievskiy
2019-02-01 17:14 ` Kevin Wolf
2019-02-04 7:53 ` Vladimir Sementsov-Ogievskiy
2019-02-04 9:36 ` Kevin Wolf [this message]
2019-02-01 17:23 ` Eric Blake
2019-02-01 17:34 ` Kevin Wolf
2019-02-03 15:28 ` [Qemu-devel] [PATCH v11 0/3] qemu-img info lists bitmap directory entries no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190204093627.GA5855@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@virtuozzo.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.