From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Cc: fam@euphon.net, kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
den@openvz.org, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries
Date: Fri, 1 Feb 2019 13:04:12 -0600 [thread overview]
Message-ID: <3ed70b8e-f778-f942-2841-905223d3af8d@redhat.com> (raw)
In-Reply-To: <87pnsbxsi7.fsf@dusky.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
On 2/1/19 12:39 PM, Markus Armbruster wrote:
> Andrey Shinkevich <andrey.shinkevich@virtuozzo.com> writes:
>
>>
>> ##
>> +# @Qcow2BitmapInfoFlags:
>> +#
>> +# An enumeration of flags that a bitmap can report to the user.
>> +#
>> +# @in-use: The bitmap was not saved correctly and may be inconsistent.
>
> I doubt the casual reader could guess the meaning from the name. What
> about @dirty?
I like it. The existing name was chosen to match
docs/interop/qcow2.txt, which uses in_use, but I don't see a problem in
making the UI nicer than the specs (and/or rewording the specs, as the
field name doesn't matter there, only the layout).
>> +# @unknown-flags: any remaining flags not recognized by the current qemu version
>
> Intended use cases for @unknown-flags?
The qcow2 spec defines bit 2 extra_data_compatible; and also leaves the
door open for future extensions that may define other bits. If a new
version of qemu (or some non-qemu qcow2 creation app) creates an image
with additional feature bits set, THIS version of qemu doesn't know what
name to give those bits, but can still inform the user that those bits
are set via this field. It will be omitted for all images created by
this version of qemu.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-02-01 19:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-31 13:46 [Qemu-devel] [PATCH v11 0/3] qemu-img info lists bitmap directory entries Andrey Shinkevich
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 1/3] bdrv_query_image_info Error parameter added Andrey Shinkevich
2019-02-01 14:42 ` Vladimir Sementsov-Ogievskiy
2019-02-01 14:46 ` Daniel P. Berrangé
2019-02-01 17:13 ` Kevin Wolf
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 2/3] qemu-img info lists bitmap directory entries Andrey Shinkevich
2019-02-01 15:19 ` Vladimir Sementsov-Ogievskiy
2019-02-01 17:08 ` Eric Blake
2019-02-01 17:19 ` Kevin Wolf
2019-02-01 18:39 ` Markus Armbruster
2019-02-01 19:04 ` Eric Blake [this message]
2019-02-01 19:23 ` Markus Armbruster
2019-02-01 19:28 ` Eric Blake
2019-02-04 13:05 ` Markus Armbruster
2019-02-04 16:03 ` Vladimir Sementsov-Ogievskiy
2019-02-04 16:24 ` Eric Blake
2019-02-04 16:35 ` Vladimir Sementsov-Ogievskiy
2019-02-04 16:46 ` Vladimir Sementsov-Ogievskiy
2019-02-04 17:33 ` Eric Blake
2019-02-04 17:37 ` Eric Blake
2019-02-04 7:49 ` Vladimir Sementsov-Ogievskiy
2019-02-04 15:23 ` Eric Blake
2019-02-04 9:46 ` Kevin Wolf
2019-02-04 13:45 ` Markus Armbruster
2019-02-04 15:36 ` Vladimir Sementsov-Ogievskiy
2019-02-05 10:00 ` Kevin Wolf
2019-02-05 13:16 ` Vladimir Sementsov-Ogievskiy
2019-02-05 14:28 ` Kevin Wolf
2019-02-05 14:38 ` Eric Blake
2019-01-31 13:46 ` [Qemu-devel] [PATCH v11 3/3] qemu-img info: bitmaps extension new test 239 Andrey Shinkevich
2019-02-01 15:57 ` Vladimir Sementsov-Ogievskiy
2019-02-01 17:14 ` Kevin Wolf
2019-02-04 7:53 ` Vladimir Sementsov-Ogievskiy
2019-02-04 9:36 ` Kevin Wolf
2019-02-01 17:23 ` Eric Blake
2019-02-01 17:34 ` Kevin Wolf
2019-02-03 15:28 ` [Qemu-devel] [PATCH v11 0/3] qemu-img info lists bitmap directory entries no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ed70b8e-f778-f942-2841-905223d3af8d@redhat.com \
--to=eblake@redhat.com \
--cc=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=den@openvz.org \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.