From: Jens Axboe <axboe@kernel.dk> To: linux-aio@kvack.org, linux-block@vger.kernel.org, linux-api@vger.kernel.org Cc: hch@lst.de, jmoyer@redhat.com, avi@scylladb.com, jannh@google.com, viro@ZenIV.linux.org.uk, Jens Axboe <axboe@kernel.dk> Subject: [PATCH 01/19] fs: add an iopoll method to struct file_operations Date: Mon, 11 Feb 2019 12:00:30 -0700 [thread overview] Message-ID: <20190211190049.7888-2-axboe@kernel.dk> (raw) In-Reply-To: <20190211190049.7888-1-axboe@kernel.dk> From: Christoph Hellwig <hch@lst.de> This new methods is used to explicitly poll for I/O completion for an iocb. It must be called for any iocb submitted asynchronously (that is with a non-null ki_complete) which has the IOCB_HIPRI flag set. The method is assisted by a new ki_cookie field in struct iocb to store the polling cookie. Reviewed-by: Hannes Reinecke <hare@suse.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk> --- Documentation/filesystems/vfs.txt | 3 +++ include/linux/fs.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt index 8dc8e9c2913f..761c6fd24a53 100644 --- a/Documentation/filesystems/vfs.txt +++ b/Documentation/filesystems/vfs.txt @@ -857,6 +857,7 @@ struct file_operations { ssize_t (*write) (struct file *, const char __user *, size_t, loff_t *); ssize_t (*read_iter) (struct kiocb *, struct iov_iter *); ssize_t (*write_iter) (struct kiocb *, struct iov_iter *); + int (*iopoll)(struct kiocb *kiocb, bool spin); int (*iterate) (struct file *, struct dir_context *); int (*iterate_shared) (struct file *, struct dir_context *); __poll_t (*poll) (struct file *, struct poll_table_struct *); @@ -902,6 +903,8 @@ otherwise noted. write_iter: possibly asynchronous write with iov_iter as source + iopoll: called when aio wants to poll for completions on HIPRI iocbs + iterate: called when the VFS needs to read the directory contents iterate_shared: called when the VFS needs to read the directory contents diff --git a/include/linux/fs.h b/include/linux/fs.h index 29d8e2cfed0e..dedcc2e9265c 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -310,6 +310,7 @@ struct kiocb { int ki_flags; u16 ki_hint; u16 ki_ioprio; /* See linux/ioprio.h */ + unsigned int ki_cookie; /* for ->iopoll */ } __randomize_layout; static inline bool is_sync_kiocb(struct kiocb *kiocb) @@ -1787,6 +1788,7 @@ struct file_operations { ssize_t (*write) (struct file *, const char __user *, size_t, loff_t *); ssize_t (*read_iter) (struct kiocb *, struct iov_iter *); ssize_t (*write_iter) (struct kiocb *, struct iov_iter *); + int (*iopoll)(struct kiocb *kiocb, bool spin); int (*iterate) (struct file *, struct dir_context *); int (*iterate_shared) (struct file *, struct dir_context *); __poll_t (*poll) (struct file *, struct poll_table_struct *); -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk> To: linux-aio@kvack.org, linux-block@vger.kernel.org, linux-api@vger.kernel.org Cc: hch@lst.de, jmoyer@redhat.com, avi@scylladb.com, jannh@google.com, viro@ZenIV.linux.org.uk, Jens Axboe <axboe@kernel.dk> Subject: [PATCH 01/19] fs: add an iopoll method to struct file_operations Date: Mon, 11 Feb 2019 12:00:30 -0700 [thread overview] Message-ID: <20190211190049.7888-2-axboe@kernel.dk> (raw) In-Reply-To: <20190211190049.7888-1-axboe@kernel.dk> From: Christoph Hellwig <hch@lst.de> This new methods is used to explicitly poll for I/O completion for an iocb. It must be called for any iocb submitted asynchronously (that is with a non-null ki_complete) which has the IOCB_HIPRI flag set. The method is assisted by a new ki_cookie field in struct iocb to store the polling cookie. Reviewed-by: Hannes Reinecke <hare@suse.com> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Jens Axboe <axboe@kernel.dk> --- Documentation/filesystems/vfs.txt | 3 +++ include/linux/fs.h | 2 ++ 2 files changed, 5 insertions(+) diff --git a/Documentation/filesystems/vfs.txt b/Documentation/filesystems/vfs.txt index 8dc8e9c2913f..761c6fd24a53 100644 --- a/Documentation/filesystems/vfs.txt +++ b/Documentation/filesystems/vfs.txt @@ -857,6 +857,7 @@ struct file_operations { ssize_t (*write) (struct file *, const char __user *, size_t, loff_t *); ssize_t (*read_iter) (struct kiocb *, struct iov_iter *); ssize_t (*write_iter) (struct kiocb *, struct iov_iter *); + int (*iopoll)(struct kiocb *kiocb, bool spin); int (*iterate) (struct file *, struct dir_context *); int (*iterate_shared) (struct file *, struct dir_context *); __poll_t (*poll) (struct file *, struct poll_table_struct *); @@ -902,6 +903,8 @@ otherwise noted. write_iter: possibly asynchronous write with iov_iter as source + iopoll: called when aio wants to poll for completions on HIPRI iocbs + iterate: called when the VFS needs to read the directory contents iterate_shared: called when the VFS needs to read the directory contents diff --git a/include/linux/fs.h b/include/linux/fs.h index 29d8e2cfed0e..dedcc2e9265c 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -310,6 +310,7 @@ struct kiocb { int ki_flags; u16 ki_hint; u16 ki_ioprio; /* See linux/ioprio.h */ + unsigned int ki_cookie; /* for ->iopoll */ } __randomize_layout; static inline bool is_sync_kiocb(struct kiocb *kiocb) @@ -1787,6 +1788,7 @@ struct file_operations { ssize_t (*write) (struct file *, const char __user *, size_t, loff_t *); ssize_t (*read_iter) (struct kiocb *, struct iov_iter *); ssize_t (*write_iter) (struct kiocb *, struct iov_iter *); + int (*iopoll)(struct kiocb *kiocb, bool spin); int (*iterate) (struct file *, struct dir_context *); int (*iterate_shared) (struct file *, struct dir_context *); __poll_t (*poll) (struct file *, struct poll_table_struct *); -- 2.17.1 -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
next prev parent reply other threads:[~2019-02-11 19:00 UTC|newest] Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-11 19:00 [PATCHSET v15] io_uring IO interface Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` Jens Axboe [this message] 2019-02-11 19:00 ` [PATCH 01/19] fs: add an iopoll method to struct file_operations Jens Axboe 2019-02-11 19:00 ` [PATCH] io_uring: add io_uring_event cache hit information Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 02/19] block: wire up block device iopoll method Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 03/19] block: add bio_set_polled() helper Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 04/19] iomap: wire up the iopoll method Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 05/19] Add io_uring IO interface Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 06/19] io_uring: add fsync support Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 07/19] io_uring: support for IO polling Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 08/19] fs: add fget_many() and fput_many() Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 09/19] io_uring: use fget/fput_many() for file references Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 10/19] io_uring: batch io_kiocb allocation Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 11/19] block: implement bio helper to add iter bvec pages to bio Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-20 22:58 ` Ming Lei 2019-02-20 22:58 ` Ming Lei 2019-02-21 17:45 ` Jens Axboe 2019-02-21 17:45 ` Jens Axboe 2019-02-26 3:46 ` Eric Biggers 2019-02-26 3:46 ` Eric Biggers 2019-02-26 4:34 ` Jens Axboe 2019-02-26 4:34 ` Jens Axboe 2019-02-26 15:54 ` Jens Axboe 2019-02-26 15:54 ` Jens Axboe 2019-02-27 1:21 ` Ming Lei 2019-02-27 1:21 ` Ming Lei 2019-02-27 1:47 ` Jens Axboe 2019-02-27 1:47 ` Jens Axboe 2019-02-27 1:53 ` Ming Lei 2019-02-27 1:53 ` Ming Lei 2019-02-27 1:57 ` Jens Axboe 2019-02-27 1:57 ` Jens Axboe 2019-02-27 2:03 ` Jens Axboe 2019-02-27 2:21 ` Ming Lei 2019-02-27 2:21 ` Ming Lei 2019-02-27 2:28 ` Jens Axboe 2019-02-27 2:28 ` Jens Axboe 2019-02-27 2:37 ` Ming Lei 2019-02-27 2:37 ` Ming Lei 2019-02-27 2:43 ` Jens Axboe 2019-02-27 2:43 ` Jens Axboe 2019-02-27 3:09 ` Ming Lei 2019-02-27 3:09 ` Ming Lei 2019-02-27 3:37 ` Jens Axboe 2019-02-27 3:37 ` Jens Axboe 2019-02-27 3:43 ` Jens Axboe 2019-02-27 3:43 ` Jens Axboe 2019-02-27 3:44 ` Ming Lei 2019-02-27 3:44 ` Ming Lei 2019-02-27 4:05 ` Jens Axboe 2019-02-27 4:05 ` Jens Axboe 2019-02-27 4:06 ` Jens Axboe 2019-02-27 4:06 ` Jens Axboe 2019-02-27 19:42 ` Christoph Hellwig 2019-02-27 19:42 ` Christoph Hellwig 2019-02-28 8:37 ` Ming Lei 2019-02-28 8:37 ` Ming Lei 2019-02-27 23:35 ` Ming Lei 2019-02-27 23:35 ` Ming Lei 2019-03-08 7:55 ` Christoph Hellwig 2019-03-08 7:55 ` Christoph Hellwig 2019-03-08 9:12 ` Ming Lei 2019-03-08 9:12 ` Ming Lei 2019-03-08 8:18 ` Christoph Hellwig 2019-03-08 8:18 ` Christoph Hellwig 2019-02-11 19:00 ` [PATCH 12/19] io_uring: add support for pre-mapped user IO buffers Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-19 19:08 ` Jann Horn 2019-02-19 19:08 ` Jann Horn 2019-02-22 22:29 ` Jens Axboe 2019-02-22 22:29 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 13/19] net: split out functions related to registering inflight socket files Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 14/19] io_uring: add file set registration Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-19 16:12 ` Jann Horn 2019-02-19 16:12 ` Jann Horn 2019-02-22 22:29 ` Jens Axboe 2019-02-22 22:29 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 15/19] io_uring: add submission polling Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 16/19] io_uring: add io_kiocb ref count Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 17/19] io_uring: add support for IORING_OP_POLL Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 18/19] io_uring: allow workqueue item to handle multiple buffered requests Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-11 19:00 ` [PATCH 19/19] io_uring: add io_uring_event cache hit information Jens Axboe 2019-02-11 19:00 ` Jens Axboe 2019-02-21 12:10 ` [PATCHSET v15] io_uring IO interface Marek Majkowski 2019-02-21 12:10 ` Marek Majkowski 2019-02-21 17:48 ` Jens Axboe 2019-02-21 17:48 ` Jens Axboe 2019-02-22 15:01 ` Marek Majkowski 2019-02-22 15:01 ` Marek Majkowski 2019-02-22 22:32 ` Jens Axboe 2019-02-22 22:32 ` Jens Axboe -- strict thread matches above, loose matches on Subject: below -- 2019-02-09 21:13 [PATCHSET v14] " Jens Axboe 2019-02-09 21:13 ` [PATCH 01/19] fs: add an iopoll method to struct file_operations Jens Axboe 2019-02-09 21:13 ` Jens Axboe 2019-02-08 17:34 [PATCHSET v13] io_uring IO interface Jens Axboe 2019-02-08 17:34 ` [PATCH 01/19] fs: add an iopoll method to struct file_operations Jens Axboe 2019-02-08 17:34 ` Jens Axboe 2019-02-09 9:20 ` Hannes Reinecke 2019-02-09 9:20 ` Hannes Reinecke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190211190049.7888-2-axboe@kernel.dk \ --to=axboe@kernel.dk \ --cc=avi@scylladb.com \ --cc=hch@lst.de \ --cc=jannh@google.com \ --cc=jmoyer@redhat.com \ --cc=linux-aio@kvack.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=viro@ZenIV.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.