From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: mst@redhat.com, kvm@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stephen@networkplumber.org
Subject: Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()
Date: Fri, 15 Feb 2019 10:03:56 -0800 (PST) [thread overview]
Message-ID: <20190215.100356.251698752340585300.davem@davemloft.net> (raw)
In-Reply-To: <20190215075324.18891-1-jasowang@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Fri, 15 Feb 2019 15:53:24 +0800
> When fail, translate_desc() returns negative value, otherwise the
> number of iovs. So we should fail when the return value is negative
> instead of a blindly check against zero.
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Fixes: cc5e71075947 ("vhost: log dirty page correctly")
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Jason, please put the Fixes tag first.
Thank you.
next prev parent reply other threads:[~2019-02-15 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 7:53 [PATCH net] vhost: correctly check the return value of translate_desc() in log_used() Jason Wang
2019-02-15 16:45 ` Stephen Hemminger
2019-02-15 16:45 ` Stephen Hemminger
2019-02-19 6:51 ` Jason Wang
2019-02-19 6:51 ` Jason Wang
2019-02-15 18:03 ` David Miller [this message]
2019-02-19 6:50 ` Jason Wang
2019-02-19 6:50 ` Jason Wang
2019-02-15 18:03 ` David Miller
2019-02-15 21:59 ` Michael S. Tsirkin
2019-02-15 21:59 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2019-02-15 7:53 Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215.100356.251698752340585300.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.