All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Jason Wang <jasowang@redhat.com>
Cc: netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	mst@redhat.com
Subject: Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used()
Date: Fri, 15 Feb 2019 08:45:02 -0800	[thread overview]
Message-ID: <20190215084502.23feed0e__21439.7011369996$1550249118$gmane$org@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190215075324.18891-1-jasowang@redhat.com>

On Fri, 15 Feb 2019 15:53:24 +0800
Jason Wang <jasowang@redhat.com> wrote:

> When fail, translate_desc() returns negative value, otherwise the
> number of iovs. So we should fail when the return value is negative
> instead of a blindly check against zero.
> 
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Fixes: cc5e71075947 ("vhost: log dirty page correctly")
> Signed-off-by: Jason Wang <jasowang@redhat.com>

Looks good. It is best to put the Addresses-Coverity-Id tag on these kind
of bug fixes so that the automated tools see it.

  reply	other threads:[~2019-02-15 16:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  7:53 [PATCH net] vhost: correctly check the return value of translate_desc() in log_used() Jason Wang
2019-02-15 16:45 ` Stephen Hemminger [this message]
2019-02-15 16:45 ` Stephen Hemminger
2019-02-19  6:51   ` Jason Wang
2019-02-19  6:51   ` Jason Wang
2019-02-15 18:03 ` David Miller
2019-02-19  6:50   ` Jason Wang
2019-02-19  6:50   ` Jason Wang
2019-02-15 18:03 ` David Miller
2019-02-15 21:59 ` Michael S. Tsirkin
2019-02-15 21:59 ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2019-02-15  7:53 Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20190215084502.23feed0e__21439.7011369996$1550249118$gmane$org@shemminger-XPS-13-9360' \
    --to=stephen@networkplumber.org \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.