From: Robert Elliott <elliott@hpe.com>
To: linux-nvdimm@lists.01.org
Subject: [ndctl PATCH v2 3/3] ndctl, test: Make tests using MAP_SYNC only include <sys/mman.h>
Date: Thu, 14 Feb 2019 20:57:25 -0600 [thread overview]
Message-ID: <20190215025725.19366-3-elliott@hpe.com> (raw)
In-Reply-To: <20190215025725.19366-1-elliott@hpe.com>
The kernel-4.15 mmap() manpage defines that MAP_SHARED_VALIDATE and
MAP_SYNC are provided to applications by <sys/mman.h>. This requires
glibc-2.28 and architecture support.
Although they are also available via <linux/mman.h>, that is not the
defined API.
Make tests using it (currently only dax-poison) rely on <sys/mman.h>
by removing inclusion of <linux/mman.h>.
Fixes: e6a1d12d4a6e2 ("ndctl: autoconf detect BUS_MCEERR_AR")
Signed-off-by: Robert Elliott <elliott@hpe.com>
---
test/dax-poison.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/test/dax-poison.c b/test/dax-poison.c
index a25bf0b..69bb161 100644
--- a/test/dax-poison.c
+++ b/test/dax-poison.c
@@ -5,7 +5,6 @@
#include <signal.h>
#include <setjmp.h>
#include <sys/mman.h>
-#include <linux/mman.h>
#include <fcntl.h>
#include <string.h>
#include <errno.h>
--
2.20.1
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-02-15 2:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 16:34 [ndctl PATCH 1/2] autoconf: Check for MAP_SHARED_VALIDATE Robert Elliott
2019-02-14 16:34 ` [ndctl PATCH 2/2] autoconf: print more possible package names for keyutils.h Robert Elliott
2019-02-14 17:55 ` Dan Williams
2019-02-14 16:53 ` [ndctl PATCH 1/2] autoconf: Check for MAP_SHARED_VALIDATE Dan Williams
2019-02-14 17:03 ` Elliott, Robert (Persistent Memory)
2019-02-14 17:54 ` Dan Williams
2019-02-15 2:57 ` [ndctl PATCH v2 1/3] autoconf: print more possible package names for <keyutils.h> Robert Elliott
2019-02-15 2:57 ` [ndctl PATCH v2 2/3] autoconf: Check for MAP_SHARED_VALIDATE and kernel/glibc conflicts Robert Elliott
2019-02-15 2:57 ` Robert Elliott [this message]
2019-02-15 17:55 ` [ndctl PATCH v2 1/3] autoconf: print more possible package names for <keyutils.h> Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215025725.19366-3-elliott@hpe.com \
--to=elliott@hpe.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.