From: Dan Williams <dan.j.williams@intel.com>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [ndctl PATCH 1/2] autoconf: Check for MAP_SHARED_VALIDATE
Date: Thu, 14 Feb 2019 09:54:06 -0800 [thread overview]
Message-ID: <CAPcyv4hgDyANsyCGZyPcok29Hu6_XUpcXjUoFKgVzVNtj3H-Hw@mail.gmail.com> (raw)
In-Reply-To: <AT5PR8401MB116943788DB1A028C35CF3E9AB670@AT5PR8401MB1169.NAMPRD84.PROD.OUTLOOK.COM>
On Thu, Feb 14, 2019 at 9:04 AM Elliott, Robert (Persistent Memory)
<elliott@hpe.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Dan Williams [mailto:dan.j.williams@intel.com]
> > Sent: Thursday, February 14, 2019 10:54 AM
> > To: Elliott, Robert (Persistent Memory) <elliott@hpe.com>
> > Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
> > Subject: Re: [ndctl PATCH 1/2] autoconf: Check for MAP_SHARED_VALIDATE
> >
> > On Thu, Feb 14, 2019 at 8:29 AM Robert Elliott <elliott@hpe.com> wrote:
> > >
> > > Some ndctl tests use two new mmap() flags named MAP_SHARED_VALIDATE
> > > and MAP_SYNC that were added by linux kernel-4.15, intended to be
> > > defined for applications by sys/mman.h. However, these do not exist
> > > unless the distro has glibc-2.28.
> > >
> > > In addition to the existing check for MAP_SYNC, check that
> > > MAP_SHARED_VALIDATE is provided.
> > >
> > > Fixes: 94679e6b78aa ("ndctl, test: check availability of MAP_SYNC for poison test")
> > > Signed-off-by: Robert Elliott <elliott@hpe.com>
> >
> > Does this really fix anything? How can a system have MAP_SYNC without
> > MAP_SHARED_VALIDATE?
>
> In glibc, MAP_SHARED_VALIDATE went into all architectures while
> MAP_SYNC did not - these are left out:
> alpha hppa mips powerpc sparc tile
>
> Checking both provides a breadcrumb about whether it's an overall
> glibc version problem or an architecture-specific problem.
>
> BTW, the glibc patches at git://sourceware.org/git/glibc.git are
> these on 2018-02-06:
> e76def72eb74 ("Add MAP_SYNC from Linux 4.15.")
> 92669d6ee3f2 ("Add MAP_SHARED_VALIDATE from Linux 4.15.")
Ah, thanks for the clarification. Lets roll these details into the changelog.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-02-14 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 16:34 [ndctl PATCH 1/2] autoconf: Check for MAP_SHARED_VALIDATE Robert Elliott
2019-02-14 16:34 ` [ndctl PATCH 2/2] autoconf: print more possible package names for keyutils.h Robert Elliott
2019-02-14 17:55 ` Dan Williams
2019-02-14 16:53 ` [ndctl PATCH 1/2] autoconf: Check for MAP_SHARED_VALIDATE Dan Williams
2019-02-14 17:03 ` Elliott, Robert (Persistent Memory)
2019-02-14 17:54 ` Dan Williams [this message]
2019-02-15 2:57 ` [ndctl PATCH v2 1/3] autoconf: print more possible package names for <keyutils.h> Robert Elliott
2019-02-15 2:57 ` [ndctl PATCH v2 2/3] autoconf: Check for MAP_SHARED_VALIDATE and kernel/glibc conflicts Robert Elliott
2019-02-15 2:57 ` [ndctl PATCH v2 3/3] ndctl, test: Make tests using MAP_SYNC only include <sys/mman.h> Robert Elliott
2019-02-15 17:55 ` [ndctl PATCH v2 1/3] autoconf: print more possible package names for <keyutils.h> Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hgDyANsyCGZyPcok29Hu6_XUpcXjUoFKgVzVNtj3H-Hw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=elliott@hpe.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.