From: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] powerpc/64s: Better printing of machine check info for guest MCEs
Date: Wed, 20 Feb 2019 15:05:29 +0530 [thread overview]
Message-ID: <20190220093529.uegsp5fuj6ozb2mq@in.ibm.com> (raw)
In-Reply-To: <20190220010623.GE5353@blackberry>
On 2019-02-20 12:06:23 Wed, Paul Mackerras wrote:
> This adds an "in_guest" parameter to machine_check_print_event_info()
> so that we can avoid trying to translate guest NIP values into
> symbolic form using the host kernel's symbol table.
>
> Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
> ---
> arch/powerpc/include/asm/mce.h | 2 +-
> arch/powerpc/kernel/mce.c | 8 +++++---
> arch/powerpc/kvm/book3s_hv.c | 4 ++--
> arch/powerpc/platforms/powernv/opal.c | 2 +-
> 4 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/mce.h b/arch/powerpc/include/asm/mce.h
> index a8b8903..17996bc 100644
> --- a/arch/powerpc/include/asm/mce.h
> +++ b/arch/powerpc/include/asm/mce.h
> @@ -209,7 +209,7 @@ extern int get_mce_event(struct machine_check_event *mce, bool release);
> extern void release_mce_event(void);
> extern void machine_check_queue_event(void);
> extern void machine_check_print_event_info(struct machine_check_event *evt,
> - bool user_mode);
> + bool user_mode, bool in_guest);
> #ifdef CONFIG_PPC_BOOK3S_64
> void flush_and_reload_slb(void);
> #endif /* CONFIG_PPC_BOOK3S_64 */
> diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
> index bd933a7..d01b690 100644
> --- a/arch/powerpc/kernel/mce.c
> +++ b/arch/powerpc/kernel/mce.c
> @@ -301,13 +301,13 @@ static void machine_check_process_queued_event(struct irq_work *work)
> while (__this_cpu_read(mce_queue_count) > 0) {
> index = __this_cpu_read(mce_queue_count) - 1;
> evt = this_cpu_ptr(&mce_event_queue[index]);
> - machine_check_print_event_info(evt, false);
> + machine_check_print_event_info(evt, false, false);
> __this_cpu_dec(mce_queue_count);
> }
> }
>
> void machine_check_print_event_info(struct machine_check_event *evt,
> - bool user_mode)
> + bool user_mode, bool in_guest)
> {
> const char *level, *sevstr, *subtype;
> static const char *mc_ue_types[] = {
> @@ -387,7 +387,9 @@ void machine_check_print_event_info(struct machine_check_event *evt,
> evt->disposition == MCE_DISPOSITION_RECOVERED ?
> "Recovered" : "Not recovered");
>
> - if (user_mode) {
> + if (in_guest) {
> + printk("%s Guest NIP: %016llx\n", evt->srr0);
Missing 'level' argument. This should be:
printk("%s Guest NIP: %016llx\n", level, evt->srr0);
Rest looks fine to me.
Reviewed-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Thanks,
-Mahesh.
WARNING: multiple messages have this Message-ID (diff)
From: Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@ozlabs.org>
Cc: linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] powerpc/64s: Better printing of machine check info for guest MCEs
Date: Wed, 20 Feb 2019 09:47:29 +0000 [thread overview]
Message-ID: <20190220093529.uegsp5fuj6ozb2mq@in.ibm.com> (raw)
In-Reply-To: <20190220010623.GE5353@blackberry>
On 2019-02-20 12:06:23 Wed, Paul Mackerras wrote:
> This adds an "in_guest" parameter to machine_check_print_event_info()
> so that we can avoid trying to translate guest NIP values into
> symbolic form using the host kernel's symbol table.
>
> Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
> ---
> arch/powerpc/include/asm/mce.h | 2 +-
> arch/powerpc/kernel/mce.c | 8 +++++---
> arch/powerpc/kvm/book3s_hv.c | 4 ++--
> arch/powerpc/platforms/powernv/opal.c | 2 +-
> 4 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/mce.h b/arch/powerpc/include/asm/mce.h
> index a8b8903..17996bc 100644
> --- a/arch/powerpc/include/asm/mce.h
> +++ b/arch/powerpc/include/asm/mce.h
> @@ -209,7 +209,7 @@ extern int get_mce_event(struct machine_check_event *mce, bool release);
> extern void release_mce_event(void);
> extern void machine_check_queue_event(void);
> extern void machine_check_print_event_info(struct machine_check_event *evt,
> - bool user_mode);
> + bool user_mode, bool in_guest);
> #ifdef CONFIG_PPC_BOOK3S_64
> void flush_and_reload_slb(void);
> #endif /* CONFIG_PPC_BOOK3S_64 */
> diff --git a/arch/powerpc/kernel/mce.c b/arch/powerpc/kernel/mce.c
> index bd933a7..d01b690 100644
> --- a/arch/powerpc/kernel/mce.c
> +++ b/arch/powerpc/kernel/mce.c
> @@ -301,13 +301,13 @@ static void machine_check_process_queued_event(struct irq_work *work)
> while (__this_cpu_read(mce_queue_count) > 0) {
> index = __this_cpu_read(mce_queue_count) - 1;
> evt = this_cpu_ptr(&mce_event_queue[index]);
> - machine_check_print_event_info(evt, false);
> + machine_check_print_event_info(evt, false, false);
> __this_cpu_dec(mce_queue_count);
> }
> }
>
> void machine_check_print_event_info(struct machine_check_event *evt,
> - bool user_mode)
> + bool user_mode, bool in_guest)
> {
> const char *level, *sevstr, *subtype;
> static const char *mc_ue_types[] = {
> @@ -387,7 +387,9 @@ void machine_check_print_event_info(struct machine_check_event *evt,
> evt->disposition = MCE_DISPOSITION_RECOVERED ?
> "Recovered" : "Not recovered");
>
> - if (user_mode) {
> + if (in_guest) {
> + printk("%s Guest NIP: %016llx\n", evt->srr0);
Missing 'level' argument. This should be:
printk("%s Guest NIP: %016llx\n", level, evt->srr0);
Rest looks fine to me.
Reviewed-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Thanks,
-Mahesh.
next prev parent reply other threads:[~2019-02-20 9:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 1:05 [PATCH 1/2] KVM: PPC: Book3S HV: Simplify machine check handling Paul Mackerras
2019-02-20 1:05 ` Paul Mackerras
2019-02-20 1:06 ` [PATCH 2/2] powerpc/64s: Better printing of machine check info for guest MCEs Paul Mackerras
2019-02-20 1:06 ` Paul Mackerras
2019-02-20 9:21 ` Aravinda Prasad
2019-02-20 9:33 ` Aravinda Prasad
2019-02-20 9:35 ` Mahesh J Salgaonkar [this message]
2019-02-20 9:47 ` Mahesh J Salgaonkar
2019-02-20 9:20 ` [PATCH 1/2] KVM: PPC: Book3S HV: Simplify machine check handling Aravinda Prasad
2019-02-20 9:32 ` Aravinda Prasad
2019-02-20 9:43 ` Mahesh J Salgaonkar
2019-02-20 9:55 ` Mahesh J Salgaonkar
-- strict thread matches above, loose matches on Subject: below --
2017-06-27 6:07 [PATCH 1/2] KVM: PPC: Book3S HV: Simplify dynamic micro-threading code Paul Mackerras
2017-06-27 6:07 ` Paul Mackerras
2017-06-27 6:09 ` [PATCH 2/2] KVM: PPC: Book3S HV: Close race with testing for signals on guest entry Paul Mackerras
2017-06-27 6:09 ` Paul Mackerras
2017-06-30 7:03 ` [PATCH v2 " Paul Mackerras
2017-06-30 7:03 ` Paul Mackerras
2017-06-30 4:54 ` [PATCH 1/2] KVM: PPC: Book3S HV: Simplify dynamic micro-threading code David Gibson
2017-06-30 4:54 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220093529.uegsp5fuj6ozb2mq@in.ibm.com \
--to=mahesh@linux.vnet.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.