From: Miquel Raynal <miquel.raynal@bootlin.com> To: Boris Brezillon <bbrezillon@kernel.org> Cc: Mason Yang <masonccyang@mxic.com.tw>, Vignesh R <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Julien Su <juliensu@mxic.com.tw>, Richard Weinberger <richard@nod.at>, Schrempf Frieder <frieder.schrempf@kontron.de>, Marek Vasut <marek.vasut@gmail.com>, linux-mtd@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 05/27] mtd: nand: Move standard OOB layouts to the NAND core Date: Thu, 21 Feb 2019 12:47:42 +0100 [thread overview] Message-ID: <20190221124742.322e38ed@xps13> (raw) In-Reply-To: <20190221121900.19d28477@kernel.org> Hi Boris, Boris Brezillon <bbrezillon@kernel.org> wrote on Thu, 21 Feb 2019 12:19:00 +0100: > On Thu, 21 Feb 2019 11:01:54 +0100 > Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > These OOB layouts are generic to all NAND chips, the should not be > > restricted to be used only by raw NAND controller drivers. They might > > later be used by generic ECC engines and SPI-NAND devices as well. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > drivers/mtd/nand/core.c | 161 ++++++++++++++++++++++++++++ > > Can we place those definitions in ecc.c instead of core.c Right after (but I can move this patch in the series easily) I create a drivers/mtd/nand/ecc/ directory with a engine.c file. If I understand your suggestion correctly, you would prefer to have the OOB layouts in this file. > > > drivers/mtd/nand/raw/nand_base.c | 161 +--------------------------- > > drivers/mtd/nand/raw/nand_toshiba.c | 2 + > > include/linux/mtd/nand.h | 4 + > > include/linux/mtd/rawnand.h | 3 - > > 5 files changed, 168 insertions(+), 163 deletions(-) Thanks, Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Boris Brezillon <bbrezillon@kernel.org> Cc: Mason Yang <masonccyang@mxic.com.tw>, Vignesh R <vigneshr@ti.com>, Tudor Ambarus <Tudor.Ambarus@microchip.com>, Julien Su <juliensu@mxic.com.tw>, Richard Weinberger <richard@nod.at>, Schrempf Frieder <frieder.schrempf@kontron.de>, Marek Vasut <marek.vasut@gmail.com>, linux-mtd@lists.infradead.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 05/27] mtd: nand: Move standard OOB layouts to the NAND core Date: Thu, 21 Feb 2019 12:47:42 +0100 [thread overview] Message-ID: <20190221124742.322e38ed@xps13> (raw) In-Reply-To: <20190221121900.19d28477@kernel.org> Hi Boris, Boris Brezillon <bbrezillon@kernel.org> wrote on Thu, 21 Feb 2019 12:19:00 +0100: > On Thu, 21 Feb 2019 11:01:54 +0100 > Miquel Raynal <miquel.raynal@bootlin.com> wrote: > > > These OOB layouts are generic to all NAND chips, the should not be > > restricted to be used only by raw NAND controller drivers. They might > > later be used by generic ECC engines and SPI-NAND devices as well. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > drivers/mtd/nand/core.c | 161 ++++++++++++++++++++++++++++ > > Can we place those definitions in ecc.c instead of core.c Right after (but I can move this patch in the series easily) I create a drivers/mtd/nand/ecc/ directory with a engine.c file. If I understand your suggestion correctly, you would prefer to have the OOB layouts in this file. > > > drivers/mtd/nand/raw/nand_base.c | 161 +--------------------------- > > drivers/mtd/nand/raw/nand_toshiba.c | 2 + > > include/linux/mtd/nand.h | 4 + > > include/linux/mtd/rawnand.h | 3 - > > 5 files changed, 168 insertions(+), 163 deletions(-) Thanks, Miquèl _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-21 11:48 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-21 10:01 [RFC PATCH 00/27] Introduce the generic ECC engine abstraction Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 01/27] mtd: nand: Move nand_device forward declaration to the top Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 02/27] mtd: nand: Compile in the NAND core by default Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 10:55 ` Boris Brezillon 2019-02-21 10:55 ` Boris Brezillon 2019-02-21 11:06 ` Miquel Raynal 2019-02-21 11:06 ` Miquel Raynal 2019-02-21 11:14 ` Boris Brezillon 2019-02-21 11:14 ` Boris Brezillon 2019-02-21 11:46 ` Miquel Raynal 2019-02-21 11:46 ` Miquel Raynal 2019-02-21 12:08 ` Boris Brezillon 2019-02-21 12:08 ` Boris Brezillon 2019-02-21 12:52 ` Miquel Raynal 2019-02-21 12:52 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 03/27] mtd: nand: Introduce the ECC engine abstraction Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 11:16 ` Boris Brezillon 2019-02-21 11:16 ` Boris Brezillon 2019-02-27 9:26 ` Miquel Raynal 2019-02-27 9:26 ` Miquel Raynal 2019-02-27 9:47 ` Boris Brezillon 2019-02-27 9:47 ` Boris Brezillon 2019-02-25 18:55 ` Boris Brezillon 2019-02-25 18:55 ` Boris Brezillon 2019-02-27 13:56 ` Miquel Raynal 2019-02-27 13:56 ` Miquel Raynal 2019-02-27 14:06 ` Boris Brezillon 2019-02-27 14:06 ` Boris Brezillon 2019-02-27 14:19 ` Miquel Raynal 2019-02-27 14:19 ` Miquel Raynal 2019-02-27 14:28 ` Boris Brezillon 2019-02-27 14:28 ` Boris Brezillon 2019-02-27 14:34 ` Miquel Raynal 2019-02-27 14:34 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 04/27] mtd: Fix typo in mtd_ooblayout_set_databytes() description Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 05/27] mtd: nand: Move standard OOB layouts to the NAND core Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 11:19 ` Boris Brezillon 2019-02-21 11:19 ` Boris Brezillon 2019-02-21 11:47 ` Miquel Raynal [this message] 2019-02-21 11:47 ` Miquel Raynal 2019-02-21 12:10 ` Boris Brezillon 2019-02-21 12:10 ` Boris Brezillon 2019-02-21 10:01 ` [RFC PATCH 06/27] mtd: nand: Move ECC specific functions to ecc/engine.c Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 07/27] mtd: nand: ecc: Move BCH code into the ecc/ directory Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 08/27] mtd: nand: ecc: Use SPDX license identifier for the software BCH code Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 11:25 ` Boris Brezillon 2019-02-21 11:25 ` Boris Brezillon 2019-02-21 11:48 ` Miquel Raynal 2019-02-21 11:48 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 09/27] mtd: nand: ecc: Turn the software BCH implementation generic Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 12:26 ` Boris Brezillon 2019-02-21 12:26 ` Boris Brezillon 2019-02-21 12:53 ` Miquel Raynal 2019-02-21 12:53 ` Miquel Raynal 2019-02-21 10:01 ` [RFC PATCH 10/27] mtd: rawnand: Get rid of chip->ecc.priv Miquel Raynal 2019-02-21 10:01 ` Miquel Raynal 2019-02-21 13:01 ` Boris Brezillon 2019-02-21 13:01 ` Boris Brezillon 2019-02-21 10:02 ` [RFC PATCH 11/27] mtd: nand: ecc: Move Hamming code into the ecc/ directory Miquel Raynal 2019-02-21 10:02 ` Miquel Raynal 2019-02-21 10:02 ` [RFC PATCH 12/27] mtd: nand: ecc: Use SPDX license identifier for the software Hamming code Miquel Raynal 2019-02-21 10:02 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190221124742.322e38ed@xps13 \ --to=miquel.raynal@bootlin.com \ --cc=Tudor.Ambarus@microchip.com \ --cc=bbrezillon@kernel.org \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=frieder.schrempf@kontron.de \ --cc=juliensu@mxic.com.tw \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=masonccyang@mxic.com.tw \ --cc=richard@nod.at \ --cc=thomas.petazzoni@bootlin.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.