From: Dan Carpenter <dan.carpenter@oracle.com>
To: Steve French <smfrench@gmail.com>
Cc: Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>
Subject: Re: [PATCH] cifs: Clean up an error code in cifs_root_iget()
Date: Thu, 28 Feb 2019 16:34:36 +0300 [thread overview]
Message-ID: <20190228133435.GB9806@kadam> (raw)
In-Reply-To: <CAH2r5ms1+5Kj_qmWx3oww7Af_rfiCSBbkGos_gqieqH7jW98BQ@mail.gmail.com>
On Wed, Feb 27, 2019 at 11:44:14PM -0600, Steve French wrote:
> Won't that change behavior and cause the success case (server returned
> 0, and does support POSIX and &inode pointer is ok) to now return
> -EINVAL.
>
You're right. I'm really sorry. I don't know why I misread the code...
Also looking at it now, this was a false positive in Smatch. I have
been working on that code in the past couple days and I don't have the
warning in my latest build.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Steve French <smfrench@gmail.com>
Cc: Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>
Subject: Re: [PATCH] cifs: Clean up an error code in cifs_root_iget()
Date: Thu, 28 Feb 2019 13:34:36 +0000 [thread overview]
Message-ID: <20190228133435.GB9806@kadam> (raw)
In-Reply-To: <CAH2r5ms1+5Kj_qmWx3oww7Af_rfiCSBbkGos_gqieqH7jW98BQ@mail.gmail.com>
On Wed, Feb 27, 2019 at 11:44:14PM -0600, Steve French wrote:
> Won't that change behavior and cause the success case (server returned
> 0, and does support POSIX and &inode pointer is ok) to now return
> -EINVAL.
>
You're right. I'm really sorry. I don't know why I misread the code...
Also looking at it now, this was a false positive in Smatch. I have
been working on that code in the past couple days and I don't have the
warning in my latest build.
regards,
dan carpenter
next prev parent reply other threads:[~2019-02-28 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 5:26 [PATCH] cifs: Clean up an error code in cifs_root_iget() Dan Carpenter
2019-02-28 5:26 ` Dan Carpenter
2019-02-28 5:44 ` Steve French
2019-02-28 5:44 ` Steve French
2019-02-28 13:34 ` Dan Carpenter [this message]
2019-02-28 13:34 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228133435.GB9806@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.