All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ondrej Mosnacek <omosnace@redhat.com>
Subject: [PATCH 9/9] crypto: testmgr - remove workaround for AEADs that modify aead_request
Date: Sun, 10 Mar 2019 12:00:58 -0700	[thread overview]
Message-ID: <20190310190058.4912-10-ebiggers@kernel.org> (raw)
In-Reply-To: <20190310190058.4912-1-ebiggers@kernel.org>

From: Eric Biggers <ebiggers@google.com>

Now that all AEAD algorithms (that I have the hardware to test, at
least) have been fixed to not modify the user-provided aead_request,
remove the workaround from testmgr that reset aead_request::tfm after
each AEAD encryption/decryption.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 crypto/testmgr.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 8386038d67c7..5d56b2990762 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -1237,9 +1237,6 @@ static int test_aead_vec_cfg(const char *driver, int enc,
 	aead_request_set_ad(req, vec->alen);
 	err = crypto_wait_req(enc ? crypto_aead_encrypt(req) :
 			      crypto_aead_decrypt(req), &wait);
-
-	aead_request_set_tfm(req, tfm); /* TODO: get rid of this */
-
 	if (err) {
 		if (err == -EBADMSG && vec->novrfy)
 			return 0;
-- 
2.21.0


  parent reply	other threads:[~2019-03-10 19:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-10 19:00 [PATCH 0/9] crypto: add SIMD helpers for AEADs Eric Biggers
2019-03-10 19:00 ` [PATCH 1/9] crypto: simd - support wrapping AEAD algorithms Eric Biggers
2019-03-10 19:00 ` [PATCH 2/9] crypto: x86/aesni - convert to use skcipher SIMD bulk registration Eric Biggers
2019-03-10 19:00 ` [PATCH 3/9] crypto: x86/aesni - convert to use AEAD SIMD helpers Eric Biggers
2019-03-10 19:00 ` [PATCH 4/9] crypto: x86/aegis128 " Eric Biggers
2019-03-10 19:00 ` [PATCH 5/9] crypto: x86/aegis128l " Eric Biggers
2019-03-10 19:00 ` [PATCH 6/9] crypto: x86/aegis256 " Eric Biggers
2019-03-10 19:00 ` [PATCH 7/9] crypto: x86/morus640 " Eric Biggers
2019-03-10 19:00 ` [PATCH 8/9] crypto: x86/morus1280 " Eric Biggers
2019-03-10 19:00 ` Eric Biggers [this message]
2019-03-15  7:45 ` [PATCH 0/9] crypto: add SIMD helpers for AEADs Ondrej Mosnacek
2019-03-22 13:03 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190310190058.4912-10-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=omosnace@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.