From: Herbert Xu <herbert@gondor.apana.org.au>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, Ondrej Mosnacek <omosnace@redhat.com>
Subject: Re: [PATCH 0/9] crypto: add SIMD helpers for AEADs
Date: Fri, 22 Mar 2019 21:03:33 +0800 [thread overview]
Message-ID: <20190322130333.epv6t5at7zxpchj6@gondor.apana.org.au> (raw)
In-Reply-To: <20190310190058.4912-1-ebiggers@kernel.org>
On Sun, Mar 10, 2019 at 12:00:49PM -0700, Eric Biggers wrote:
> This series updates crypto_simd to support wrapping AEADs, then makes
> all AEADs that implement the same functionality use crypto_simd instead.
>
> This simplifies the code, and it also fixes the bug where these
> algorithms modify the user-provided aead_request. This was a problem
> because users may expect to be able to use the same aead_request for
> another encryption/decryption without reinitializing everything. The
> last patch removes the test workaround now that this bug is fixed.
>
> Eric Biggers (9):
> crypto: simd - support wrapping AEAD algorithms
> crypto: x86/aesni - convert to use skcipher SIMD bulk registration
> crypto: x86/aesni - convert to use AEAD SIMD helpers
> crypto: x86/aegis128 - convert to use AEAD SIMD helpers
> crypto: x86/aegis128l - convert to use AEAD SIMD helpers
> crypto: x86/aegis256 - convert to use AEAD SIMD helpers
> crypto: x86/morus640 - convert to use AEAD SIMD helpers
> crypto: x86/morus1280 - convert to use AEAD SIMD helpers
> crypto: testmgr - remove workaround for AEADs that modify aead_request
>
> arch/x86/crypto/aegis128-aesni-glue.c | 157 +++------------
> arch/x86/crypto/aegis128l-aesni-glue.c | 157 +++------------
> arch/x86/crypto/aegis256-aesni-glue.c | 157 +++------------
> arch/x86/crypto/aesni-intel_glue.c | 204 ++-----------------
> arch/x86/crypto/morus1280-avx2-glue.c | 12 +-
> arch/x86/crypto/morus1280-sse2-glue.c | 12 +-
> arch/x86/crypto/morus1280_glue.c | 85 --------
> arch/x86/crypto/morus640-sse2-glue.c | 12 +-
> arch/x86/crypto/morus640_glue.c | 85 --------
> crypto/Kconfig | 10 +-
> crypto/simd.c | 269 +++++++++++++++++++++++++
> crypto/testmgr.c | 3 -
> include/crypto/internal/simd.h | 20 ++
> include/crypto/morus1280_glue.h | 79 ++------
> include/crypto/morus640_glue.h | 79 ++------
> 15 files changed, 471 insertions(+), 870 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-03-22 13:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-10 19:00 [PATCH 0/9] crypto: add SIMD helpers for AEADs Eric Biggers
2019-03-10 19:00 ` [PATCH 1/9] crypto: simd - support wrapping AEAD algorithms Eric Biggers
2019-03-10 19:00 ` [PATCH 2/9] crypto: x86/aesni - convert to use skcipher SIMD bulk registration Eric Biggers
2019-03-10 19:00 ` [PATCH 3/9] crypto: x86/aesni - convert to use AEAD SIMD helpers Eric Biggers
2019-03-10 19:00 ` [PATCH 4/9] crypto: x86/aegis128 " Eric Biggers
2019-03-10 19:00 ` [PATCH 5/9] crypto: x86/aegis128l " Eric Biggers
2019-03-10 19:00 ` [PATCH 6/9] crypto: x86/aegis256 " Eric Biggers
2019-03-10 19:00 ` [PATCH 7/9] crypto: x86/morus640 " Eric Biggers
2019-03-10 19:00 ` [PATCH 8/9] crypto: x86/morus1280 " Eric Biggers
2019-03-10 19:00 ` [PATCH 9/9] crypto: testmgr - remove workaround for AEADs that modify aead_request Eric Biggers
2019-03-15 7:45 ` [PATCH 0/9] crypto: add SIMD helpers for AEADs Ondrej Mosnacek
2019-03-22 13:03 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322130333.epv6t5at7zxpchj6@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=omosnace@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.