From: Helen Koike <helen.koike@collabora.com>
To: dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com
Cc: andrey.grodzovsky@amd.com, daniel.vetter@ffwll.ch,
linux-kernel@vger.kernel.org, "Tomasz Figa" <tfiga@chromium.org>,
boris.brezillon@collabora.com, "David Airlie" <airlied@linux.ie>,
"Sean Paul" <seanpaul@google.com>,
kernel@collabora.com, harry.wentland@amd.com,
"Stéphane Marchesin" <marcheu@google.com>,
"Helen Koike" <helen.koike@collabora.com>,
"Sean Paul" <sean@poorly.run>, "Sandy Huang" <hjc@rock-chips.com>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
eric@anholt.net, "Alex Deucher" <alexander.deucher@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Anthony Koo" <Anthony.Koo@amd.com>,
amd-gfx@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
"Ville Syrjälä" <ville.syrjala@li>
Subject: [PATCH v2 0/5] drm: Fix fb changes for async updates
Date: Mon, 11 Mar 2019 23:21:58 -0300 [thread overview]
Message-ID: <20190312022204.2775-1-helen.koike@collabora.com> (raw)
Hello,
This series fixes the slow down in performance introduced by
"[PATCH v2] drm: Block fb changes for async plane updates" where async update
falls back to a sync update, causing igt failures of type:
"CRITICAL: completed 97 cursor updated in a period of 30 flips, we
expect to complete approximately 15360 updates, with the threshold set
at 7680"
Please read the commit message of "drm: don't block fb changes for async
plane updates" to understand how it works.
I tested on the rockchip, on i915 and on vc4 with igt plane_cursor_legacy and
kms_cursor_legacy and I didn't see any regressions.
I couldn't test on MSM and AMD because I don't have the hardware
I would appreciate if anyone could help me testing those.
v1 link: https://patchwork.kernel.org/cover/10837847/
Thanks!
Helen
Changes in v2:
- added reviewed-by tag
- update CC stable and Fixes tag
- Added reviewed-by tag
- updated CC stable and Fixes tag
- Change the order of the patch in the series, add this as the last one.
- Add documentation
- s/ballanced/balanced
Helen Koike (5):
drm/rockchip: fix fb references in async update
drm/amd: fix fb references in async update
drm/msm: fix fb references in async update
drm/vc4: fix fb references in async update
drm: don't block fb changes for async plane updates
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-
drivers/gpu/drm/drm_atomic_helper.c | 20 ++++-----
drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 42 +++++++++++--------
drivers/gpu/drm/vc4/vc4_plane.c | 2 +-
include/drm/drm_modeset_helper_vtables.h | 5 +++
6 files changed, 45 insertions(+), 31 deletions(-)
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Helen Koike <helen.koike@collabora.com>
To: dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com
Cc: andrey.grodzovsky@amd.com, daniel.vetter@ffwll.ch,
linux-kernel@vger.kernel.org, "Tomasz Figa" <tfiga@chromium.org>,
boris.brezillon@collabora.com, "David Airlie" <airlied@linux.ie>,
"Sean Paul" <seanpaul@google.com>,
kernel@collabora.com, harry.wentland@amd.com,
"Stéphane Marchesin" <marcheu@google.com>,
"Helen Koike" <helen.koike@collabora.com>,
"Sean Paul" <sean@poorly.run>, "Sandy Huang" <hjc@rock-chips.com>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
eric@anholt.net, "Alex Deucher" <alexander.deucher@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Anthony Koo" <Anthony.Koo@amd.com>,
amd-gfx@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Rob Clark" <robdclark@gmail.com>,
"Heiko Stübner" <heiko@sntech.de>, "Leo Li" <sunpeng.li@amd.com>,
linux-arm-msm@vger.kernel.org,
"Christian König" <christian.koenig@amd.com>,
linux-arm-kernel@lists.infradead.org,
"David Francis" <David.Francis@amd.com>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Mamta Shukla" <mamtashukla555@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
freedreno@lists.freedesktop.org,
"Sean Paul" <seanpaul@chromium.org>,
"Daniel Vetter" <daniel@ffwll.ch>
Subject: [PATCH v2 0/5] drm: Fix fb changes for async updates
Date: Mon, 11 Mar 2019 23:21:58 -0300 [thread overview]
Message-ID: <20190312022204.2775-1-helen.koike@collabora.com> (raw)
Hello,
This series fixes the slow down in performance introduced by
"[PATCH v2] drm: Block fb changes for async plane updates" where async update
falls back to a sync update, causing igt failures of type:
"CRITICAL: completed 97 cursor updated in a period of 30 flips, we
expect to complete approximately 15360 updates, with the threshold set
at 7680"
Please read the commit message of "drm: don't block fb changes for async
plane updates" to understand how it works.
I tested on the rockchip, on i915 and on vc4 with igt plane_cursor_legacy and
kms_cursor_legacy and I didn't see any regressions.
I couldn't test on MSM and AMD because I don't have the hardware
I would appreciate if anyone could help me testing those.
v1 link: https://patchwork.kernel.org/cover/10837847/
Thanks!
Helen
Changes in v2:
- added reviewed-by tag
- update CC stable and Fixes tag
- Added reviewed-by tag
- updated CC stable and Fixes tag
- Change the order of the patch in the series, add this as the last one.
- Add documentation
- s/ballanced/balanced
Helen Koike (5):
drm/rockchip: fix fb references in async update
drm/amd: fix fb references in async update
drm/msm: fix fb references in async update
drm/vc4: fix fb references in async update
drm: don't block fb changes for async plane updates
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-
drivers/gpu/drm/drm_atomic_helper.c | 20 ++++-----
drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 42 +++++++++++--------
drivers/gpu/drm/vc4/vc4_plane.c | 2 +-
include/drm/drm_modeset_helper_vtables.h | 5 +++
6 files changed, 45 insertions(+), 31 deletions(-)
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Helen Koike <helen.koike@collabora.com>
To: dri-devel@lists.freedesktop.org, nicholas.kazlauskas@amd.com
Cc: "Heiko Stübner" <heiko@sntech.de>,
"Sean Paul" <seanpaul@google.com>,
"David Airlie" <airlied@linux.ie>,
daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org,
eric@anholt.net, "Mamta Shukla" <mamtashukla555@gmail.com>,
kernel@collabora.com, "Anthony Koo" <Anthony.Koo@amd.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"David Francis" <David.Francis@amd.com>,
amd-gfx@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, harry.wentland@amd.com,
andrey.grodzovsky@amd.com, "Leo Li" <sunpeng.li@amd.com>,
linux-arm-msm@vger.kernel.org,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Helen Koike" <helen.koike@collabora.com>,
"Sean Paul" <seanpaul@chromium.org>,
"Mikita Lipski" <mikita.lipski@amd.com>,
"Sean Paul" <sean@poorly.run>,
linux-arm-kernel@lists.infradead.org,
"Stéphane Marchesin" <marcheu@google.com>,
freedreno@lists.freedesktop.org,
"Sandy Huang" <hjc@rock-chips.com>,
"Tomasz Figa" <tfiga@chromium.org>,
"Rob Clark" <robdclark@gmail.com>,
boris.brezillon@collabora.com, "Daniel Vetter" <daniel@ffwll.ch>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Russell King" <rmk+kernel@armlinux.org.uk>,
"Christian König" <christian.koenig@amd.com>
Subject: [PATCH v2 0/5] drm: Fix fb changes for async updates
Date: Mon, 11 Mar 2019 23:21:58 -0300 [thread overview]
Message-ID: <20190312022204.2775-1-helen.koike@collabora.com> (raw)
Hello,
This series fixes the slow down in performance introduced by
"[PATCH v2] drm: Block fb changes for async plane updates" where async update
falls back to a sync update, causing igt failures of type:
"CRITICAL: completed 97 cursor updated in a period of 30 flips, we
expect to complete approximately 15360 updates, with the threshold set
at 7680"
Please read the commit message of "drm: don't block fb changes for async
plane updates" to understand how it works.
I tested on the rockchip, on i915 and on vc4 with igt plane_cursor_legacy and
kms_cursor_legacy and I didn't see any regressions.
I couldn't test on MSM and AMD because I don't have the hardware
I would appreciate if anyone could help me testing those.
v1 link: https://patchwork.kernel.org/cover/10837847/
Thanks!
Helen
Changes in v2:
- added reviewed-by tag
- update CC stable and Fixes tag
- Added reviewed-by tag
- updated CC stable and Fixes tag
- Change the order of the patch in the series, add this as the last one.
- Add documentation
- s/ballanced/balanced
Helen Koike (5):
drm/rockchip: fix fb references in async update
drm/amd: fix fb references in async update
drm/msm: fix fb references in async update
drm/vc4: fix fb references in async update
drm: don't block fb changes for async plane updates
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-
drivers/gpu/drm/drm_atomic_helper.c | 20 ++++-----
drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 4 ++
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 42 +++++++++++--------
drivers/gpu/drm/vc4/vc4_plane.c | 2 +-
include/drm/drm_modeset_helper_vtables.h | 5 +++
6 files changed, 45 insertions(+), 31 deletions(-)
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-03-12 2:21 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 2:21 Helen Koike [this message]
2019-03-12 2:21 ` [PATCH v2 0/5] drm: Fix fb changes for async updates Helen Koike
2019-03-12 2:21 ` Helen Koike
2019-03-12 2:21 ` [PATCH v2 1/5] drm/rockchip: fix fb references in async update Helen Koike
2019-03-12 2:21 ` Helen Koike
2019-03-12 6:34 ` Boris Brezillon
2019-03-12 6:34 ` Boris Brezillon
2019-03-12 11:04 ` Daniel Vetter
2019-03-12 11:04 ` Daniel Vetter
2019-03-12 15:34 ` Helen Koike
2019-03-12 15:34 ` Helen Koike
2019-03-12 15:34 ` Helen Koike
2019-03-12 15:52 ` Boris Brezillon
2019-03-12 15:52 ` Boris Brezillon
2019-03-12 15:52 ` Boris Brezillon
2019-03-13 3:42 ` Tomasz Figa
2019-03-13 3:42 ` Tomasz Figa
2019-03-13 3:42 ` Tomasz Figa
2019-03-13 9:58 ` Michel Dänzer
2019-03-13 9:58 ` Michel Dänzer
2019-03-13 9:58 ` Michel Dänzer
2019-03-13 18:08 ` Helen Koike
2019-03-13 18:08 ` Helen Koike
2019-03-14 9:15 ` Michel Dänzer
2019-03-14 9:15 ` Michel Dänzer
2019-03-14 9:15 ` Michel Dänzer
2019-03-14 17:51 ` Helen Koike
2019-03-14 17:51 ` Helen Koike
2019-03-15 10:11 ` Michel Dänzer
2019-03-15 10:11 ` Michel Dänzer
2019-03-15 10:25 ` Boris Brezillon
2019-03-15 10:25 ` Boris Brezillon
2019-03-15 11:29 ` Michel Dänzer
2019-03-15 11:29 ` Michel Dänzer
2019-03-15 16:54 ` Helen Koike
2019-03-15 16:54 ` Helen Koike
2019-03-12 2:22 ` [PATCH v2 2/5] drm/amd: " Helen Koike
2019-03-12 2:22 ` Helen Koike
2019-03-12 2:22 ` [PATCH v2 3/5] drm/msm: " Helen Koike
2019-03-12 2:22 ` [PATCH v2 4/5] drm/vc4: " Helen Koike
2019-03-25 0:38 ` Sasha Levin
2019-03-12 2:22 ` [PATCH v2 5/5] drm: don't block fb changes for async plane updates Helen Koike
2019-03-12 2:22 ` Helen Koike
2019-03-12 2:22 ` Helen Koike
2019-03-12 6:44 ` Boris Brezillon
2019-03-12 6:44 ` Boris Brezillon
2019-03-12 6:44 ` Boris Brezillon
2019-03-12 12:49 ` Kazlauskas, Nicholas
2019-03-12 12:49 ` Kazlauskas, Nicholas
2019-03-12 12:49 ` Kazlauskas, Nicholas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312022204.2775-1-helen.koike@collabora.com \
--to=helen.koike@collabora.com \
--cc=Anthony.Koo@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrey.grodzovsky@amd.com \
--cc=boris.brezillon@collabora.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=harry.wentland@amd.com \
--cc=hjc@rock-chips.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcheu@google.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=sean@poorly.run \
--cc=seanpaul@google.com \
--cc=tfiga@chromium.org \
--cc=ville.syrjala@li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.