From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Jernej Škrabec" <jernej.skrabec@siol.net>,
wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com,
dan.j.williams@intel.com, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: [2/6] dmaengine: sun6i: Add a quirk for additional mbus clock
Date: Fri, 22 Mar 2019 14:03:25 +0100 [thread overview]
Message-ID: <20190322130325.jomwzsntzwjt6zhj@flea> (raw)
On Fri, Mar 22, 2019 at 06:29:40PM +0530, Vinod Koul wrote:
> On 16-03-19, 12:23, Jernej Škrabec wrote:
> > Hi!
> >
> > Dne sobota, 16. marec 2019 ob 12:07:53 CET je Vinod Koul napisal(a):
> > > On 07-03-19, 17:58, Jernej Skrabec wrote:
> > > > H6 DMA controller needs additional mbus clock to be enabled.
> > > >
> > > > Add a quirk for it and handle it accordingly.
> > > >
> > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > > > ---
> > > >
> > > > drivers/dma/sun6i-dma.c | 23 ++++++++++++++++++++++-
> > > > 1 file changed, 22 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> > > > index 0cd13f17fc11..761555080325 100644
> > > > --- a/drivers/dma/sun6i-dma.c
> > > > +++ b/drivers/dma/sun6i-dma.c
> > > > @@ -129,6 +129,7 @@ struct sun6i_dma_config {
> > > >
> > > > u32 dst_burst_lengths;
> > > > u32 src_addr_widths;
> > > > u32 dst_addr_widths;
> > > >
> > > > + bool mbus_clk;
> > > >
> > > > };
> > > >
> > > > /*
> > > >
> > > > @@ -182,6 +183,7 @@ struct sun6i_dma_dev {
> > > >
> > > > struct dma_device slave;
> > > > void __iomem *base;
> > > > struct clk *clk;
> > > >
> > > > + struct clk *clk_mbus;
> > >
> > > So rather than have mbus_clk and then a ptr, why not use the ptr and use
> > > NULL value to check for..?
> > >
> >
> > I'm not sure what you mean here. clk_mbus will hold a reference to a clock
> > retrieved by devm_clk_get() so it has to be "struct clk *".
> >
> > What I'm missing here?
>
> IIRC there were two variable one clk ptr and one an integer to mark
> presence, you may be able to skip variable and use ptr..
If we're doing that, then we would effectively make it optional. That
DMA engine cannot operate without it.
Maxime
---
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Jernej Škrabec" <jernej.skrabec@siol.net>,
wens@csie.org, robh+dt@kernel.org, mark.rutland@arm.com,
dan.j.williams@intel.com, dmaengine@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/6] dmaengine: sun6i: Add a quirk for additional mbus clock
Date: Fri, 22 Mar 2019 14:03:25 +0100 [thread overview]
Message-ID: <20190322130325.jomwzsntzwjt6zhj@flea> (raw)
In-Reply-To: <20190322125940.GE5348@vkoul-mobl>
[-- Attachment #1: Type: text/plain, Size: 1911 bytes --]
On Fri, Mar 22, 2019 at 06:29:40PM +0530, Vinod Koul wrote:
> On 16-03-19, 12:23, Jernej Škrabec wrote:
> > Hi!
> >
> > Dne sobota, 16. marec 2019 ob 12:07:53 CET je Vinod Koul napisal(a):
> > > On 07-03-19, 17:58, Jernej Skrabec wrote:
> > > > H6 DMA controller needs additional mbus clock to be enabled.
> > > >
> > > > Add a quirk for it and handle it accordingly.
> > > >
> > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > > > ---
> > > >
> > > > drivers/dma/sun6i-dma.c | 23 ++++++++++++++++++++++-
> > > > 1 file changed, 22 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> > > > index 0cd13f17fc11..761555080325 100644
> > > > --- a/drivers/dma/sun6i-dma.c
> > > > +++ b/drivers/dma/sun6i-dma.c
> > > > @@ -129,6 +129,7 @@ struct sun6i_dma_config {
> > > >
> > > > u32 dst_burst_lengths;
> > > > u32 src_addr_widths;
> > > > u32 dst_addr_widths;
> > > >
> > > > + bool mbus_clk;
> > > >
> > > > };
> > > >
> > > > /*
> > > >
> > > > @@ -182,6 +183,7 @@ struct sun6i_dma_dev {
> > > >
> > > > struct dma_device slave;
> > > > void __iomem *base;
> > > > struct clk *clk;
> > > >
> > > > + struct clk *clk_mbus;
> > >
> > > So rather than have mbus_clk and then a ptr, why not use the ptr and use
> > > NULL value to check for..?
> > >
> >
> > I'm not sure what you mean here. clk_mbus will hold a reference to a clock
> > retrieved by devm_clk_get() so it has to be "struct clk *".
> >
> > What I'm missing here?
>
> IIRC there were two variable one clk ptr and one an integer to mark
> presence, you may be able to skip variable and use ptr..
If we're doing that, then we would effectively make it optional. That
DMA engine cannot operate without it.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
"Jernej Škrabec" <jernej.skrabec@siol.net>,
linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
wens@csie.org, robh+dt@kernel.org, dmaengine@vger.kernel.org,
dan.j.williams@intel.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/6] dmaengine: sun6i: Add a quirk for additional mbus clock
Date: Fri, 22 Mar 2019 14:03:25 +0100 [thread overview]
Message-ID: <20190322130325.jomwzsntzwjt6zhj@flea> (raw)
In-Reply-To: <20190322125940.GE5348@vkoul-mobl>
[-- Attachment #1.1: Type: text/plain, Size: 1911 bytes --]
On Fri, Mar 22, 2019 at 06:29:40PM +0530, Vinod Koul wrote:
> On 16-03-19, 12:23, Jernej Škrabec wrote:
> > Hi!
> >
> > Dne sobota, 16. marec 2019 ob 12:07:53 CET je Vinod Koul napisal(a):
> > > On 07-03-19, 17:58, Jernej Skrabec wrote:
> > > > H6 DMA controller needs additional mbus clock to be enabled.
> > > >
> > > > Add a quirk for it and handle it accordingly.
> > > >
> > > > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> > > > ---
> > > >
> > > > drivers/dma/sun6i-dma.c | 23 ++++++++++++++++++++++-
> > > > 1 file changed, 22 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c
> > > > index 0cd13f17fc11..761555080325 100644
> > > > --- a/drivers/dma/sun6i-dma.c
> > > > +++ b/drivers/dma/sun6i-dma.c
> > > > @@ -129,6 +129,7 @@ struct sun6i_dma_config {
> > > >
> > > > u32 dst_burst_lengths;
> > > > u32 src_addr_widths;
> > > > u32 dst_addr_widths;
> > > >
> > > > + bool mbus_clk;
> > > >
> > > > };
> > > >
> > > > /*
> > > >
> > > > @@ -182,6 +183,7 @@ struct sun6i_dma_dev {
> > > >
> > > > struct dma_device slave;
> > > > void __iomem *base;
> > > > struct clk *clk;
> > > >
> > > > + struct clk *clk_mbus;
> > >
> > > So rather than have mbus_clk and then a ptr, why not use the ptr and use
> > > NULL value to check for..?
> > >
> >
> > I'm not sure what you mean here. clk_mbus will hold a reference to a clock
> > retrieved by devm_clk_get() so it has to be "struct clk *".
> >
> > What I'm missing here?
>
> IIRC there were two variable one clk ptr and one an integer to mark
> presence, you may be able to skip variable and use ptr..
If we're doing that, then we would effectively make it optional. That
DMA engine cannot operate without it.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-03-22 13:03 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 13:03 Maxime Ripard [this message]
2019-03-22 13:03 ` [PATCH 2/6] dmaengine: sun6i: Add a quirk for additional mbus clock Maxime Ripard
2019-03-22 13:03 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2019-03-27 23:47 [1/6] dt-bindings: arm64: allwinner: h6: Add binding for DMA controller Rob Herring
2019-03-27 23:47 ` [PATCH 1/6] " Rob Herring
2019-03-27 23:47 ` Rob Herring
2019-03-27 23:47 ` Rob Herring
2019-03-22 12:59 [2/6] dmaengine: sun6i: Add a quirk for additional mbus clock Vinod Koul
2019-03-22 12:59 ` [PATCH 2/6] " Vinod Koul
2019-03-22 12:59 ` Vinod Koul
2019-03-16 11:37 [5/6] dmaengine: sun6i: Add support for H6 DMA Jernej Škrabec
2019-03-16 11:37 ` [PATCH 5/6] " Jernej Škrabec
2019-03-16 11:37 ` Jernej Škrabec
2019-03-16 11:37 ` Jernej Škrabec
2019-03-16 11:27 [1/6] dt-bindings: arm64: allwinner: h6: Add binding for DMA controller Jernej Škrabec
2019-03-16 11:27 ` [PATCH 1/6] " Jernej Škrabec
2019-03-16 11:27 ` Jernej Škrabec
2019-03-16 11:27 ` Jernej Škrabec
2019-03-16 11:23 [2/6] dmaengine: sun6i: Add a quirk for additional mbus clock Jernej Škrabec
2019-03-16 11:23 ` [PATCH 2/6] " Jernej Škrabec
2019-03-16 11:23 ` Jernej Škrabec
2019-03-16 11:23 ` Jernej Škrabec
2019-03-16 11:13 [5/6] dmaengine: sun6i: Add support for H6 DMA Vinod Koul
2019-03-16 11:13 ` [PATCH 5/6] " Vinod Koul
2019-03-16 11:13 ` Vinod Koul
2019-03-16 11:13 ` Vinod Koul
2019-03-16 11:07 [2/6] dmaengine: sun6i: Add a quirk for additional mbus clock Vinod Koul
2019-03-16 11:07 ` [PATCH 2/6] " Vinod Koul
2019-03-16 11:07 ` Vinod Koul
2019-03-16 11:07 ` Vinod Koul
2019-03-16 10:57 [1/6] dt-bindings: arm64: allwinner: h6: Add binding for DMA controller Vinod Koul
2019-03-16 10:57 ` [PATCH 1/6] " Vinod Koul
2019-03-16 10:57 ` Vinod Koul
2019-03-16 10:57 ` Vinod Koul
2019-03-11 5:47 [2/6] dmaengine: sun6i: Add a quirk for additional mbus clock Chen-Yu Tsai
2019-03-11 5:47 ` [PATCH 2/6] " Chen-Yu Tsai
2019-03-11 5:47 ` Chen-Yu Tsai
2019-03-07 16:58 [6/6] arm64: dts: allwinner: h6: Add DMA node Jernej Škrabec
2019-03-07 16:58 ` [PATCH 6/6] " Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 [5/6] dmaengine: sun6i: Add support for H6 DMA Jernej Škrabec
2019-03-07 16:58 ` [PATCH 5/6] " Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 [4/6] dmaengine: sun6i: Add a quirk for setting mode fields Jernej Škrabec
2019-03-07 16:58 ` [PATCH 4/6] " Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 [3/6] dmaengine: sun6i: Add a quirk for setting DRQ fields Jernej Škrabec
2019-03-07 16:58 ` [PATCH 3/6] " Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 [2/6] dmaengine: sun6i: Add a quirk for additional mbus clock Jernej Škrabec
2019-03-07 16:58 ` [PATCH 2/6] " Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 [1/6] dt-bindings: arm64: allwinner: h6: Add binding for DMA controller Jernej Škrabec
2019-03-07 16:58 ` [PATCH 1/6] " Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 [PATCH 0/6] Allwinner H6 DMA support Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
2019-03-07 16:58 ` Jernej Skrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322130325.jomwzsntzwjt6zhj@flea \
--to=maxime.ripard@bootlin.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.