From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Andrew Morton <akpm@linux-foundation.org>,
John Hubbard <jhubbard@nvidia.com>,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mips@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Linux-sh <linux-sh@vger.kernel.org>,
sparclinux@vger.kernel.org,
linux-rdma <linux-rdma@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RESEND 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast
Date: Mon, 25 Mar 2019 14:54:11 +0000 [thread overview]
Message-ID: <20190325145411.GI16366@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <CAPcyv4hG8WDhsWinXHYkReHKS6gdQ3gAHMcfVWvuP4c4SYBzXQ@mail.gmail.com>
On Mon, Mar 25, 2019 at 03:36:28PM -0700, Dan Williams wrote:
> On Mon, Mar 25, 2019 at 3:22 PM Ira Weiny <ira.weiny@intel.com> wrote:
> [..]
> > FWIW this thread is making me think my original patch which simply implemented
> > get_user_pages_fast_longterm() would be more clear. There is some evidence
> > that the GUP API was trending that way (see get_user_pages_remote). That seems
> > wrong but I don't know how to ensure users don't specify the wrong flag.
>
> What about just making the existing get_user_pages_longterm() have a
> fast path option?
That would work but was not the direction we agreed upon before.[1]
At this point I would rather see this patch set applied, focus on fixing the
filesystem issues, and once that is done determine if FOLL_LONGTERM is needed
in any GUP calls.
Ira
[1] https://lkml.org/lkml/2019/2/11/2038
WARNING: multiple messages have this Message-ID (diff)
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Andrew Morton <akpm@linux-foundation.org>,
John Hubbard <jhubbard@nvidia.com>,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>,
linux-mm <linux-mm@kvack.org>Linux Kernel Mailing List <l>
Subject: Re: [RESEND 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast
Date: Mon, 25 Mar 2019 07:54:11 -0700 [thread overview]
Message-ID: <20190325145411.GI16366@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <CAPcyv4hG8WDhsWinXHYkReHKS6gdQ3gAHMcfVWvuP4c4SYBzXQ@mail.gmail.com>
On Mon, Mar 25, 2019 at 03:36:28PM -0700, Dan Williams wrote:
> On Mon, Mar 25, 2019 at 3:22 PM Ira Weiny <ira.weiny@intel.com> wrote:
> [..]
> > FWIW this thread is making me think my original patch which simply implemented
> > get_user_pages_fast_longterm() would be more clear. There is some evidence
> > that the GUP API was trending that way (see get_user_pages_remote). That seems
> > wrong but I don't know how to ensure users don't specify the wrong flag.
>
> What about just making the existing get_user_pages_longterm() have a
> fast path option?
That would work but was not the direction we agreed upon before.[1]
At this point I would rather see this patch set applied, focus on fixing the
filesystem issues, and once that is done determine if FOLL_LONGTERM is needed
in any GUP calls.
Ira
[1] https://lkml.org/lkml/2019/2/11/2038
WARNING: multiple messages have this Message-ID (diff)
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Andrew Morton <akpm@linux-foundation.org>,
John Hubbard <jhubbard@nvidia.com>,
Michal Hocko <mhocko@suse.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
"David S. Miller" <davem@davemloft.net>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mips@vger.kernel.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Linux-sh <linux-sh@vger.kernel.org>,
sparclinux@vger.kernel.org,
linux-rdma <linux-rdma@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RESEND 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast
Date: Mon, 25 Mar 2019 07:54:11 -0700 [thread overview]
Message-ID: <20190325145411.GI16366@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <CAPcyv4hG8WDhsWinXHYkReHKS6gdQ3gAHMcfVWvuP4c4SYBzXQ@mail.gmail.com>
On Mon, Mar 25, 2019 at 03:36:28PM -0700, Dan Williams wrote:
> On Mon, Mar 25, 2019 at 3:22 PM Ira Weiny <ira.weiny@intel.com> wrote:
> [..]
> > FWIW this thread is making me think my original patch which simply implemented
> > get_user_pages_fast_longterm() would be more clear. There is some evidence
> > that the GUP API was trending that way (see get_user_pages_remote). That seems
> > wrong but I don't know how to ensure users don't specify the wrong flag.
>
> What about just making the existing get_user_pages_longterm() have a
> fast path option?
That would work but was not the direction we agreed upon before.[1]
At this point I would rather see this patch set applied, focus on fixing the
filesystem issues, and once that is done determine if FOLL_LONGTERM is needed
in any GUP calls.
Ira
[1] https://lkml.org/lkml/2019/2/11/2038
WARNING: multiple messages have this Message-ID (diff)
From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Michal Hocko <mhocko@suse.com>,
Linux-sh <linux-sh@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
James Hogan <jhogan@kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-mips@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
Rich Felker <dalias@libc.org>, Paul Mackerras <paulus@samba.org>,
sparclinux@vger.kernel.org,
linux-s390 <linux-s390@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-rdma <linux-rdma@vger.kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Ingo Molnar <mingo@redhat.com>,
John Hubbard <jhubbard@nvidia.com>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
"David S. Miller" <davem@davemloft.net>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [RESEND 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast
Date: Mon, 25 Mar 2019 07:54:11 -0700 [thread overview]
Message-ID: <20190325145411.GI16366@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <CAPcyv4hG8WDhsWinXHYkReHKS6gdQ3gAHMcfVWvuP4c4SYBzXQ@mail.gmail.com>
On Mon, Mar 25, 2019 at 03:36:28PM -0700, Dan Williams wrote:
> On Mon, Mar 25, 2019 at 3:22 PM Ira Weiny <ira.weiny@intel.com> wrote:
> [..]
> > FWIW this thread is making me think my original patch which simply implemented
> > get_user_pages_fast_longterm() would be more clear. There is some evidence
> > that the GUP API was trending that way (see get_user_pages_remote). That seems
> > wrong but I don't know how to ensure users don't specify the wrong flag.
>
> What about just making the existing get_user_pages_longterm() have a
> fast path option?
That would work but was not the direction we agreed upon before.[1]
At this point I would rather see this patch set applied, focus on fixing the
filesystem issues, and once that is done determine if FOLL_LONGTERM is needed
in any GUP calls.
Ira
[1] https://lkml.org/lkml/2019/2/11/2038
next prev parent reply other threads:[~2019-03-25 14:54 UTC|newest]
Thread overview: 187+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 5:30 [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` [RESEND PATCH 1/7] mm/gup: Replace get_user_pages_longterm() with FOLL_LONGTERM ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` [RESEND PATCH 2/7] mm/gup: Change write parameter to flags in fast walk ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` [RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool' ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 19:29 ` Mike Marshall
2019-02-20 19:29 ` Mike Marshall
2019-02-20 19:29 ` Mike Marshall
2019-02-20 19:29 ` Mike Marshall
2019-02-20 19:29 ` Mike Marshall
2019-02-20 19:29 ` Mike Marshall
2019-02-21 3:18 ` Souptick Joarder
2019-02-21 3:18 ` Souptick Joarder
2019-02-21 3:30 ` Souptick Joarder
2019-02-21 3:18 ` Souptick Joarder
2019-02-21 3:18 ` Souptick Joarder
2019-02-21 3:18 ` Souptick Joarder
2019-02-21 22:24 ` Ira Weiny
2019-02-21 22:24 ` Ira Weiny
2019-02-21 22:24 ` Ira Weiny
2019-02-21 22:24 ` Ira Weiny
2019-02-21 22:24 ` Ira Weiny
2019-02-20 5:30 ` [RESEND PATCH 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` [RESEND PATCH 5/7] IB/hfi1: Use the new FOLL_LONGTERM flag to get_user_pages_fast() ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` [RESEND PATCH 6/7] IB/qib: " ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` [RESEND PATCH 7/7] IB/mthca: " ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 5:30 ` ira.weiny
2019-02-20 15:19 ` [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it Christoph Hellwig
2019-02-20 15:19 ` Christoph Hellwig
2019-02-20 15:19 ` Christoph Hellwig
2019-02-20 15:19 ` Christoph Hellwig
2019-02-20 18:02 ` Ira Weiny
2019-02-20 18:02 ` Ira Weiny
2019-02-20 18:02 ` Ira Weiny
2019-02-20 18:02 ` Ira Weiny
2019-02-20 18:02 ` Ira Weiny
2019-02-20 15:19 ` Christoph Hellwig
2019-02-20 15:19 ` Christoph Hellwig
2019-02-27 19:14 ` Ira Weiny
2019-02-27 19:14 ` Ira Weiny
2019-02-27 19:14 ` Ira Weiny
2019-02-27 19:14 ` Ira Weiny
2019-02-27 19:14 ` Ira Weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` [RESEND 1/7] mm/gup: Replace get_user_pages_longterm() with FOLL_LONGTERM ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-22 21:24 ` Dan Williams
2019-03-22 21:24 ` Dan Williams
2019-03-22 21:24 ` Dan Williams
2019-03-22 21:24 ` Dan Williams
2019-03-22 21:24 ` Dan Williams
2019-03-25 6:19 ` Ira Weiny
2019-03-25 6:19 ` Ira Weiny
2019-03-25 6:19 ` Ira Weiny
2019-03-25 6:19 ` Ira Weiny
2019-03-25 16:45 ` Dan Williams
2019-03-25 16:45 ` Dan Williams
2019-03-25 16:45 ` Dan Williams
2019-03-25 16:45 ` Dan Williams
2019-03-25 16:45 ` Dan Williams
2019-03-25 8:46 ` Ira Weiny
2019-03-25 8:46 ` Ira Weiny
2019-03-25 8:46 ` Ira Weiny
2019-03-25 8:46 ` Ira Weiny
2019-03-25 10:27 ` Ira Weiny
2019-03-25 10:27 ` Ira Weiny
2019-03-25 10:27 ` Ira Weiny
2019-03-25 10:27 ` Ira Weiny
2019-03-17 18:34 ` [RESEND 2/7] mm/gup: Change write parameter to flags in fast walk ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-22 21:30 ` Dan Williams
2019-03-22 21:30 ` Dan Williams
2019-03-22 21:30 ` Dan Williams
2019-03-22 21:30 ` Dan Williams
2019-03-22 21:30 ` Dan Williams
2019-03-17 18:34 ` [RESEND 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool' ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-22 22:05 ` Dan Williams
2019-03-22 22:05 ` Dan Williams
2019-03-22 22:05 ` Dan Williams
2019-03-22 22:05 ` Dan Williams
2019-03-22 22:05 ` Dan Williams
2019-03-25 8:26 ` Ira Weiny
2019-03-25 8:26 ` Ira Weiny
2019-03-25 8:26 ` Ira Weiny
2019-03-25 8:26 ` Ira Weiny
2019-03-17 18:34 ` [RESEND 4/7] mm/gup: Add FOLL_LONGTERM capability to GUP fast ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-22 22:12 ` Dan Williams
2019-03-22 22:12 ` Dan Williams
2019-03-22 22:12 ` Dan Williams
2019-03-22 22:12 ` Dan Williams
2019-03-22 22:12 ` Dan Williams
2019-03-25 8:42 ` Ira Weiny
2019-03-25 8:42 ` Ira Weiny
2019-03-25 8:42 ` Ira Weiny
2019-03-25 8:42 ` Ira Weiny
2019-03-25 16:47 ` Jason Gunthorpe
2019-03-25 16:47 ` Jason Gunthorpe
2019-03-25 16:47 ` Jason Gunthorpe
2019-03-25 16:47 ` Jason Gunthorpe
2019-03-25 9:23 ` Ira Weiny
2019-03-25 9:23 ` Ira Weiny
2019-03-25 9:23 ` Ira Weiny
2019-03-25 9:23 ` Ira Weiny
2019-03-25 17:51 ` Jason Gunthorpe
2019-03-25 17:51 ` Jason Gunthorpe
2019-03-25 17:51 ` Jason Gunthorpe
2019-03-25 17:51 ` Jason Gunthorpe
2019-03-25 14:21 ` Ira Weiny
2019-03-25 14:21 ` Ira Weiny
2019-03-25 14:21 ` Ira Weiny
2019-03-25 14:21 ` Ira Weiny
2019-03-25 22:36 ` Dan Williams
2019-03-25 22:36 ` Dan Williams
2019-03-25 22:36 ` Dan Williams
2019-03-25 22:36 ` Dan Williams
2019-03-25 22:36 ` Dan Williams
2019-03-25 14:54 ` Ira Weiny [this message]
2019-03-25 14:54 ` Ira Weiny
2019-03-25 14:54 ` Ira Weiny
2019-03-25 14:54 ` Ira Weiny
2019-03-17 18:34 ` [RESEND 5/7] IB/hfi1: Use the new FOLL_LONGTERM flag to get_user_pages_fast() ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-22 22:14 ` Dan Williams
2019-03-22 22:14 ` Dan Williams
2019-03-22 22:14 ` Dan Williams
2019-03-22 22:14 ` Dan Williams
2019-03-22 22:14 ` Dan Williams
2019-03-25 8:43 ` Ira Weiny
2019-03-25 8:43 ` Ira Weiny
2019-03-25 8:43 ` Ira Weiny
2019-03-25 8:43 ` Ira Weiny
2019-03-17 18:34 ` [RESEND 6/7] IB/qib: " ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-22 22:15 ` Dan Williams
2019-03-22 22:15 ` Dan Williams
2019-03-22 22:15 ` Dan Williams
2019-03-22 22:15 ` Dan Williams
2019-03-22 22:15 ` Dan Williams
2019-03-17 18:34 ` [RESEND 7/7] IB/mthca: " ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-17 18:34 ` ira.weiny
2019-03-19 22:19 ` [RESEND PATCH 0/7] Add FOLL_LONGTERM to GUP fast and use it Andrew Morton
2019-03-19 22:19 ` Andrew Morton
2019-03-19 22:19 ` Andrew Morton
2019-03-19 22:19 ` Andrew Morton
2019-03-21 8:40 ` Ira Weiny
2019-03-21 8:40 ` Ira Weiny
2019-03-21 8:40 ` Ira Weiny
2019-03-21 8:40 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325145411.GI16366@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=dalias@libc.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=heiko.carstens@de.ibm.com \
--cc=jgg@ziepe.ca \
--cc=jhogan@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
--cc=schwidefsky@de.ibm.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.