From: "Tobin C. Harding" <tobin@kernel.org>
To: Shuah Khan <shuah@kernel.org>
Cc: "Tobin C. Harding" <tobin@kernel.org>,
Kees Cook <keescook@chromium.org>, Jann Horn <jannh@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Randy Dunlap <rdunlap@infradead.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andy Lutomirski <luto@amacapital.net>,
Daniel Micay <danielmicay@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
kernel-hardening@lists.openwall.com,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 1/6] lib/test_printf: Add empty module_exit function
Date: Fri, 5 Apr 2019 12:58:54 +1100 [thread overview]
Message-ID: <20190405015859.32755-2-tobin@kernel.org> (raw)
In-Reply-To: <20190405015859.32755-1-tobin@kernel.org>
Currently the test_printf module does not have an exit function, this
prevents the module from being unloaded. If we cannot unload the
module we cannot run the tests a second time.
Add an empty exit function.
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Tobin C. Harding <tobin@kernel.org>
---
lib/test_printf.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/test_printf.c b/lib/test_printf.c
index 659b6cc0d483..601e8519319a 100644
--- a/lib/test_printf.c
+++ b/lib/test_printf.c
@@ -615,5 +615,11 @@ test_printf_init(void)
module_init(test_printf_init);
+static void __exit test_printf_exit(void)
+{
+}
+
+module_exit(test_printf_exit);
+
MODULE_AUTHOR("Rasmus Villemoes <linux@rasmusvillemoes.dk>");
MODULE_LICENSE("GPL");
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: tobin at kernel.org (Tobin C. Harding)
Subject: [PATCH v4 1/6] lib/test_printf: Add empty module_exit function
Date: Fri, 5 Apr 2019 12:58:54 +1100 [thread overview]
Message-ID: <20190405015859.32755-2-tobin@kernel.org> (raw)
In-Reply-To: <20190405015859.32755-1-tobin@kernel.org>
Currently the test_printf module does not have an exit function, this
prevents the module from being unloaded. If we cannot unload the
module we cannot run the tests a second time.
Add an empty exit function.
Acked-by: Kees Cook <keescook at chromium.org>
Signed-off-by: Tobin C. Harding <tobin at kernel.org>
---
lib/test_printf.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/test_printf.c b/lib/test_printf.c
index 659b6cc0d483..601e8519319a 100644
--- a/lib/test_printf.c
+++ b/lib/test_printf.c
@@ -615,5 +615,11 @@ test_printf_init(void)
module_init(test_printf_init);
+static void __exit test_printf_exit(void)
+{
+}
+
+module_exit(test_printf_exit);
+
MODULE_AUTHOR("Rasmus Villemoes <linux at rasmusvillemoes.dk>");
MODULE_LICENSE("GPL");
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: tobin@kernel.org (Tobin C. Harding)
Subject: [PATCH v4 1/6] lib/test_printf: Add empty module_exit function
Date: Fri, 5 Apr 2019 12:58:54 +1100 [thread overview]
Message-ID: <20190405015859.32755-2-tobin@kernel.org> (raw)
Message-ID: <20190405015854.yaLNCobVDc6ATJQqkZ2vHfRBPE7-xIsE5VWC8eumukA@z> (raw)
In-Reply-To: <20190405015859.32755-1-tobin@kernel.org>
Currently the test_printf module does not have an exit function, this
prevents the module from being unloaded. If we cannot unload the
module we cannot run the tests a second time.
Add an empty exit function.
Acked-by: Kees Cook <keescook at chromium.org>
Signed-off-by: Tobin C. Harding <tobin at kernel.org>
---
lib/test_printf.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/lib/test_printf.c b/lib/test_printf.c
index 659b6cc0d483..601e8519319a 100644
--- a/lib/test_printf.c
+++ b/lib/test_printf.c
@@ -615,5 +615,11 @@ test_printf_init(void)
module_init(test_printf_init);
+static void __exit test_printf_exit(void)
+{
+}
+
+module_exit(test_printf_exit);
+
MODULE_AUTHOR("Rasmus Villemoes <linux at rasmusvillemoes.dk>");
MODULE_LICENSE("GPL");
--
2.21.0
next prev parent reply other threads:[~2019-04-05 2:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 1:58 [PATCH v4 0/6] lib/string: Add strscpy_pad() function Tobin C. Harding
2019-04-05 1:58 ` Tobin C. Harding
2019-04-05 1:58 ` Tobin C. Harding
2019-04-05 1:58 ` tobin
2019-04-05 1:58 ` Tobin C. Harding [this message]
2019-04-05 1:58 ` [PATCH v4 1/6] lib/test_printf: Add empty module_exit function Tobin C. Harding
2019-04-05 1:58 ` tobin
2019-04-05 1:58 ` [PATCH v4 2/6] kselftest: Add test runner creation script Tobin C. Harding
2019-04-05 1:58 ` Tobin C. Harding
2019-04-05 1:58 ` tobin
2019-10-30 12:45 ` Naresh Kamboju
2019-10-30 12:45 ` Naresh Kamboju
2019-10-30 19:16 ` Kees Cook
2019-10-30 19:16 ` Kees Cook
2019-04-05 1:58 ` [PATCH v4 3/6] kselftest: Add test module framework header Tobin C. Harding
2019-04-05 1:58 ` Tobin C. Harding
2019-04-05 1:58 ` tobin
2019-04-05 1:58 ` [PATCH v4 4/6] lib: Use new kselftest header Tobin C. Harding
2019-04-05 1:58 ` Tobin C. Harding
2019-04-05 1:58 ` tobin
2019-04-05 1:58 ` [PATCH v4 5/6] lib/string: Add strscpy_pad() function Tobin C. Harding
2019-04-05 1:58 ` Tobin C. Harding
2019-04-05 1:58 ` tobin
2019-04-05 1:58 ` [PATCH v4 6/6] lib: Add test module for strscpy_pad Tobin C. Harding
2019-04-05 1:58 ` Tobin C. Harding
2019-04-05 1:58 ` tobin
2019-04-07 21:45 ` [PATCH v4 0/6] lib/string: Add strscpy_pad() function Tobin C. Harding
2019-04-07 21:45 ` Tobin C. Harding
2019-04-07 21:45 ` me
2019-04-08 14:08 ` shuah
2019-04-08 14:08 ` shuah
2019-04-08 14:08 ` shuah
2019-04-08 14:08 ` shuah
2019-04-08 14:59 ` Kees Cook
2019-04-08 14:59 ` Kees Cook
2019-04-08 14:59 ` Kees Cook
2019-04-08 14:59 ` keescook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405015859.32755-2-tobin@kernel.org \
--to=tobin@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=danielmicay@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.