From: Andre Przywara <andre.przywara@arm.com> To: Julien Thierry <julien.thierry@arm.com> Cc: <kvmarm@lists.cs.columbia.edu>, <kvm@vger.kernel.org>, <will.deacon@arm.com>, <Sami.Mujawar@arm.com> Subject: Re: [PATCH kvmtool 08/16] arm/pci: Do not use first PCI IO space bytes for devices Date: Fri, 5 Apr 2019 16:31:27 +0100 [thread overview] Message-ID: <20190405163127.4b10a581@donnerap.cambridge.arm.com> (raw) In-Reply-To: <1551947777-13044-9-git-send-email-julien.thierry@arm.com> On Thu, 7 Mar 2019 08:36:09 +0000 Julien Thierry <julien.thierry@arm.com> wrote: Hi, > Linux has this convention that the lower 0x1000 bytes of the IO space > should not be used. (cf PCIBIOS_MIN_IO). > > Just allocate those bytes to prevent future allocation assigning it to > devices. > > Signed-off-by: Julien Thierry <julien.thierry@arm.com> > --- > arm/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arm/pci.c b/arm/pci.c > index 83238ca..559e0cf 100644 > --- a/arm/pci.c > +++ b/arm/pci.c > @@ -37,6 +37,9 @@ void pci__arm_init(struct kvm *kvm) > > /* Make PCI port allocation start at a properly aligned address */ > pci_get_io_space_block(align_pad); > + > + /* Convention, don't allocate first 0x1000 bytes of PCI IO */ > + pci_get_io_space_block(0x1000); Is this the same problem with mixing up I/O and MMIO space as in the other patch? io_space means MMIO, right? Cheers, Andre. > } > > void pci__generate_fdt_nodes(void *fdt)
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: Julien Thierry <julien.thierry@arm.com> Cc: Sami.Mujawar@arm.com, will.deacon@arm.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org Subject: Re: [PATCH kvmtool 08/16] arm/pci: Do not use first PCI IO space bytes for devices Date: Fri, 5 Apr 2019 16:31:27 +0100 [thread overview] Message-ID: <20190405163127.4b10a581@donnerap.cambridge.arm.com> (raw) In-Reply-To: <1551947777-13044-9-git-send-email-julien.thierry@arm.com> On Thu, 7 Mar 2019 08:36:09 +0000 Julien Thierry <julien.thierry@arm.com> wrote: Hi, > Linux has this convention that the lower 0x1000 bytes of the IO space > should not be used. (cf PCIBIOS_MIN_IO). > > Just allocate those bytes to prevent future allocation assigning it to > devices. > > Signed-off-by: Julien Thierry <julien.thierry@arm.com> > --- > arm/pci.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arm/pci.c b/arm/pci.c > index 83238ca..559e0cf 100644 > --- a/arm/pci.c > +++ b/arm/pci.c > @@ -37,6 +37,9 @@ void pci__arm_init(struct kvm *kvm) > > /* Make PCI port allocation start at a properly aligned address */ > pci_get_io_space_block(align_pad); > + > + /* Convention, don't allocate first 0x1000 bytes of PCI IO */ > + pci_get_io_space_block(0x1000); Is this the same problem with mixing up I/O and MMIO space as in the other patch? io_space means MMIO, right? Cheers, Andre. > } > > void pci__generate_fdt_nodes(void *fdt)
next prev parent reply other threads:[~2019-04-05 15:31 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-07 8:36 [PATCH kvmtool 00/16] Support PCI BAR configuration Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 01/16] Makefile: Only compile vesa for archs that need it Julien Thierry 2019-04-04 13:43 ` Andre Przywara 2019-03-07 8:36 ` [PATCH kvmtool 02/16] brlock: Always pass argument to br_read_lock/unlock Julien Thierry 2019-04-04 13:43 ` Andre Przywara 2019-03-07 8:36 ` [PATCH kvmtool 03/16] brlock: fix build with KVM_BRLOCK_DEBUG Julien Thierry 2019-04-04 13:43 ` Andre Przywara 2019-03-07 8:36 ` [PATCH kvmtool 04/16] pci: Fix BAR resource sizing arbitration Julien Thierry 2019-04-04 13:44 ` Andre Przywara 2019-04-04 13:44 ` Andre Przywara 2019-03-07 8:36 ` [PATCH kvmtool 05/16] ioport: pci: Move port allocations to PCI devices Julien Thierry 2019-04-04 13:45 ` Andre Przywara 2019-04-30 9:50 ` Julien Thierry 2019-04-30 9:50 ` Julien Thierry 2019-04-30 9:50 ` Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 06/16] pci: Fix ioport allocation size Julien Thierry 2019-04-04 13:46 ` Andre Przywara 2019-03-07 8:36 ` [PATCH kvmtool 07/16] arm/pci: Fix PCI IO region Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 08/16] arm/pci: Do not use first PCI IO space bytes for devices Julien Thierry 2019-04-05 15:31 ` Andre Przywara [this message] 2019-04-05 15:31 ` Andre Przywara 2019-06-14 8:32 ` Julien Thierry 2019-06-14 8:32 ` Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 09/16] brlock: Use rwlock instead of pause Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 10/16] ref_cnt: Add simple ref counting API Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 11/16] mmio: Allow mmio callbacks to be called without locking Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 12/16] ioport: Allow ioport " Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 13/16] vfio: Add support for BAR configuration Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 14/16] virtio/pci: Make memory and IO BARs independent Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 15/16] virtio/pci: update virtio mapping when PCI BARs are reconfigured Julien Thierry 2019-03-07 8:36 ` [PATCH kvmtool 16/16] arm/fdt: Remove PCI probe only property Julien Thierry 2019-04-26 14:09 ` [PATCH kvmtool 00/16] Support PCI BAR configuration Will Deacon 2019-04-26 14:09 ` Will Deacon 2019-04-26 14:09 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190405163127.4b10a581@donnerap.cambridge.arm.com \ --to=andre.przywara@arm.com \ --cc=Sami.Mujawar@arm.com \ --cc=julien.thierry@arm.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.