From: Nicolin Chen <nicoleotsuka@gmail.com>
To: "S.j. Wang" <shengjiu.wang@nxp.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"timur@kernel.org" <timur@kernel.org>,
"Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [EXT] Re: [PATCH] ASoC: fsl_asrc: replace the process_option table with function
Date: Wed, 10 Apr 2019 10:54:24 -0700 [thread overview]
Message-ID: <20190410175424.GB24002@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <VE1PR04MB6479A2AA38FB6A27E120A441E32E0@VE1PR04MB6479.eurprd04.prod.outlook.com>
On Wed, Apr 10, 2019 at 10:34:05AM +0000, S.j. Wang wrote:
> > On Wed, Apr 10, 2019 at 08:26:59AM +0000, S.j. Wang wrote:
> > > > Is it possible to update the table? It'd be way quicker to use
> > > > lookup table than real-time calculation all the time. I believe you
> > > > can simply calculate all the values out for 12KHz and 24KHz since
> > > > you have the function. If there are certain combinations of these
> > > > two not being supported, then we could mark it with a special value and
> > add an if-check to error out.
> > > >
> > >
> > > Yes, but I think the function should be more flexible, if someday we
> > > need to support Other sample rate, only need to update the list.
> >
> > Given the fact that the owner of the function cannot give more comments, I
> > feel the function wouldn't be very maintainable as none of us understands it
> > well. On the other hand, you'll need to update the supported I/O rate lists
> > anyway, so why not just update the table as well? The supported sample
> > rates from ALSA are limited too. Overall, I think that continue using a lookup
> > table wins.
>
> Alsa support SNDRV_PCM_RATE_KNOT, we can define the rate that we want
> To support, and use function is more flexible, and we have use the function
> Internally for long time, it is stable😊
OK. I will try to indulge it. Let's see your next version first.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: "S.j. Wang" <shengjiu.wang@nxp.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"timur@kernel.org" <timur@kernel.org>,
"Xiubo.Lee@gmail.com" <Xiubo.Lee@gmail.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [EXT] Re: [PATCH] ASoC: fsl_asrc: replace the process_option table with function
Date: Wed, 10 Apr 2019 10:54:24 -0700 [thread overview]
Message-ID: <20190410175424.GB24002@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <VE1PR04MB6479A2AA38FB6A27E120A441E32E0@VE1PR04MB6479.eurprd04.prod.outlook.com>
On Wed, Apr 10, 2019 at 10:34:05AM +0000, S.j. Wang wrote:
> > On Wed, Apr 10, 2019 at 08:26:59AM +0000, S.j. Wang wrote:
> > > > Is it possible to update the table? It'd be way quicker to use
> > > > lookup table than real-time calculation all the time. I believe you
> > > > can simply calculate all the values out for 12KHz and 24KHz since
> > > > you have the function. If there are certain combinations of these
> > > > two not being supported, then we could mark it with a special value and
> > add an if-check to error out.
> > > >
> > >
> > > Yes, but I think the function should be more flexible, if someday we
> > > need to support Other sample rate, only need to update the list.
> >
> > Given the fact that the owner of the function cannot give more comments, I
> > feel the function wouldn't be very maintainable as none of us understands it
> > well. On the other hand, you'll need to update the supported I/O rate lists
> > anyway, so why not just update the table as well? The supported sample
> > rates from ALSA are limited too. Overall, I think that continue using a lookup
> > table wins.
>
> Alsa support SNDRV_PCM_RATE_KNOT, we can define the rate that we want
> To support, and use function is more flexible, and we have use the function
> Internally for long time, it is stable😊
OK. I will try to indulge it. Let's see your next version first.
next prev parent reply other threads:[~2019-04-10 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 3:15 [PATCH] ASoC: fsl_asrc: replace the process_option table with function S.j. Wang
2019-04-10 4:26 ` Nicolin Chen
2019-04-10 7:22 ` [EXT] " S.j. Wang
2019-04-10 7:22 ` S.j. Wang
2019-04-10 8:00 ` Nicolin Chen
2019-04-10 8:26 ` S.j. Wang
2019-04-10 8:26 ` S.j. Wang
2019-04-10 9:51 ` Nicolin Chen
2019-04-10 10:34 ` S.j. Wang
2019-04-10 10:34 ` S.j. Wang
2019-04-10 17:54 ` Nicolin Chen [this message]
2019-04-10 17:54 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410175424.GB24002@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.