From: Andi Shyti <andi.shyti@intel.com> To: Chris Wilson <chris@chris-wilson.co.uk> Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org Subject: Re: [igt-dev] [RFT i-g-t 6/6] test: perf_pmu: use the gem_engine_topology library Date: Thu, 11 Apr 2019 16:01:01 +0300 [thread overview] Message-ID: <20190411130101.GA2333@intel.intel> (raw) In-Reply-To: <155498592365.22467.8220615834316531843@skylake-alporthouse-com> On Thu, Apr 11, 2019 at 01:32:03PM +0100, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-04-11 13:26:54) > > From: Andi Shyti <andi.shyti@intel.com> > > > > Replace the legacy for_each_engine* defines with the ones > > implemented in the gem_engine_topology library. > > > > Use whenever possible gem_engine_can_store_dword() that checks > > class instead of flags. > > > > Now the __for_each_engine_class_instance and > > for_each_engine_class_instance are unused, remove them. > > > > Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Signed-off-by: Andi Shyti <andi.shyti@intel.com> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > I see a lot of new gem_context_create(), but not gem_require_contexts(). gem_require_contexts() should go on top of engine_topology. I will add it there. Thanks, Andi > -Chris > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Andi Shyti <andi.shyti@intel.com> To: Chris Wilson <chris@chris-wilson.co.uk> Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org Subject: Re: [igt-dev] [Intel-gfx] [RFT i-g-t 6/6] test: perf_pmu: use the gem_engine_topology library Date: Thu, 11 Apr 2019 16:01:01 +0300 [thread overview] Message-ID: <20190411130101.GA2333@intel.intel> (raw) In-Reply-To: <155498592365.22467.8220615834316531843@skylake-alporthouse-com> On Thu, Apr 11, 2019 at 01:32:03PM +0100, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-04-11 13:26:54) > > From: Andi Shyti <andi.shyti@intel.com> > > > > Replace the legacy for_each_engine* defines with the ones > > implemented in the gem_engine_topology library. > > > > Use whenever possible gem_engine_can_store_dword() that checks > > class instead of flags. > > > > Now the __for_each_engine_class_instance and > > for_each_engine_class_instance are unused, remove them. > > > > Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > Signed-off-by: Andi Shyti <andi.shyti@intel.com> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> > > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> > > I see a lot of new gem_context_create(), but not gem_require_contexts(). gem_require_contexts() should go on top of engine_topology. I will add it there. Thanks, Andi > -Chris > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-11 13:01 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-08 16:15 [igt-dev] [PATCH v19 0/6] new engine discovery interface Andi Shyti 2019-04-08 16:15 ` [igt-dev] [PATCH v19 1/6] include/drm-uapi: import i915_drm.h header file Andi Shyti 2019-04-08 16:37 ` Tvrtko Ursulin 2019-04-08 16:47 ` Andi Shyti 2019-04-08 16:56 ` Tvrtko Ursulin 2019-04-08 18:33 ` Antonio Argenziano 2019-04-09 7:33 ` Tvrtko Ursulin 2019-04-08 16:15 ` [igt-dev] [PATCH v19 2/6] lib/i915: add gem_engine_topology library and for_each loop definition Andi Shyti 2019-04-08 16:54 ` Tvrtko Ursulin 2019-04-08 18:21 ` Andi Shyti 2019-04-11 16:03 ` Tvrtko Ursulin 2019-04-11 23:23 ` Andi Shyti 2019-04-08 16:15 ` [igt-dev] [PATCH v19 3/6] lib: igt_gt: add eb flags to class helper Andi Shyti 2019-04-08 16:24 ` Tvrtko Ursulin 2019-04-08 16:15 ` [igt-dev] [PATCH v19 4/6] lib: igt_gt: make gem_engine_can_store_dword() check engine class Andi Shyti 2019-04-08 16:25 ` Tvrtko Ursulin 2019-04-08 16:15 ` [igt-dev] [PATCH v19 5/6] lib: igt_dummyload: use for_each_context_engine() Andi Shyti 2019-04-08 16:28 ` Tvrtko Ursulin 2019-04-08 16:45 ` Andi Shyti 2019-04-11 12:26 ` [RFT i-g-t 6/6] test: perf_pmu: use the gem_engine_topology library Tvrtko Ursulin 2019-04-11 12:26 ` [igt-dev] " Tvrtko Ursulin 2019-04-11 12:32 ` Chris Wilson 2019-04-11 12:32 ` [Intel-gfx] " Chris Wilson 2019-04-11 12:53 ` Tvrtko Ursulin 2019-04-11 12:53 ` Tvrtko Ursulin 2019-04-11 13:50 ` Chris Wilson 2019-04-11 13:50 ` Chris Wilson 2019-04-11 14:37 ` Tvrtko Ursulin 2019-04-11 14:37 ` Tvrtko Ursulin 2019-04-11 13:01 ` Andi Shyti [this message] 2019-04-11 13:01 ` [igt-dev] [Intel-gfx] " Andi Shyti 2019-04-11 13:40 ` [igt-dev] " Chris Wilson 2019-04-11 13:40 ` [igt-dev] [Intel-gfx] " Chris Wilson 2019-04-11 14:55 ` [igt-dev] " Andi Shyti 2019-04-11 14:55 ` [igt-dev] [Intel-gfx] " Andi Shyti 2019-04-11 12:28 ` [RFT i-g-t 5/6] lib: igt_dummyload: use for_each_context_engine() Tvrtko Ursulin 2019-04-11 12:28 ` [igt-dev] " Tvrtko Ursulin 2019-04-08 16:15 ` [igt-dev] [PATCH v19 6/6] test: perf_pmu: use the gem_engine_topology library Andi Shyti 2019-04-08 16:35 ` Tvrtko Ursulin 2019-04-08 16:56 ` Andi Shyti 2019-04-08 17:35 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface Patchwork 2019-04-11 14:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev3) Patchwork 2019-04-11 18:11 ` [igt-dev] ✗ Fi.CI.BAT: failure for new engine discovery interface (rev4) Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190411130101.GA2333@intel.intel \ --to=andi.shyti@intel.com \ --cc=Intel-gfx@lists.freedesktop.org \ --cc=chris@chris-wilson.co.uk \ --cc=igt-dev@lists.freedesktop.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.