From: Maxim Levitsky <mlevitsk@redhat.com> To: qemu-block@nongnu.org Cc: Maxim Levitsky <mlevitsk@redhat.com>, Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 1/5] block/nvme: don't flip CQ phase bits Date: Mon, 15 Apr 2019 16:57:42 +0300 [thread overview] Message-ID: <20190415135746.7571-2-mlevitsk@redhat.com> (raw) In-Reply-To: <20190415135746.7571-1-mlevitsk@redhat.com> Phase bits are only set by the hardware to indicate new completions and not by the device driver. Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com> --- block/nvme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 0684bbd077..2d208000df 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -340,8 +340,6 @@ static bool nvme_process_completion(BDRVNVMeState *s, NVMeQueuePair *q) qemu_mutex_lock(&q->lock); c->cid = cpu_to_le16(0); q->inflight--; - /* Flip Phase Tag bit. */ - c->status = cpu_to_le16(le16_to_cpu(c->status) ^ 0x1); progress = true; } if (progress) { -- 2.17.2
WARNING: multiple messages have this Message-ID (diff)
From: Maxim Levitsky <mlevitsk@redhat.com> To: qemu-block@nongnu.org Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org, Maxim Levitsky <mlevitsk@redhat.com> Subject: [Qemu-devel] [PATCH 1/5] block/nvme: don't flip CQ phase bits Date: Mon, 15 Apr 2019 16:57:42 +0300 [thread overview] Message-ID: <20190415135746.7571-2-mlevitsk@redhat.com> (raw) Message-ID: <20190415135742.qDLJ0l7ZIx1Q6jktUC5YflA4HCNhJE5Jtdlg3_OA-Xs@z> (raw) In-Reply-To: <20190415135746.7571-1-mlevitsk@redhat.com> Phase bits are only set by the hardware to indicate new completions and not by the device driver. Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com> --- block/nvme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index 0684bbd077..2d208000df 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -340,8 +340,6 @@ static bool nvme_process_completion(BDRVNVMeState *s, NVMeQueuePair *q) qemu_mutex_lock(&q->lock); c->cid = cpu_to_le16(0); q->inflight--; - /* Flip Phase Tag bit. */ - c->status = cpu_to_le16(le16_to_cpu(c->status) ^ 0x1); progress = true; } if (progress) { -- 2.17.2
next prev parent reply other threads:[~2019-04-15 13:58 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-15 13:57 [Qemu-devel] [PATCH 0/5] Few fixes for userspace NVME driver Maxim Levitsky 2019-04-15 13:57 ` Maxim Levitsky 2019-04-15 13:57 ` Maxim Levitsky [this message] 2019-04-15 13:57 ` [Qemu-devel] [PATCH 1/5] block/nvme: don't flip CQ phase bits Maxim Levitsky 2019-04-15 13:57 ` [Qemu-devel] [PATCH 2/5] block/nvme: fix doorbell stride Maxim Levitsky 2019-04-15 13:57 ` Maxim Levitsky 2019-04-15 13:57 ` [Qemu-devel] [PATCH 3/5] block/nvme: support larger that 512 bytes sector devices Maxim Levitsky 2019-04-15 13:57 ` Maxim Levitsky 2019-04-15 13:57 ` [Qemu-devel] [PATCH 4/5] block/nvme: add support for write zeros Maxim Levitsky 2019-04-15 13:57 ` Maxim Levitsky 2019-04-16 13:49 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini 2019-04-16 13:49 ` Paolo Bonzini 2019-04-15 13:57 ` [Qemu-devel] [PATCH 5/5] block/nvme: add support for discard Maxim Levitsky 2019-04-15 13:57 ` Maxim Levitsky 2019-04-16 13:50 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini 2019-04-16 13:50 ` Paolo Bonzini 2019-04-16 13:50 ` [Qemu-devel] [Qemu-block] [PATCH 0/5] Few fixes for userspace NVME driver Paolo Bonzini 2019-04-16 13:50 ` Paolo Bonzini 2019-04-17 19:57 ` Maxim Levitsky 2019-06-02 9:12 ` [Qemu-devel] " Maxim Levitsky
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190415135746.7571-2-mlevitsk@redhat.com \ --to=mlevitsk@redhat.com \ --cc=fam@euphon.net \ --cc=kwolf@redhat.com \ --cc=mreitz@redhat.com \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.