Re: [PATCH 06/12] i2c: omap: Add the master_xfer_irqless hook

From: Wolfram Sang <wsa@the-dreams.de>
To: Stefan Lengfeld <contact@stefanchrist.eu>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Peter Rosin <peda@axentia.se>,
	linux-omap@vger.kernel.org, linux-tegra@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Tero Kristo <t-kristo@ti.com>, Keerthy <j-keerthy@ti.com>,
	Simon Horman <horms+renesas@verge.net.au>
Subject: Re: [PATCH 06/12] i2c: omap: Add the master_xfer_irqless hook
Date: Tue, 16 Apr 2019 12:52:21 +0200	[thread overview]
Message-ID: <20190416105221.c7h4ktzzu4xmdht3@ninjato> (raw)
In-Reply-To: <20190415220546.bvrp7jodgdq7phwg@porty>

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

> the subject line of this patch
> 
>     i2c: omap: Add the master_xfer_irqless hook
> 
> still contains the old name of the callback '_irqless'. It should be
> '_atomic' instead.
> 
> 
> On Wed, Apr 03, 2019 at 02:40:13PM +0200, Wolfram Sang wrote:
> > Add the master_xfer_irqless hook to enable i2c transactions
> 
> Here again. It should be 'master_xfer_atomic'.

Yes, thanks, fixed!

> >  static int omap_i2c_xfer_msg(struct i2c_adapter *adap,
> > -			     struct i2c_msg *msg, int stop)
> > +			     struct i2c_msg *msg, int stop, bool polling)
> 
> Nitpick. In the patches for the other drivers the boolean flag is called
> 'atomic' and not 'polling'.

This patch originally is not from me, so I prefer to not change it.
Also, I don't want to enforce strict naming within drivers. As long as
it is readable, I am fine with it.

> >  static const struct i2c_algorithm omap_i2c_algo = {
> > -	.master_xfer	= omap_i2c_xfer,
> > +	.master_xfer	= omap_i2c_xfer_irq,
> > +	.master_xfer_atomic	= omap_i2c_xfer_polling,
> 
> When consistency with other drivers is a goal, the functions should be
> named like:
> 
>     .master_xfe = omap_i2c_xfer,
>     .master_xfer_atomic = omap_i2c_xfer_atomic,
> 
> The first without a suffix and the second with the '_atomic' suffix.

ditto.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]