From: Jacopo Mondi <jacopo@jmondi.org> To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Maxime Ripard <maxime.ripard@bootlin.com> Subject: Re: [PATCH 8/9] drm: rcar-du: Add support for missing 16-bit RGB4444 formats Date: Tue, 23 Apr 2019 16:06:49 +0200 [thread overview] Message-ID: <20190423140649.mv4twq5kayuigzd6@uno.localdomain> (raw) In-Reply-To: <20190328070723.26553-9-laurent.pinchart+renesas@ideasonboard.com> [-- Attachment #1: Type: text/plain, Size: 1815 bytes --] Hi Laurent, On Thu, Mar 28, 2019 at 09:07:22AM +0200, Laurent Pinchart wrote: > Add support for the DRM_FORMAT_RGBA4444, DRM_FORMAT_RGBX4444, > DRM_FORMAT_ABGR4444, DRM_FORMAT_XBGR4444, DRM_FORMAT_BGRA4444 and > DRM_FORMAT_BGRX4444 formats to the DU driver. Those formats are only > available on Gen3. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 30 +++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 4084136af845..4aaf623cbcd1 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -123,6 +123,36 @@ static const struct rcar_du_format_info rcar_du_format_infos[] = { > .v4l2 = V4L2_PIX_FMT_XRGB444, > .bpp = 16, > .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_RGBA4444, > + .v4l2 = V4L2_PIX_FMT_RGBA444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_RGBX4444, > + .v4l2 = V4L2_PIX_FMT_RGBX444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_ABGR4444, > + .v4l2 = V4L2_PIX_FMT_ABGR444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_XBGR4444, > + .v4l2 = V4L2_PIX_FMT_XBGR444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_BGRA4444, > + .v4l2 = V4L2_PIX_FMT_BGRA444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_BGRX4444, > + .v4l2 = V4L2_PIX_FMT_BGRX444, > + .bpp = 16, > + .planes = 1, Compared the DRM and V4L2 format definitions, they look sane to me! Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > }, { > .fourcc = DRM_FORMAT_BGR888, > .v4l2 = V4L2_PIX_FMT_RGB24, > -- > Regards, > > Laurent Pinchart > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Jacopo Mondi <jacopo@jmondi.org> To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Cc: linux-renesas-soc@vger.kernel.org, Maxime Ripard <maxime.ripard@bootlin.com>, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Subject: Re: [PATCH 8/9] drm: rcar-du: Add support for missing 16-bit RGB4444 formats Date: Tue, 23 Apr 2019 16:06:49 +0200 [thread overview] Message-ID: <20190423140649.mv4twq5kayuigzd6@uno.localdomain> (raw) In-Reply-To: <20190328070723.26553-9-laurent.pinchart+renesas@ideasonboard.com> [-- Attachment #1.1: Type: text/plain, Size: 1815 bytes --] Hi Laurent, On Thu, Mar 28, 2019 at 09:07:22AM +0200, Laurent Pinchart wrote: > Add support for the DRM_FORMAT_RGBA4444, DRM_FORMAT_RGBX4444, > DRM_FORMAT_ABGR4444, DRM_FORMAT_XBGR4444, DRM_FORMAT_BGRA4444 and > DRM_FORMAT_BGRX4444 formats to the DU driver. Those formats are only > available on Gen3. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 30 +++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > index 4084136af845..4aaf623cbcd1 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c > @@ -123,6 +123,36 @@ static const struct rcar_du_format_info rcar_du_format_infos[] = { > .v4l2 = V4L2_PIX_FMT_XRGB444, > .bpp = 16, > .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_RGBA4444, > + .v4l2 = V4L2_PIX_FMT_RGBA444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_RGBX4444, > + .v4l2 = V4L2_PIX_FMT_RGBX444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_ABGR4444, > + .v4l2 = V4L2_PIX_FMT_ABGR444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_XBGR4444, > + .v4l2 = V4L2_PIX_FMT_XBGR444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_BGRA4444, > + .v4l2 = V4L2_PIX_FMT_BGRA444, > + .bpp = 16, > + .planes = 1, > + }, { > + .fourcc = DRM_FORMAT_BGRX4444, > + .v4l2 = V4L2_PIX_FMT_BGRX444, > + .bpp = 16, > + .planes = 1, Compared the DRM and V4L2 format definitions, they look sane to me! Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > }, { > .fourcc = DRM_FORMAT_BGR888, > .v4l2 = V4L2_PIX_FMT_RGB24, > -- > Regards, > > Laurent Pinchart > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 159 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-04-23 14:05 UTC|newest] Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-28 7:07 [PATCH 0/9] R-Car DU: Add missing RGB pixel formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-03-28 7:07 ` [PATCH 1/9] v4l: Add definitions for missing 32-bit RGB formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-03-28 13:15 ` Jacopo Mondi 2019-03-28 13:15 ` Jacopo Mondi 2019-04-02 12:12 ` Laurent Pinchart 2019-04-02 12:12 ` Laurent Pinchart 2019-04-04 16:02 ` Jacopo Mondi 2019-04-04 16:02 ` Jacopo Mondi 2019-03-28 7:07 ` [PATCH 2/9] v4l: Add definitions for missing 16-bit RGB4444 formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-04-04 16:00 ` Jacopo Mondi 2019-04-04 16:00 ` Jacopo Mondi 2019-04-18 5:57 ` Laurent Pinchart 2019-04-18 5:57 ` Laurent Pinchart 2019-07-09 12:56 ` Hans Verkuil 2019-07-09 12:56 ` Hans Verkuil 2019-03-28 7:07 ` [PATCH 3/9] v4l: Add definitions for missing 16-bit RGB555 formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-04-04 15:57 ` Jacopo Mondi 2019-04-04 15:57 ` Jacopo Mondi 2019-04-18 6:25 ` Laurent Pinchart 2019-04-18 6:25 ` Laurent Pinchart 2019-04-18 6:27 ` [PATCH v1.1 " Laurent Pinchart 2019-04-18 6:27 ` Laurent Pinchart 2019-04-23 11:53 ` Jacopo Mondi 2019-04-23 11:53 ` Jacopo Mondi 2019-03-28 7:07 ` [PATCH 4/9] media: vsp1: Add support for missing 32-bit RGB formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-04-04 17:39 ` Jacopo Mondi 2019-04-04 17:39 ` Jacopo Mondi 2019-04-18 6:06 ` Laurent Pinchart 2019-04-18 6:06 ` Laurent Pinchart 2019-04-23 13:21 ` Jacopo Mondi 2019-04-23 13:21 ` Jacopo Mondi 2019-04-23 14:10 ` Laurent Pinchart 2019-04-23 14:10 ` Laurent Pinchart 2019-03-28 7:07 ` [PATCH 5/9] media: vsp1: Add support for missing 16-bit RGB444 formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-04-23 13:38 ` Jacopo Mondi 2019-04-23 13:38 ` Jacopo Mondi 2019-03-28 7:07 ` [PATCH 6/9] media: vsp1: Add support for missing 16-bit RGB555 formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-04-23 13:55 ` Jacopo Mondi 2019-04-23 13:55 ` Jacopo Mondi 2019-04-23 14:46 ` Laurent Pinchart 2019-04-23 14:46 ` Laurent Pinchart 2019-04-23 16:56 ` Jacopo Mondi 2019-04-23 16:56 ` Jacopo Mondi 2019-04-23 19:29 ` Laurent Pinchart 2019-04-23 19:29 ` Laurent Pinchart 2019-03-28 7:07 ` [PATCH 7/9] drm: rcar-du: Add support for missing 32-bit RGB formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-04-23 14:05 ` Jacopo Mondi 2019-04-23 14:05 ` Jacopo Mondi 2019-03-28 7:07 ` [PATCH 8/9] drm: rcar-du: Add support for missing 16-bit RGB4444 formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-04-23 14:06 ` Jacopo Mondi [this message] 2019-04-23 14:06 ` Jacopo Mondi 2019-03-28 7:07 ` [PATCH 9/9] drm: rcar-du: Add support for missing 16-bit RGB1555 formats Laurent Pinchart 2019-03-28 7:07 ` Laurent Pinchart 2019-04-23 14:09 ` Jacopo Mondi 2019-04-23 14:09 ` Jacopo Mondi 2019-04-20 13:09 ` [PATCH 0/9] R-Car DU: Add missing RGB pixel formats Laurent Pinchart 2019-04-20 13:09 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190423140649.mv4twq5kayuigzd6@uno.localdomain \ --to=jacopo@jmondi.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=maxime.ripard@bootlin.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.