From: Mark Brown <broonie@kernel.org> Cc: broonie@kernel.org, jorge.ramirez-ortiz@linaro.org, khasim.mohammed@linaro.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.orgMark Brown <broonie@kernel.org> Subject: Applied "regulator: core: do not report EPROBE_DEFER as error but as debug" to the regulator tree Date: Thu, 25 Apr 2019 20:26:35 +0100 (BST) [thread overview] Message-ID: <20190425192635.A0209441D3C@finisterre.ee.mobilebroadband> (raw) In-Reply-To: <20190417192443.6501-1-jorge.ramirez-ortiz@linaro.org> The patch regulator: core: do not report EPROBE_DEFER as error but as debug has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 4d0a83b904f4b2b9b814ad950472b50e7e803716 Mon Sep 17 00:00:00 2001 From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> Date: Wed, 17 Apr 2019 21:24:43 +0200 Subject: [PATCH] regulator: core: do not report EPROBE_DEFER as error but as debug Temporary failures to get a regulator (EPROBE_DEFER) should be logged as debug information instead of errors. Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/regulator/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 5a9ebcf7fe7a..08ccabe07fe3 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4345,8 +4345,6 @@ int regulator_bulk_get(struct device *dev, int num_consumers, consumers[i].supply); if (IS_ERR(consumers[i].consumer)) { ret = PTR_ERR(consumers[i].consumer); - dev_err(dev, "Failed to get supply '%s': %d\n", - consumers[i].supply, ret); consumers[i].consumer = NULL; goto err; } @@ -4355,6 +4353,13 @@ int regulator_bulk_get(struct device *dev, int num_consumers, return 0; err: + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get supply '%s': %d\n", + consumers[i].supply, ret); + else + dev_dbg(dev, "Failed to get supply '%s', deferring\n", + consumers[i].supply); + while (--i >= 0) regulator_put(consumers[i].consumer); -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org> To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> Cc: broonie@kernel.org, jorge.ramirez-ortiz@linaro.org, khasim.mohammed@linaro.org, lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org> Subject: Applied "regulator: core: do not report EPROBE_DEFER as error but as debug" to the regulator tree Date: Thu, 25 Apr 2019 20:26:35 +0100 (BST) [thread overview] Message-ID: <20190425192635.A0209441D3C@finisterre.ee.mobilebroadband> (raw) Message-ID: <20190425192635.WR23ZFlAYqTi69W3q7aBNtKQmPfD3lELZ1_-g38JhHQ@z> (raw) In-Reply-To: <20190417192443.6501-1-jorge.ramirez-ortiz@linaro.org> The patch regulator: core: do not report EPROBE_DEFER as error but as debug has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 4d0a83b904f4b2b9b814ad950472b50e7e803716 Mon Sep 17 00:00:00 2001 From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> Date: Wed, 17 Apr 2019 21:24:43 +0200 Subject: [PATCH] regulator: core: do not report EPROBE_DEFER as error but as debug Temporary failures to get a regulator (EPROBE_DEFER) should be logged as debug information instead of errors. Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/regulator/core.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 5a9ebcf7fe7a..08ccabe07fe3 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -4345,8 +4345,6 @@ int regulator_bulk_get(struct device *dev, int num_consumers, consumers[i].supply); if (IS_ERR(consumers[i].consumer)) { ret = PTR_ERR(consumers[i].consumer); - dev_err(dev, "Failed to get supply '%s': %d\n", - consumers[i].supply, ret); consumers[i].consumer = NULL; goto err; } @@ -4355,6 +4353,13 @@ int regulator_bulk_get(struct device *dev, int num_consumers, return 0; err: + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to get supply '%s': %d\n", + consumers[i].supply, ret); + else + dev_dbg(dev, "Failed to get supply '%s', deferring\n", + consumers[i].supply); + while (--i >= 0) regulator_put(consumers[i].consumer); -- 2.20.1
next prev parent reply other threads:[~2019-04-25 19:26 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-17 19:24 [PATCH v2] regulator: core: do not report EPROBE_DEFER as error but as debug Jorge Ramirez-Ortiz 2019-04-18 10:26 ` Applied "regulator: core: do not report EPROBE_DEFER as error but as debug" to the regulator tree Mark Brown 2019-04-18 10:26 ` Mark Brown 2019-04-23 9:49 ` Jorge Ramirez 2019-04-25 19:24 ` Mark Brown 2019-04-25 19:24 ` Mark Brown 2019-04-25 19:26 ` Mark Brown [this message] 2019-04-25 19:26 ` Mark Brown 2019-04-26 9:40 ` Mark Brown 2019-04-26 9:40 ` Mark Brown 2019-04-26 9:44 ` Mark Brown 2019-04-26 9:44 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190425192635.A0209441D3C@finisterre.ee.mobilebroadband \ --to=broonie@kernel.org \ --cc=jorge.ramirez-ortiz@linaro.org \ --cc=khasim.mohammed@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.orgMark \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.