From: Rob Herring <robh@kernel.org>
To: Stu Hsieh <stu.hsieh@mediatek.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
CK Hu <ck.hu@mediatek.com>, Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH v2 01/15] dt-bindings: media: Add binding for MT2712 MIPI-CSI2
Date: Mon, 29 Apr 2019 17:53:15 -0500 [thread overview]
Message-ID: <20190429225315.GA23589@bogus> (raw)
In-Reply-To: <1555407015-18130-2-git-send-email-stu.hsieh@mediatek.com>
On Tue, Apr 16, 2019 at 05:30:01PM +0800, Stu Hsieh wrote:
> Add MIPI-CSI2 dt-binding for Mediatek MT2712 SoC
>
> Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> ---
> .../bindings/media/mediatek-mipicsi-camsv.txt | 53 ++++++++++++++++++
> .../media/mediatek-mipicsi-common.txt | 19 +++++++
> .../bindings/media/mediatek-mipicsi.txt | 54 +++++++++++++++++++
> 3 files changed, 126 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> new file mode 100644
> index 000000000000..5f34974f12ac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> @@ -0,0 +1,53 @@
> +* Mediatek MIPI-CSI2 receiver camsv
> +
> +Mediatek MIPI-CSI2 receiver camsv transfer data to DRAM in Mediatek SoCs
> +
> +Required properties:
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
Looks like 2 regions in the example. What are they?
> +- clocks: device clocks, see
> + Documentation/devicetree/bindings/clock/clock-bindings.txt for details.
1 clock?
> +- interrupts : interrupt number to the interrupt controller.
> +
> +Example:
> + seninf1_mux_camsv0: seninf_mux_camsv@15002100 {
> + reg = <0 0x15002120 0 0x40>,
> + <0 0x15004000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV_EN>;
> + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf2_mux_camsv1: seninf_mux_camsv@15002500 {
> + reg = <0 0x15002520 0 0x40>,
> + <0 0x15005000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV_EN>;
> + interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf3_mux_camsv2: seninf_mux_camsv@15002900 {
> + reg = <0 0x15002920 0 0x40>,
> + <0 0x15006000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV1_EN>;
> + interrupts = <GIC_SPI 268 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf4_mux_camsv3: seninf_mux_camsv@15002D00 {
> + reg = <0 0x15002D20 0 0x40>,
> + <0 0x15007000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV1_EN>;
> + interrupts = <GIC_SPI 269 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf5_mux_camsv4: seninf_mux_camsv@15003100 {
> + reg = <0 0x15003120 0 0x40>,
> + <0 0x15008000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV2_EN>;
> + interrupts = <GIC_SPI 270 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf6_mux_camsv5: seninf_mux_camsv@15003500 {
> + reg = <0 0x15003520 0 0x40>,
> + <0 0x15009000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV2_EN>;
> + interrupts = <GIC_SPI 271 IRQ_TYPE_LEVEL_LOW>;
> +
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> new file mode 100644
> index 000000000000..a67c744b75f0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> @@ -0,0 +1,19 @@
> +* Mediatek MIPI-CSI2 receiver common
> +
> +Mediatek MIPI-CSI2 receiver is the MIPI Signal capture hardware present in Mediatek SoCs
> +
> +Required properties:
> +- compatible: should be "mediatek,mt2712-mipicsi-common"
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
> +- clocks: device clocks, see
> + Documentation/devicetree/bindings/clock/clock-bindings.txt for details.
How many clocks and what are they?
> +
> +
> +Example:
> + mipicsi: mipicsi@15002000 {
> + compatible = "mediatek,mt2712-mipicsi-common", "syscon";
> + reg = <0 0x15002000 0 0x10>;
> + clocks = <&imgsys CLK_IMG_SENINF_CAM_EN>,
> + <&imgsys CLK_IMG_SENINF_SCAM_EN>;
> + };
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
> new file mode 100644
> index 000000000000..24741ed62b25
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
> @@ -0,0 +1,54 @@
> +* Mediatek MIPI-CSI2 receiver
> +
> +Mediatek MIPI-CSI2 receiver is the MIPI Signal capture hardware present in Mediatek SoCs
> +
> +Required properties:
> +- compatible: should be "mediatek,mt2712-mipicsi"
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
How many regions?
> +- power-domains: a phandle to the power domain, see
> + Documentation/devicetree/bindings/power/power_domain.txt for details.
> +- mediatek,larb: must contain the local arbiters in the current Socs, see
> + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
> + for details.
> +- iommus: should point to the respective IOMMU block with master port as
> + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> + for details.
How many?
> +- mediatek,seninf_mux_camsv: seninf_mux_camsv the data go through of the mipicsi port
s/_/-/
How many entries?
> +- mediatek,mipicsiid: the id of the mipicsi port
What is this for? We generally don't do device indexes in DT.
> +- mediatek,mipicsi: the common component of the two mipicsi port
> +
> +Example:
> + mipicsi0: mipicsi@10217000 {
> + compatible = "mediatek,mt2712-mipicsi";
> + mediatek,mipicsi = <&mipicsi>;
> + iommus = <&iommu0 M4U_PORT_CAM_DMA0>,
> + <&iommu0 M4U_PORT_CAM_DMA1>;
> + mediatek,larb = <&larb2>;
> + power-domains = <&scpsys MT2712_POWER_DOMAIN_ISP>;
> +
> + mediatek,seninf_mux_camsv = <&seninf1_mux_camsv0
> + &seninf2_mux_camsv1
> + &seninf3_mux_camsv2
> + &seninf4_mux_camsv3>;
> + reg = <0 0x10217000 0 0x60>,
> + <0 0x15002100 0 0x4>,
> + <0 0x15002300 0 0x100>;
> + mediatek,mipicsiid = <0>;
> + status="disabled";
Don't show status in examples.
> + };
> +
> + mipicsi1: mipicsi@10218000 {
> + compatible = "mediatek,mt2712-mipicsi";
> + mediatek,mipicsi = <&mipicsi>;
> + iommus = <&iommu0 M4U_PORT_CAM_DMA2>;
> + mediatek,larb = <&larb2>;
> + power-domains = <&scpsys MT2712_POWER_DOMAIN_ISP>;
> + mediatek,seninf_mux_camsv = <&seninf5_mux_camsv4
> + &seninf6_mux_camsv5>;
> + reg = <0 0x10218000 0 0x60>,
> + <0 0x15002500 0 0x4>,
> + <0 0x15002700 0 0x100>;
> + mediatek,mipicsiid = <1>;
> + status="disabled";
> + };
> \ No newline at end of file
Fix this.
> --
> 2.18.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Stu Hsieh <stu.hsieh@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org, CK Hu <ck.hu@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 01/15] dt-bindings: media: Add binding for MT2712 MIPI-CSI2
Date: Mon, 29 Apr 2019 17:53:15 -0500 [thread overview]
Message-ID: <20190429225315.GA23589@bogus> (raw)
In-Reply-To: <1555407015-18130-2-git-send-email-stu.hsieh@mediatek.com>
On Tue, Apr 16, 2019 at 05:30:01PM +0800, Stu Hsieh wrote:
> Add MIPI-CSI2 dt-binding for Mediatek MT2712 SoC
>
> Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> ---
> .../bindings/media/mediatek-mipicsi-camsv.txt | 53 ++++++++++++++++++
> .../media/mediatek-mipicsi-common.txt | 19 +++++++
> .../bindings/media/mediatek-mipicsi.txt | 54 +++++++++++++++++++
> 3 files changed, 126 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> new file mode 100644
> index 000000000000..5f34974f12ac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> @@ -0,0 +1,53 @@
> +* Mediatek MIPI-CSI2 receiver camsv
> +
> +Mediatek MIPI-CSI2 receiver camsv transfer data to DRAM in Mediatek SoCs
> +
> +Required properties:
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
Looks like 2 regions in the example. What are they?
> +- clocks: device clocks, see
> + Documentation/devicetree/bindings/clock/clock-bindings.txt for details.
1 clock?
> +- interrupts : interrupt number to the interrupt controller.
> +
> +Example:
> + seninf1_mux_camsv0: seninf_mux_camsv@15002100 {
> + reg = <0 0x15002120 0 0x40>,
> + <0 0x15004000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV_EN>;
> + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf2_mux_camsv1: seninf_mux_camsv@15002500 {
> + reg = <0 0x15002520 0 0x40>,
> + <0 0x15005000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV_EN>;
> + interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf3_mux_camsv2: seninf_mux_camsv@15002900 {
> + reg = <0 0x15002920 0 0x40>,
> + <0 0x15006000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV1_EN>;
> + interrupts = <GIC_SPI 268 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf4_mux_camsv3: seninf_mux_camsv@15002D00 {
> + reg = <0 0x15002D20 0 0x40>,
> + <0 0x15007000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV1_EN>;
> + interrupts = <GIC_SPI 269 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf5_mux_camsv4: seninf_mux_camsv@15003100 {
> + reg = <0 0x15003120 0 0x40>,
> + <0 0x15008000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV2_EN>;
> + interrupts = <GIC_SPI 270 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf6_mux_camsv5: seninf_mux_camsv@15003500 {
> + reg = <0 0x15003520 0 0x40>,
> + <0 0x15009000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV2_EN>;
> + interrupts = <GIC_SPI 271 IRQ_TYPE_LEVEL_LOW>;
> +
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> new file mode 100644
> index 000000000000..a67c744b75f0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> @@ -0,0 +1,19 @@
> +* Mediatek MIPI-CSI2 receiver common
> +
> +Mediatek MIPI-CSI2 receiver is the MIPI Signal capture hardware present in Mediatek SoCs
> +
> +Required properties:
> +- compatible: should be "mediatek,mt2712-mipicsi-common"
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
> +- clocks: device clocks, see
> + Documentation/devicetree/bindings/clock/clock-bindings.txt for details.
How many clocks and what are they?
> +
> +
> +Example:
> + mipicsi: mipicsi@15002000 {
> + compatible = "mediatek,mt2712-mipicsi-common", "syscon";
> + reg = <0 0x15002000 0 0x10>;
> + clocks = <&imgsys CLK_IMG_SENINF_CAM_EN>,
> + <&imgsys CLK_IMG_SENINF_SCAM_EN>;
> + };
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
> new file mode 100644
> index 000000000000..24741ed62b25
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
> @@ -0,0 +1,54 @@
> +* Mediatek MIPI-CSI2 receiver
> +
> +Mediatek MIPI-CSI2 receiver is the MIPI Signal capture hardware present in Mediatek SoCs
> +
> +Required properties:
> +- compatible: should be "mediatek,mt2712-mipicsi"
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
How many regions?
> +- power-domains: a phandle to the power domain, see
> + Documentation/devicetree/bindings/power/power_domain.txt for details.
> +- mediatek,larb: must contain the local arbiters in the current Socs, see
> + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
> + for details.
> +- iommus: should point to the respective IOMMU block with master port as
> + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> + for details.
How many?
> +- mediatek,seninf_mux_camsv: seninf_mux_camsv the data go through of the mipicsi port
s/_/-/
How many entries?
> +- mediatek,mipicsiid: the id of the mipicsi port
What is this for? We generally don't do device indexes in DT.
> +- mediatek,mipicsi: the common component of the two mipicsi port
> +
> +Example:
> + mipicsi0: mipicsi@10217000 {
> + compatible = "mediatek,mt2712-mipicsi";
> + mediatek,mipicsi = <&mipicsi>;
> + iommus = <&iommu0 M4U_PORT_CAM_DMA0>,
> + <&iommu0 M4U_PORT_CAM_DMA1>;
> + mediatek,larb = <&larb2>;
> + power-domains = <&scpsys MT2712_POWER_DOMAIN_ISP>;
> +
> + mediatek,seninf_mux_camsv = <&seninf1_mux_camsv0
> + &seninf2_mux_camsv1
> + &seninf3_mux_camsv2
> + &seninf4_mux_camsv3>;
> + reg = <0 0x10217000 0 0x60>,
> + <0 0x15002100 0 0x4>,
> + <0 0x15002300 0 0x100>;
> + mediatek,mipicsiid = <0>;
> + status="disabled";
Don't show status in examples.
> + };
> +
> + mipicsi1: mipicsi@10218000 {
> + compatible = "mediatek,mt2712-mipicsi";
> + mediatek,mipicsi = <&mipicsi>;
> + iommus = <&iommu0 M4U_PORT_CAM_DMA2>;
> + mediatek,larb = <&larb2>;
> + power-domains = <&scpsys MT2712_POWER_DOMAIN_ISP>;
> + mediatek,seninf_mux_camsv = <&seninf5_mux_camsv4
> + &seninf6_mux_camsv5>;
> + reg = <0 0x10218000 0 0x60>,
> + <0 0x15002500 0 0x4>,
> + <0 0x15002700 0 0x100>;
> + mediatek,mipicsiid = <1>;
> + status="disabled";
> + };
> \ No newline at end of file
Fix this.
> --
> 2.18.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Stu Hsieh <stu.hsieh@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org, CK Hu <ck.hu@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2 01/15] dt-bindings: media: Add binding for MT2712 MIPI-CSI2
Date: Mon, 29 Apr 2019 17:53:15 -0500 [thread overview]
Message-ID: <20190429225315.GA23589@bogus> (raw)
In-Reply-To: <1555407015-18130-2-git-send-email-stu.hsieh@mediatek.com>
On Tue, Apr 16, 2019 at 05:30:01PM +0800, Stu Hsieh wrote:
> Add MIPI-CSI2 dt-binding for Mediatek MT2712 SoC
>
> Signed-off-by: Stu Hsieh <stu.hsieh@mediatek.com>
> ---
> .../bindings/media/mediatek-mipicsi-camsv.txt | 53 ++++++++++++++++++
> .../media/mediatek-mipicsi-common.txt | 19 +++++++
> .../bindings/media/mediatek-mipicsi.txt | 54 +++++++++++++++++++
> 3 files changed, 126 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> create mode 100644 Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> new file mode 100644
> index 000000000000..5f34974f12ac
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi-camsv.txt
> @@ -0,0 +1,53 @@
> +* Mediatek MIPI-CSI2 receiver camsv
> +
> +Mediatek MIPI-CSI2 receiver camsv transfer data to DRAM in Mediatek SoCs
> +
> +Required properties:
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
Looks like 2 regions in the example. What are they?
> +- clocks: device clocks, see
> + Documentation/devicetree/bindings/clock/clock-bindings.txt for details.
1 clock?
> +- interrupts : interrupt number to the interrupt controller.
> +
> +Example:
> + seninf1_mux_camsv0: seninf_mux_camsv@15002100 {
> + reg = <0 0x15002120 0 0x40>,
> + <0 0x15004000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV_EN>;
> + interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf2_mux_camsv1: seninf_mux_camsv@15002500 {
> + reg = <0 0x15002520 0 0x40>,
> + <0 0x15005000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV_EN>;
> + interrupts = <GIC_SPI 223 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf3_mux_camsv2: seninf_mux_camsv@15002900 {
> + reg = <0 0x15002920 0 0x40>,
> + <0 0x15006000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV1_EN>;
> + interrupts = <GIC_SPI 268 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf4_mux_camsv3: seninf_mux_camsv@15002D00 {
> + reg = <0 0x15002D20 0 0x40>,
> + <0 0x15007000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV1_EN>;
> + interrupts = <GIC_SPI 269 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf5_mux_camsv4: seninf_mux_camsv@15003100 {
> + reg = <0 0x15003120 0 0x40>,
> + <0 0x15008000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV2_EN>;
> + interrupts = <GIC_SPI 270 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
> + seninf6_mux_camsv5: seninf_mux_camsv@15003500 {
> + reg = <0 0x15003520 0 0x40>,
> + <0 0x15009000 0 0x1000>;
> + clocks = <&imgsys CLK_IMG_CAM_SV2_EN>;
> + interrupts = <GIC_SPI 271 IRQ_TYPE_LEVEL_LOW>;
> +
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> new file mode 100644
> index 000000000000..a67c744b75f0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi-common.txt
> @@ -0,0 +1,19 @@
> +* Mediatek MIPI-CSI2 receiver common
> +
> +Mediatek MIPI-CSI2 receiver is the MIPI Signal capture hardware present in Mediatek SoCs
> +
> +Required properties:
> +- compatible: should be "mediatek,mt2712-mipicsi-common"
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
> +- clocks: device clocks, see
> + Documentation/devicetree/bindings/clock/clock-bindings.txt for details.
How many clocks and what are they?
> +
> +
> +Example:
> + mipicsi: mipicsi@15002000 {
> + compatible = "mediatek,mt2712-mipicsi-common", "syscon";
> + reg = <0 0x15002000 0 0x10>;
> + clocks = <&imgsys CLK_IMG_SENINF_CAM_EN>,
> + <&imgsys CLK_IMG_SENINF_SCAM_EN>;
> + };
> diff --git a/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt b/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
> new file mode 100644
> index 000000000000..24741ed62b25
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek-mipicsi.txt
> @@ -0,0 +1,54 @@
> +* Mediatek MIPI-CSI2 receiver
> +
> +Mediatek MIPI-CSI2 receiver is the MIPI Signal capture hardware present in Mediatek SoCs
> +
> +Required properties:
> +- compatible: should be "mediatek,mt2712-mipicsi"
> +- reg : physical base address of the mipicsi receiver registers and length of
> + memory mapped region.
How many regions?
> +- power-domains: a phandle to the power domain, see
> + Documentation/devicetree/bindings/power/power_domain.txt for details.
> +- mediatek,larb: must contain the local arbiters in the current Socs, see
> + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt
> + for details.
> +- iommus: should point to the respective IOMMU block with master port as
> + argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt
> + for details.
How many?
> +- mediatek,seninf_mux_camsv: seninf_mux_camsv the data go through of the mipicsi port
s/_/-/
How many entries?
> +- mediatek,mipicsiid: the id of the mipicsi port
What is this for? We generally don't do device indexes in DT.
> +- mediatek,mipicsi: the common component of the two mipicsi port
> +
> +Example:
> + mipicsi0: mipicsi@10217000 {
> + compatible = "mediatek,mt2712-mipicsi";
> + mediatek,mipicsi = <&mipicsi>;
> + iommus = <&iommu0 M4U_PORT_CAM_DMA0>,
> + <&iommu0 M4U_PORT_CAM_DMA1>;
> + mediatek,larb = <&larb2>;
> + power-domains = <&scpsys MT2712_POWER_DOMAIN_ISP>;
> +
> + mediatek,seninf_mux_camsv = <&seninf1_mux_camsv0
> + &seninf2_mux_camsv1
> + &seninf3_mux_camsv2
> + &seninf4_mux_camsv3>;
> + reg = <0 0x10217000 0 0x60>,
> + <0 0x15002100 0 0x4>,
> + <0 0x15002300 0 0x100>;
> + mediatek,mipicsiid = <0>;
> + status="disabled";
Don't show status in examples.
> + };
> +
> + mipicsi1: mipicsi@10218000 {
> + compatible = "mediatek,mt2712-mipicsi";
> + mediatek,mipicsi = <&mipicsi>;
> + iommus = <&iommu0 M4U_PORT_CAM_DMA2>;
> + mediatek,larb = <&larb2>;
> + power-domains = <&scpsys MT2712_POWER_DOMAIN_ISP>;
> + mediatek,seninf_mux_camsv = <&seninf5_mux_camsv4
> + &seninf6_mux_camsv5>;
> + reg = <0 0x10218000 0 0x60>,
> + <0 0x15002500 0 0x4>,
> + <0 0x15002700 0 0x100>;
> + mediatek,mipicsiid = <1>;
> + status="disabled";
> + };
> \ No newline at end of file
Fix this.
> --
> 2.18.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-29 22:53 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 9:30 [PATCH v2 00/15] Add mediatek mipicsi driver for Mediatek SOC MT2712 Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 01/15] dt-bindings: media: Add binding for MT2712 MIPI-CSI2 Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-29 22:53 ` Rob Herring [this message]
2019-04-29 22:53 ` Rob Herring
2019-04-29 22:53 ` Rob Herring
2019-04-16 9:30 ` [PATCH v2 02/15] [media] mtk-mipicsi: add mediatek mipicsi driver for mt2712 Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-18 1:34 ` CK Hu
2019-04-18 1:34 ` CK Hu
2019-04-18 1:34 ` CK Hu
2019-04-19 5:28 ` Stu Hsieh
2019-04-19 5:28 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 03/15] [media] mtk-mipicsi: add pm function Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 04/15] [media] mtk-mipicsi: add color format support for mt2712 Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-18 1:39 ` CK Hu
2019-04-18 1:39 ` CK Hu
2019-04-18 1:39 ` CK Hu
2019-04-16 9:30 ` [PATCH v2 05/15] [media] mtk-mipicsi: get the w/h/bytepwerline for mtk_mipicsi Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-19 3:52 ` CK Hu
2019-04-19 3:52 ` CK Hu
2019-04-19 3:52 ` CK Hu
2019-04-16 9:30 ` [PATCH v2 06/15] [media] mtk-mipicsi: add function to support SerDes for link number Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 07/15] [media] mtk-mipicsi: add mipicsi reg setting for mt2712 Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 08/15] [media] mtk-mipicsi: enable/disable ana clk Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 09/15] [media] mtk-mipicsi: enable/disable cmos for mt2712 Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 10/15] [media] mtk-mipicsi: add ISR for writing the data to buffer Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 11/15] [media] mtk-mipicsi: set the output address in HW reg Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 12/15] [media] mtk-mipicsi: add function to get the format Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 13/15] [media] mtk-mipicsi: add the function for Get/Set PARM for application Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-05-13 9:24 ` Hans Verkuil
2019-05-13 9:24 ` Hans Verkuil
2019-04-16 9:30 ` [PATCH v2 14/15] [media] mtk-mipicsi: add debug message for mipicsi driver Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` [PATCH v2 15/15] [media] mtk-mipicsi: add debugfs " Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
2019-04-16 9:30 ` Stu Hsieh
-- strict thread matches above, loose matches on Subject: below --
2019-04-16 9:27 [PATCH v2 00/15] Add mediatek mipicsi driver for Mediatek SOC MT2712 Stu Hsieh
2019-04-16 9:27 ` [PATCH v2 01/15] dt-bindings: media: Add binding for MT2712 MIPI-CSI2 Stu Hsieh
2019-04-16 9:27 ` Stu Hsieh
2019-04-16 9:27 ` Stu Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190429225315.GA23589@bogus \
--to=robh@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=stu.hsieh@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.