From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Pablo Greco <pgreco@centosproject.org>
Cc: linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add GPIO pin-bank regulator supplies
Date: Thu, 2 May 2019 09:38:15 +0200 [thread overview]
Message-ID: <20190502073815.56ktbpiieviqr4ss@flea> (raw)
In-Reply-To: <1556040365-10913-3-git-send-email-pgreco@centosproject.org>
[-- Attachment #1: Type: text/plain, Size: 915 bytes --]
On Tue, Apr 23, 2019 at 02:25:59PM -0300, Pablo Greco wrote:
> The bananapi-m2-berry has the PMIC providing voltage to all the pin-bank
> supply rails from its various regulator outputs, tie them to the pio
> node.
>
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
> ---
> arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> index f05cabd..2cb2ce0 100644
> --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> @@ -123,6 +123,16 @@
> status = "okay";
> };
>
> +&pio {
> + pinctrl-names = "default";
A pinctrl-names property without any other one?
Looks good otherwise, thanks
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
To: Pablo Greco <pgreco-/kQrlZ55X3WoClj4AeEUq9i2O/JbrIOy@public.gmane.org>
Cc: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 2/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add GPIO pin-bank regulator supplies
Date: Thu, 2 May 2019 09:38:15 +0200 [thread overview]
Message-ID: <20190502073815.56ktbpiieviqr4ss@flea> (raw)
In-Reply-To: <1556040365-10913-3-git-send-email-pgreco-/kQrlZ55X3WoClj4AeEUq9i2O/JbrIOy@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
On Tue, Apr 23, 2019 at 02:25:59PM -0300, Pablo Greco wrote:
> The bananapi-m2-berry has the PMIC providing voltage to all the pin-bank
> supply rails from its various regulator outputs, tie them to the pio
> node.
>
> Signed-off-by: Pablo Greco <pgreco-/kQrlZ55X3WoClj4AeEUq9i2O/JbrIOy@public.gmane.org>
> ---
> arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> index f05cabd..2cb2ce0 100644
> --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> @@ -123,6 +123,16 @@
> status = "okay";
> };
>
> +&pio {
> + pinctrl-names = "default";
A pinctrl-names property without any other one?
Looks good otherwise, thanks
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Pablo Greco <pgreco@centosproject.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 2/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add GPIO pin-bank regulator supplies
Date: Thu, 2 May 2019 09:38:15 +0200 [thread overview]
Message-ID: <20190502073815.56ktbpiieviqr4ss@flea> (raw)
In-Reply-To: <1556040365-10913-3-git-send-email-pgreco@centosproject.org>
[-- Attachment #1.1: Type: text/plain, Size: 915 bytes --]
On Tue, Apr 23, 2019 at 02:25:59PM -0300, Pablo Greco wrote:
> The bananapi-m2-berry has the PMIC providing voltage to all the pin-bank
> supply rails from its various regulator outputs, tie them to the pio
> node.
>
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
> ---
> arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> index f05cabd..2cb2ce0 100644
> --- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> +++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
> @@ -123,6 +123,16 @@
> status = "okay";
> };
>
> +&pio {
> + pinctrl-names = "default";
A pinctrl-names property without any other one?
Looks good otherwise, thanks
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-02 7:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 17:25 [PATCH v5 0/7] ARM: dts: sun8i: v40 Rewrite BPi M2 Berry DTS based on BPi M2 Ultra Pablo Greco
2019-04-23 17:25 ` Pablo Greco
2019-04-23 17:25 ` [PATCH v5 1/7] ARM: dts: sun8i: r40: bananapi-m2-ultra: Add GPIO pin-bank regulator supplies Pablo Greco
2019-04-23 17:25 ` Pablo Greco
2019-04-23 17:25 ` Pablo Greco
2019-05-02 7:37 ` Maxime Ripard
2019-05-02 7:37 ` Maxime Ripard
2019-05-02 7:37 ` Maxime Ripard
2019-04-23 17:25 ` [PATCH v5 2/7] ARM: dts: sun8i: v40: bananapi-m2-berry: " Pablo Greco
2019-04-23 17:25 ` Pablo Greco
2019-05-02 7:38 ` Maxime Ripard [this message]
2019-05-02 7:38 ` Maxime Ripard
2019-05-02 7:38 ` Maxime Ripard
2019-05-02 10:24 ` [linux-sunxi] " Pablo Sebastián Greco
2019-05-02 10:24 ` Pablo Sebastián Greco
2019-05-02 10:24 ` Pablo Sebastián Greco
2019-04-23 17:26 ` [PATCH v5 3/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-05-02 7:39 ` Maxime Ripard
2019-05-02 7:39 ` Maxime Ripard
2019-05-02 7:39 ` Maxime Ripard
2019-05-02 10:25 ` [linux-sunxi] " Pablo Sebastián Greco
2019-05-02 10:25 ` Pablo Sebastián Greco
2019-04-23 17:26 ` [PATCH v5 4/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable HDMI output Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-04-23 17:26 ` [PATCH v5 5/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Enable AHCI Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-04-23 17:26 ` [PATCH v5 6/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix WiFi regulator definitions Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-04-23 17:26 ` [PATCH v5 7/7] ARM: dts: sun8i: v40: bananapi-m2-berry: Add Bluetooth device node Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-04-23 17:26 ` Pablo Greco
2019-05-02 7:41 ` Maxime Ripard
2019-05-02 7:41 ` Maxime Ripard
2019-05-02 7:41 ` Maxime Ripard
2019-05-02 8:20 ` [linux-sunxi] " Chen-Yu Tsai
2019-05-02 8:20 ` Chen-Yu Tsai
2019-05-02 8:20 ` Chen-Yu Tsai
2019-05-02 10:27 ` [linux-sunxi] " Pablo Sebastián Greco
2019-05-02 10:27 ` Pablo Sebastián Greco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502073815.56ktbpiieviqr4ss@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=pgreco@centosproject.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.