From: Cornelia Huck <cohuck@redhat.com> To: Michael Mueller <mimu@linux.ibm.com> Cc: "Michael S. Tsirkin" <mst@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Halil Pasic <pasic@linux.ibm.com>, kvm@vger.kernel.org, linux-s390@vger.kernel.org, Martin Schwidefsky <schwidefsky@de.ibm.com>, Sebastian Ott <sebott@linux.ibm.com>, virtualization@lists.linux-foundation.org, Christoph Hellwig <hch@infradead.org>, Thomas Huth <thuth@redhat.com>, Viktor Mihajlovski <mihajlov@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>, Janosch Frank <frankja@linux.ibm.com>, Claudio Imbrenda <imbrenda@linux.ibm.com>, Farhan Ali <alifm@linux.ibm.com>, Eric Farman <farman@linux.ibm.com> Subject: Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue Date: Mon, 13 May 2019 14:29:45 +0200 [thread overview] Message-ID: <20190513142945.27e5921f.cohuck@redhat.com> (raw) In-Reply-To: <f2e52c29-ed4e-cf49-0fbf-e3bac97124e9@linux.ibm.com> On Mon, 13 May 2019 14:27:35 +0200 Michael Mueller <mimu@linux.ibm.com> wrote: > On 13.05.19 11:52, Cornelia Huck wrote: > > On Sun, 12 May 2019 12:47:39 -0400 > > "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > >> On Fri, May 10, 2019 at 04:07:44PM +0200, Cornelia Huck wrote: > >>> On Tue, 7 May 2019 15:58:12 +0200 > >>> Christian Borntraeger <borntraeger@de.ibm.com> wrote: > >>> > >>>> On 05.05.19 13:15, Cornelia Huck wrote: > >>>>> On Sat, 4 May 2019 16:03:40 +0200 > >>>>> Halil Pasic <pasic@linux.ibm.com> wrote: > >>>>> > >>>>>> On Fri, 3 May 2019 16:04:48 -0400 > >>>>>> "Michael S. Tsirkin" <mst@redhat.com> wrote: > >>>>>> > >>>>>>> On Fri, May 03, 2019 at 11:17:24AM +0200, Cornelia Huck wrote: > >>>>>>>> On Fri, 26 Apr 2019 20:32:36 +0200 > >>>>>>>> Halil Pasic <pasic@linux.ibm.com> wrote: > >>>>>>>> > >>>>>>>>> The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") > >>>>>>>>> establishes a new way of allocating virtqueues (as a part of the effort > >>>>>>>>> that taught DMA to virtio rings). > >>>>>>>>> > >>>>>>>>> In the future we will want virtio-ccw to use the DMA API as well. > >>>>>>>>> > >>>>>>>>> Let us switch from the legacy method of allocating virtqueues to > >>>>>>>>> vring_create_virtqueue() as the first step into that direction. > >>>>>>>>> > >>>>>>>>> Signed-off-by: Halil Pasic <pasic@linux.ibm.com> > >>>>>>>>> --- > >>>>>>>>> drivers/s390/virtio/virtio_ccw.c | 30 +++++++++++------------------- > >>>>>>>>> 1 file changed, 11 insertions(+), 19 deletions(-) > >>>>>>>> > >>>>>>>> Reviewed-by: Cornelia Huck <cohuck@redhat.com> > >>>>>>>> > >>>>>>>> I'd vote for merging this patch right away for 5.2. > >>>>>>> > >>>>>>> So which tree is this going through? mine? > >>>>>>> > >>>>>> > >>>>>> Christian, what do you think? If the whole series is supposed to go in > >>>>>> in one go (which I hope it is), via Martin's tree could be the simplest > >>>>>> route IMHO. > >>>>> > >>>>> > >>>>> The first three patches are virtio(-ccw) only and the those are the ones > >>>>> that I think are ready to go. > >>>>> > >>>>> I'm not feeling comfortable going forward with the remainder as it > >>>>> stands now; waiting for some other folks to give feedback. (They are > >>>>> touching/interacting with code parts I'm not so familiar with, and lack > >>>>> of documentation, while not the developers' fault, does not make it > >>>>> easier.) > >>>>> > >>>>> Michael, would you like to pick up 1-3 for your tree directly? That > >>>>> looks like the easiest way. > >>>> > >>>> Agreed. Michael please pick 1-3. > >>>> We will continue to review 4- first and then see which tree is best. > >>> > >>> Michael, please let me know if you'll pick directly or whether I should > >>> post a series. > >>> > >>> [Given that the patches are from one virtio-ccw maintainer and reviewed > >>> by the other, picking directly would eliminate an unnecessary > >>> indirection :)] > >> > >> picked them > > > > Thanks! > > > > Connie, > > if I get you right here, you don't need a v2 for the > patches 1 through 3? Exactly, they are all queued in Michael's tree. > > Thanks, > Michael >
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cohuck@redhat.com> To: Michael Mueller <mimu@linux.ibm.com> Cc: Vasily Gorbik <gor@linux.ibm.com>, linux-s390@vger.kernel.org, Thomas Huth <thuth@redhat.com>, Claudio Imbrenda <imbrenda@linux.ibm.com>, Sebastian Ott <sebott@linux.ibm.com>, kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>, Farhan Ali <alifm@linux.ibm.com>, Eric Farman <farman@linux.ibm.com>, virtualization@lists.linux-foundation.org, Halil Pasic <pasic@linux.ibm.com>, Christoph Hellwig <hch@infradead.org>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Viktor Mihajlovski <mihajlov@linux.ibm.com>, Janosch Frank <frankja@linux.ibm.com> Subject: Re: [PATCH 01/10] virtio/s390: use vring_create_virtqueue Date: Mon, 13 May 2019 14:29:45 +0200 [thread overview] Message-ID: <20190513142945.27e5921f.cohuck@redhat.com> (raw) In-Reply-To: <f2e52c29-ed4e-cf49-0fbf-e3bac97124e9@linux.ibm.com> On Mon, 13 May 2019 14:27:35 +0200 Michael Mueller <mimu@linux.ibm.com> wrote: > On 13.05.19 11:52, Cornelia Huck wrote: > > On Sun, 12 May 2019 12:47:39 -0400 > > "Michael S. Tsirkin" <mst@redhat.com> wrote: > > > >> On Fri, May 10, 2019 at 04:07:44PM +0200, Cornelia Huck wrote: > >>> On Tue, 7 May 2019 15:58:12 +0200 > >>> Christian Borntraeger <borntraeger@de.ibm.com> wrote: > >>> > >>>> On 05.05.19 13:15, Cornelia Huck wrote: > >>>>> On Sat, 4 May 2019 16:03:40 +0200 > >>>>> Halil Pasic <pasic@linux.ibm.com> wrote: > >>>>> > >>>>>> On Fri, 3 May 2019 16:04:48 -0400 > >>>>>> "Michael S. Tsirkin" <mst@redhat.com> wrote: > >>>>>> > >>>>>>> On Fri, May 03, 2019 at 11:17:24AM +0200, Cornelia Huck wrote: > >>>>>>>> On Fri, 26 Apr 2019 20:32:36 +0200 > >>>>>>>> Halil Pasic <pasic@linux.ibm.com> wrote: > >>>>>>>> > >>>>>>>>> The commit 2a2d1382fe9d ("virtio: Add improved queue allocation API") > >>>>>>>>> establishes a new way of allocating virtqueues (as a part of the effort > >>>>>>>>> that taught DMA to virtio rings). > >>>>>>>>> > >>>>>>>>> In the future we will want virtio-ccw to use the DMA API as well. > >>>>>>>>> > >>>>>>>>> Let us switch from the legacy method of allocating virtqueues to > >>>>>>>>> vring_create_virtqueue() as the first step into that direction. > >>>>>>>>> > >>>>>>>>> Signed-off-by: Halil Pasic <pasic@linux.ibm.com> > >>>>>>>>> --- > >>>>>>>>> drivers/s390/virtio/virtio_ccw.c | 30 +++++++++++------------------- > >>>>>>>>> 1 file changed, 11 insertions(+), 19 deletions(-) > >>>>>>>> > >>>>>>>> Reviewed-by: Cornelia Huck <cohuck@redhat.com> > >>>>>>>> > >>>>>>>> I'd vote for merging this patch right away for 5.2. > >>>>>>> > >>>>>>> So which tree is this going through? mine? > >>>>>>> > >>>>>> > >>>>>> Christian, what do you think? If the whole series is supposed to go in > >>>>>> in one go (which I hope it is), via Martin's tree could be the simplest > >>>>>> route IMHO. > >>>>> > >>>>> > >>>>> The first three patches are virtio(-ccw) only and the those are the ones > >>>>> that I think are ready to go. > >>>>> > >>>>> I'm not feeling comfortable going forward with the remainder as it > >>>>> stands now; waiting for some other folks to give feedback. (They are > >>>>> touching/interacting with code parts I'm not so familiar with, and lack > >>>>> of documentation, while not the developers' fault, does not make it > >>>>> easier.) > >>>>> > >>>>> Michael, would you like to pick up 1-3 for your tree directly? That > >>>>> looks like the easiest way. > >>>> > >>>> Agreed. Michael please pick 1-3. > >>>> We will continue to review 4- first and then see which tree is best. > >>> > >>> Michael, please let me know if you'll pick directly or whether I should > >>> post a series. > >>> > >>> [Given that the patches are from one virtio-ccw maintainer and reviewed > >>> by the other, picking directly would eliminate an unnecessary > >>> indirection :)] > >> > >> picked them > > > > Thanks! > > > > Connie, > > if I get you right here, you don't need a v2 for the > patches 1 through 3? Exactly, they are all queued in Michael's tree. > > Thanks, > Michael >
next prev parent reply other threads:[~2019-05-13 12:29 UTC|newest] Thread overview: 182+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-26 18:32 [PATCH 00/10] s390: virtio: support protected virtualization Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-04-26 18:32 ` [PATCH 01/10] virtio/s390: use vring_create_virtqueue Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-03 9:17 ` Cornelia Huck 2019-05-03 20:04 ` Michael S. Tsirkin 2019-05-03 20:04 ` Michael S. Tsirkin 2019-05-04 14:03 ` Halil Pasic 2019-05-04 14:03 ` Halil Pasic 2019-05-05 11:15 ` Cornelia Huck 2019-05-05 11:15 ` Cornelia Huck 2019-05-07 13:58 ` Christian Borntraeger 2019-05-07 13:58 ` Christian Borntraeger 2019-05-08 20:12 ` Halil Pasic 2019-05-08 20:12 ` Halil Pasic 2019-05-10 14:07 ` Cornelia Huck 2019-05-10 14:07 ` Cornelia Huck 2019-05-12 16:47 ` Michael S. Tsirkin 2019-05-12 16:47 ` Michael S. Tsirkin 2019-05-13 9:52 ` Cornelia Huck 2019-05-13 9:52 ` Cornelia Huck 2019-05-13 12:27 ` Michael Mueller 2019-05-13 12:27 ` Michael Mueller 2019-05-13 12:29 ` Cornelia Huck [this message] 2019-05-13 12:29 ` Cornelia Huck 2019-04-26 18:32 ` [PATCH 02/10] virtio/s390: DMA support for virtio-ccw Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-03 9:31 ` Cornelia Huck 2019-04-26 18:32 ` [PATCH 03/10] virtio/s390: enable packed ring Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-03 9:44 ` Cornelia Huck 2019-05-05 15:13 ` Thomas Huth 2019-05-05 15:13 ` Thomas Huth 2019-04-26 18:32 ` [PATCH 04/10] s390/mm: force swiotlb for protected virtualization Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-04-26 19:27 ` Christoph Hellwig 2019-04-26 19:27 ` Christoph Hellwig 2019-04-29 13:59 ` Halil Pasic 2019-04-29 13:59 ` Halil Pasic 2019-04-29 14:05 ` Christian Borntraeger 2019-04-29 14:05 ` Christian Borntraeger 2019-05-13 12:50 ` Michael Mueller 2019-05-13 12:50 ` Michael Mueller 2019-05-08 13:15 ` Claudio Imbrenda 2019-05-08 13:15 ` Claudio Imbrenda 2019-05-09 22:34 ` Halil Pasic 2019-05-09 22:34 ` Halil Pasic 2019-05-15 14:15 ` Michael Mueller 2019-05-15 14:15 ` Michael Mueller [not found] ` <ad23f5e7-dc78-04af-c892-47bbc65134c6@linux.ibm.com> 2019-05-09 18:05 ` Jason J. Herne 2019-05-09 18:05 ` Jason J. Herne 2019-05-09 18:05 ` Jason J. Herne 2019-05-10 7:49 ` Claudio Imbrenda 2019-05-10 7:49 ` Claudio Imbrenda 2019-04-26 18:32 ` [PATCH 05/10] s390/cio: introduce DMA pools to cio Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-08 13:18 ` Sebastian Ott 2019-05-08 13:18 ` Sebastian Ott 2019-05-08 21:22 ` Halil Pasic 2019-05-08 21:22 ` Halil Pasic 2019-05-09 8:40 ` Sebastian Ott 2019-05-09 8:40 ` Sebastian Ott 2019-05-09 10:11 ` Cornelia Huck 2019-05-09 10:11 ` Cornelia Huck 2019-05-09 22:11 ` Halil Pasic 2019-05-09 22:11 ` Halil Pasic 2019-05-10 14:10 ` Cornelia Huck 2019-05-10 14:10 ` Cornelia Huck 2019-05-12 18:22 ` Halil Pasic 2019-05-12 18:22 ` Halil Pasic 2019-05-13 13:29 ` Cornelia Huck 2019-05-13 13:29 ` Cornelia Huck 2019-05-15 17:12 ` Halil Pasic 2019-05-15 17:12 ` Halil Pasic 2019-05-16 6:13 ` Cornelia Huck 2019-05-16 6:13 ` Cornelia Huck 2019-05-16 13:59 ` Sebastian Ott 2019-05-16 13:59 ` Sebastian Ott 2019-05-20 12:13 ` Halil Pasic 2019-05-20 12:13 ` Halil Pasic 2019-05-21 8:46 ` Michael Mueller 2019-05-21 8:46 ` Michael Mueller 2019-05-22 12:07 ` Sebastian Ott 2019-05-22 12:07 ` Sebastian Ott 2019-05-22 22:12 ` Halil Pasic 2019-05-22 22:12 ` Halil Pasic 2019-05-23 15:17 ` Halil Pasic 2019-05-23 15:17 ` Halil Pasic 2019-04-26 18:32 ` [PATCH 06/10] s390/cio: add basic protected virtualization support Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-08 13:46 ` Sebastian Ott 2019-05-08 13:46 ` Sebastian Ott 2019-05-08 13:54 ` Christoph Hellwig 2019-05-08 13:54 ` Christoph Hellwig 2019-05-08 21:08 ` Halil Pasic 2019-05-08 21:08 ` Halil Pasic 2019-05-09 8:52 ` Sebastian Ott 2019-05-09 8:52 ` Sebastian Ott 2019-05-08 14:23 ` Pierre Morel 2019-05-08 14:23 ` Pierre Morel 2019-05-13 9:41 ` Cornelia Huck 2019-05-13 9:41 ` Cornelia Huck 2019-05-14 14:47 ` Jason J. Herne 2019-05-14 14:47 ` Jason J. Herne 2019-05-15 21:08 ` Halil Pasic 2019-05-15 21:08 ` Halil Pasic 2019-05-16 6:32 ` Cornelia Huck 2019-05-16 6:32 ` Cornelia Huck 2019-05-16 13:42 ` Halil Pasic 2019-05-16 13:42 ` Halil Pasic 2019-05-16 13:54 ` Cornelia Huck 2019-05-16 13:54 ` Cornelia Huck 2019-05-15 20:51 ` Halil Pasic 2019-05-15 20:51 ` Halil Pasic 2019-05-16 6:29 ` Cornelia Huck 2019-05-16 6:29 ` Cornelia Huck 2019-05-18 18:11 ` Halil Pasic 2019-05-18 18:11 ` Halil Pasic 2019-05-20 10:21 ` Cornelia Huck 2019-05-20 10:21 ` Cornelia Huck 2019-05-20 12:34 ` Halil Pasic 2019-05-20 12:34 ` Halil Pasic 2019-05-20 13:43 ` Cornelia Huck 2019-05-20 13:43 ` Cornelia Huck 2019-04-26 18:32 ` [PATCH 07/10] s390/airq: use DMA memory for adapter interrupts Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-08 13:58 ` Sebastian Ott 2019-05-08 13:58 ` Sebastian Ott 2019-05-09 11:37 ` Cornelia Huck 2019-05-09 11:37 ` Cornelia Huck 2019-05-13 12:59 ` Cornelia Huck 2019-05-13 12:59 ` Cornelia Huck 2019-04-26 18:32 ` [PATCH 08/10] virtio/s390: add indirection to indicators access Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-08 14:31 ` Pierre Morel 2019-05-08 14:31 ` Pierre Morel 2019-05-09 12:01 ` Pierre Morel 2019-05-09 12:01 ` Pierre Morel 2019-05-09 18:26 ` Halil Pasic 2019-05-09 18:26 ` Halil Pasic 2019-05-10 7:43 ` Pierre Morel 2019-05-10 7:43 ` Pierre Morel 2019-05-10 11:54 ` Halil Pasic 2019-05-10 11:54 ` Halil Pasic 2019-05-10 15:36 ` Pierre Morel 2019-05-10 15:36 ` Pierre Morel 2019-05-13 10:15 ` Cornelia Huck 2019-05-13 10:15 ` Cornelia Huck 2019-05-16 15:24 ` Pierre Morel 2019-05-16 15:24 ` Pierre Morel 2019-04-26 18:32 ` [PATCH 09/10] virtio/s390: use DMA memory for ccw I/O and classic notifiers Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-08 14:46 ` Pierre Morel 2019-05-08 14:46 ` Pierre Morel 2019-05-09 13:30 ` Pierre Morel 2019-05-09 13:30 ` Pierre Morel 2019-05-09 18:30 ` Halil Pasic 2019-05-09 18:30 ` Halil Pasic 2019-05-13 13:54 ` Cornelia Huck 2019-05-13 13:54 ` Cornelia Huck 2019-04-26 18:32 ` [PATCH 10/10] virtio/s390: make airq summary indicators DMA Halil Pasic 2019-04-26 18:32 ` Halil Pasic 2019-05-08 15:11 ` Pierre Morel 2019-05-08 15:11 ` Pierre Morel 2019-05-15 13:33 ` Michael Mueller 2019-05-15 13:33 ` Michael Mueller 2019-05-15 17:23 ` Halil Pasic 2019-05-15 17:23 ` Halil Pasic 2019-05-13 12:20 ` Cornelia Huck 2019-05-13 12:20 ` Cornelia Huck 2019-05-15 13:43 ` Michael Mueller 2019-05-15 13:43 ` Michael Mueller 2019-05-15 13:50 ` Cornelia Huck 2019-05-15 13:50 ` Cornelia Huck 2019-05-15 17:18 ` Halil Pasic 2019-05-15 17:18 ` Halil Pasic 2019-05-03 9:55 ` [PATCH 00/10] s390: virtio: support protected virtualization Cornelia Huck 2019-05-03 10:03 ` Juergen Gross 2019-05-03 13:33 ` Cornelia Huck 2019-05-03 13:33 ` Cornelia Huck 2019-05-04 13:58 ` Halil Pasic 2019-05-04 13:58 ` Halil Pasic
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190513142945.27e5921f.cohuck@redhat.com \ --to=cohuck@redhat.com \ --cc=alifm@linux.ibm.com \ --cc=borntraeger@de.ibm.com \ --cc=farman@linux.ibm.com \ --cc=frankja@linux.ibm.com \ --cc=gor@linux.ibm.com \ --cc=hch@infradead.org \ --cc=imbrenda@linux.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=mihajlov@linux.ibm.com \ --cc=mimu@linux.ibm.com \ --cc=mst@redhat.com \ --cc=pasic@linux.ibm.com \ --cc=schwidefsky@de.ibm.com \ --cc=sebott@linux.ibm.com \ --cc=thuth@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.