From: Jerome Glisse <jglisse@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Kuehling, Felix" <Felix.Kuehling@amd.com>,
"alex.deucher@amd.com" <alex.deucher@amd.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Yang, Philip" <Philip.Yang@amd.com>
Subject: Re: [PATCH 1/2] mm/hmm: support automatic NUMA balancing
Date: Mon, 13 May 2019 18:37:01 -0400 [thread overview]
Message-ID: <20190513223700.GA673@redhat.com> (raw)
In-Reply-To: <20190513142720.3334a98cbabaae67b4ffbb5a@linux-foundation.org>
On Mon, May 13, 2019 at 02:27:20PM -0700, Andrew Morton wrote:
> On Fri, 10 May 2019 19:53:23 +0000 "Kuehling, Felix" <Felix.Kuehling@amd.com> wrote:
>
> > From: Philip Yang <Philip.Yang@amd.com>
> >
> > While the page is migrating by NUMA balancing, HMM failed to detect this
> > condition and still return the old page. Application will use the new
> > page migrated, but driver pass the old page physical address to GPU,
> > this crash the application later.
> >
> > Use pte_protnone(pte) to return this condition and then hmm_vma_do_fault
> > will allocate new page.
> >
> > Signed-off-by: Philip Yang <Philip.Yang@amd.com>
>
> This should have included your signed-off-by:, since you were on the
> patch delivery path. I'll make that change to my copy of the patch,
> OK?
Yes it should have included that.
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: "Yang, Philip" <Philip.Yang-5C7GfCeVMHo@public.gmane.org>,
"alex.deucher-5C7GfCeVMHo@public.gmane.org"
<alex.deucher-5C7GfCeVMHo@public.gmane.org>,
"Kuehling, Felix" <Felix.Kuehling-5C7GfCeVMHo@public.gmane.org>,
"amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
"dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
"airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 1/2] mm/hmm: support automatic NUMA balancing
Date: Mon, 13 May 2019 18:37:01 -0400 [thread overview]
Message-ID: <20190513223700.GA673@redhat.com> (raw)
In-Reply-To: <20190513142720.3334a98cbabaae67b4ffbb5a-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
On Mon, May 13, 2019 at 02:27:20PM -0700, Andrew Morton wrote:
> On Fri, 10 May 2019 19:53:23 +0000 "Kuehling, Felix" <Felix.Kuehling@amd.com> wrote:
>
> > From: Philip Yang <Philip.Yang@amd.com>
> >
> > While the page is migrating by NUMA balancing, HMM failed to detect this
> > condition and still return the old page. Application will use the new
> > page migrated, but driver pass the old page physical address to GPU,
> > this crash the application later.
> >
> > Use pte_protnone(pte) to return this condition and then hmm_vma_do_fault
> > will allocate new page.
> >
> > Signed-off-by: Philip Yang <Philip.Yang@amd.com>
>
> This should have included your signed-off-by:, since you were on the
> patch delivery path. I'll make that change to my copy of the patch,
> OK?
Yes it should have included that.
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2019-05-13 22:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 19:53 [PATCH 0/2] Two bug-fixes for HMM Kuehling, Felix
2019-05-10 19:53 ` Kuehling, Felix
2019-05-10 19:53 ` [PATCH 1/2] mm/hmm: support automatic NUMA balancing Kuehling, Felix
2019-05-10 19:53 ` Kuehling, Felix
2019-05-10 20:13 ` Jerome Glisse
2019-05-10 20:13 ` Jerome Glisse
2019-05-13 21:27 ` Andrew Morton
2019-05-13 21:27 ` Andrew Morton
2019-05-13 22:37 ` Jerome Glisse [this message]
2019-05-13 22:37 ` Jerome Glisse
2019-05-14 21:14 ` Kuehling, Felix
2019-05-14 21:14 ` Kuehling, Felix
2019-05-10 19:53 ` [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking Kuehling, Felix
2019-05-10 19:53 ` Kuehling, Felix
2019-05-10 20:14 ` Jerome Glisse
2019-05-10 20:14 ` Jerome Glisse
2019-05-13 19:36 ` Kuehling, Felix
2019-05-13 19:36 ` Kuehling, Felix
2019-05-13 19:49 ` Jerome Glisse
2019-05-13 19:49 ` Jerome Glisse
2019-05-13 20:31 ` Kuehling, Felix
2019-05-13 20:31 ` Kuehling, Felix
2019-05-13 20:21 ` Deucher, Alexander
2019-05-13 20:21 ` Deucher, Alexander
2019-05-14 21:12 ` Kuehling, Felix
2019-05-14 21:12 ` Kuehling, Felix
2019-05-14 21:58 ` Alex Deucher
2019-05-14 21:58 ` Alex Deucher
2019-06-06 15:11 ` [PATCH 0/2] Two bug-fixes for HMM Jason Gunthorpe
2019-06-06 15:11 ` Jason Gunthorpe
2019-06-06 19:04 ` Kuehling, Felix
2019-06-06 19:04 ` Kuehling, Felix
2019-06-06 19:20 ` Jason Gunthorpe
2019-06-06 19:20 ` Jason Gunthorpe
2019-06-06 19:16 ` Kuehling, Felix
2019-06-06 19:16 ` Kuehling, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513223700.GA673@redhat.com \
--to=jglisse@redhat.com \
--cc=Felix.Kuehling@amd.com \
--cc=Philip.Yang@amd.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.