From: Brendan Higgins <brendanhiggins@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org,
keescook@google.com, kieran.bingham@ideasonboard.com,
mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org,
shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com,
Josh Poimboeuf <jpoimboe@redhat.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-um@lists.infradead.org,
Alexander.Levin@microsoft.com, Tim.Bird@sony.com,
amir73il@gmail.com, dan.carpenter@oracle.com,
dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com,
joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com,
knut.om
Subject: Re: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list
Date: Tue, 14 May 2019 11:12:33 -0700 [thread overview]
Message-ID: <20190514181233.GB109557@google.com> (raw)
In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net>
On Tue, May 14, 2019 at 10:46:55AM +0200, Peter Zijlstra wrote:
> On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote:
> > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote:
> > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote:
> > > > This fixes the following warning seen on GCC 7.3:
> > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch()
> > > >
> > >
> > > What is that file and function; no kernel tree near me seems to have
> > > that.
> >
> > Oh, sorry about that. The function is added in the following patch,
> > "[PATCH v3 09/18] kunit: test: add support for test abort"[1].
> >
> > My apologies if this patch is supposed to come after it in sequence, but
> > I assumed it should come before otherwise objtool would complain about
> > the symbol when it is introduced.
>
> Or send me all patches such that I have context, or have a sane
> Changelog that gives me context. Just don't give me one patch with a
> crappy changelog.
I will provide more context in the next revision.
Sorry about that!
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org,
keescook@google.com, kieran.bingham@ideasonboard.com,
mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org,
shuah@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com,
Josh Poimboeuf <jpoimboe@redhat.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-um@lists.infradead.org,
Alexander.Levin@microsoft.com, Tim.Bird@sony.com,
amir73il@gmail.com, dan.carpenter@oracle.com,
dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com,
joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com,
knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au,
pmladek@suse.com, rdunlap@infradead.org, richard@nod.at,
rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com,
kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list
Date: Tue, 14 May 2019 11:12:33 -0700 [thread overview]
Message-ID: <20190514181233.GB109557@google.com> (raw)
In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net>
On Tue, May 14, 2019 at 10:46:55AM +0200, Peter Zijlstra wrote:
> On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote:
> > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote:
> > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote:
> > > > This fixes the following warning seen on GCC 7.3:
> > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch()
> > > >
> > >
> > > What is that file and function; no kernel tree near me seems to have
> > > that.
> >
> > Oh, sorry about that. The function is added in the following patch,
> > "[PATCH v3 09/18] kunit: test: add support for test abort"[1].
> >
> > My apologies if this patch is supposed to come after it in sequence, but
> > I assumed it should come before otherwise objtool would complain about
> > the symbol when it is introduced.
>
> Or send me all patches such that I have context, or have a sane
> Changelog that gives me context. Just don't give me one patch with a
> crappy changelog.
I will provide more context in the next revision.
Sorry about that!
WARNING: multiple messages have this Message-ID (diff)
From: brendanhiggins at google.com (Brendan Higgins)
Subject: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list
Date: Tue, 14 May 2019 11:12:33 -0700 [thread overview]
Message-ID: <20190514181233.GB109557@google.com> (raw)
In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net>
On Tue, May 14, 2019 at 10:46:55AM +0200, Peter Zijlstra wrote:
> On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote:
> > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote:
> > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote:
> > > > This fixes the following warning seen on GCC 7.3:
> > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch()
> > > >
> > >
> > > What is that file and function; no kernel tree near me seems to have
> > > that.
> >
> > Oh, sorry about that. The function is added in the following patch,
> > "[PATCH v3 09/18] kunit: test: add support for test abort"[1].
> >
> > My apologies if this patch is supposed to come after it in sequence, but
> > I assumed it should come before otherwise objtool would complain about
> > the symbol when it is introduced.
>
> Or send me all patches such that I have context, or have a sane
> Changelog that gives me context. Just don't give me one patch with a
> crappy changelog.
I will provide more context in the next revision.
Sorry about that!
WARNING: multiple messages have this Message-ID (diff)
From: brendanhiggins@google.com (Brendan Higgins)
Subject: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list
Date: Tue, 14 May 2019 11:12:33 -0700 [thread overview]
Message-ID: <20190514181233.GB109557@google.com> (raw)
Message-ID: <20190514181233.VZOU4qMlVkndFSBaoMhtLSrz5SMZzTKCnfVrnx1H-7M@z> (raw)
In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net>
On Tue, May 14, 2019@10:46:55AM +0200, Peter Zijlstra wrote:
> On Tue, May 14, 2019@01:12:23AM -0700, Brendan Higgins wrote:
> > On Tue, May 14, 2019@08:56:43AM +0200, Peter Zijlstra wrote:
> > > On Mon, May 13, 2019@10:42:42PM -0700, Brendan Higgins wrote:
> > > > This fixes the following warning seen on GCC 7.3:
> > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch()
> > > >
> > >
> > > What is that file and function; no kernel tree near me seems to have
> > > that.
> >
> > Oh, sorry about that. The function is added in the following patch,
> > "[PATCH v3 09/18] kunit: test: add support for test abort"[1].
> >
> > My apologies if this patch is supposed to come after it in sequence, but
> > I assumed it should come before otherwise objtool would complain about
> > the symbol when it is introduced.
>
> Or send me all patches such that I have context, or have a sane
> Changelog that gives me context. Just don't give me one patch with a
> crappy changelog.
I will provide more context in the next revision.
Sorry about that!
WARNING: multiple messages have this Message-ID (diff)
From: Brendan Higgins <brendanhiggins@google.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com,
dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com,
yamada.masahiro@socionext.com, mpe@ellerman.id.au,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
robh@kernel.org, kbuild test robot <lkp@intel.com>,
linux-nvdimm@lists.01.org, frowand.list@gmail.com,
knut.omang@oracle.com, kieran.bingham@ideasonboard.com,
wfg@linux.intel.com, joel@jms.id.au, rientjes@google.com,
jdike@addtoit.com, dan.carpenter@oracle.com,
devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
Tim.Bird@sony.com, linux-um@lists.infradead.org,
rostedt@goodmis.org, julia.lawall@lip6.fr,
Josh Poimboeuf <jpoimboe@redhat.com>,
dan.j.williams@intel.com, kunit-dev@googlegroups.com,
tytso@mit.edu, richard@nod.at, sboyd@kernel.org,
gregkh@linuxfoundation.org, rdunlap@infradead.org,
linux-kernel@vger.kernel.org, mcgrof@kernel.org, daniel@ffwll.ch,
keescook@google.com, linux-fsdevel@vger.kernel.org,
logang@deltatee.com, khilman@baylibre.com
Subject: Re: [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list
Date: Tue, 14 May 2019 11:12:33 -0700 [thread overview]
Message-ID: <20190514181233.GB109557@google.com> (raw)
In-Reply-To: <20190514084655.GK2589@hirez.programming.kicks-ass.net>
On Tue, May 14, 2019 at 10:46:55AM +0200, Peter Zijlstra wrote:
> On Tue, May 14, 2019 at 01:12:23AM -0700, Brendan Higgins wrote:
> > On Tue, May 14, 2019 at 08:56:43AM +0200, Peter Zijlstra wrote:
> > > On Mon, May 13, 2019 at 10:42:42PM -0700, Brendan Higgins wrote:
> > > > This fixes the following warning seen on GCC 7.3:
> > > > kunit/test-test.o: warning: objtool: kunit_test_unsuccessful_try() falls through to next function kunit_test_catch()
> > > >
> > >
> > > What is that file and function; no kernel tree near me seems to have
> > > that.
> >
> > Oh, sorry about that. The function is added in the following patch,
> > "[PATCH v3 09/18] kunit: test: add support for test abort"[1].
> >
> > My apologies if this patch is supposed to come after it in sequence, but
> > I assumed it should come before otherwise objtool would complain about
> > the symbol when it is introduced.
>
> Or send me all patches such that I have context, or have a sane
> Changelog that gives me context. Just don't give me one patch with a
> crappy changelog.
I will provide more context in the next revision.
Sorry about that!
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
next prev parent reply other threads:[~2019-05-14 18:12 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 5:42 [PATCH v3 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` [PATCH v3 01/18] kunit: test: add KUnit test runner core Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 03/18] kunit: test: add string_stream a std::stream like string builder Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` [PATCH v3 04/18] kunit: test: add kunit_stream a std::stream like logger Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` [PATCH v3 05/18] kunit: test: add the concept of expectations Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 06/18] kbuild: enable building KUnit Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` [PATCH v3 07/18] kunit: test: add initial tests Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` [PATCH v3 08/18] objtool: add kunit_try_catch_throw to the noreturn list Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 6:56 ` Peter Zijlstra
2019-05-14 6:56 ` Peter Zijlstra
2019-05-14 6:56 ` Peter Zijlstra
2019-05-14 6:56 ` peterz
2019-05-14 6:56 ` Peter Zijlstra
2019-05-14 8:12 ` Brendan Higgins
2019-05-14 8:12 ` Brendan Higgins
2019-05-14 8:12 ` Brendan Higgins
2019-05-14 8:12 ` brendanhiggins
2019-05-14 8:12 ` Brendan Higgins
2019-05-14 8:46 ` Peter Zijlstra
2019-05-14 8:46 ` Peter Zijlstra
2019-05-14 8:46 ` Peter Zijlstra
2019-05-14 8:46 ` peterz
2019-05-14 8:46 ` Peter Zijlstra
2019-05-14 8:46 ` Peter Zijlstra
2019-05-14 18:12 ` Brendan Higgins [this message]
2019-05-14 18:12 ` Brendan Higgins
2019-05-14 18:12 ` Brendan Higgins
2019-05-14 18:12 ` brendanhiggins
2019-05-14 18:12 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 09/18] kunit: test: add support for test abort Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
[not found] ` <20190514054251.186196-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-05-14 5:42 ` [PATCH v3 02/18] kunit: test: add test resource management API Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 10/18] kunit: test: add tests for kunit test abort Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 13/18] kunit: tool: add Python wrappers for running KUnit tests Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 14/18] kunit: defconfig: add defconfigs for building " Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 15/18] Documentation: kunit: add documentation for KUnit Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 13:34 ` Jonathan Corbet
2019-05-14 13:34 ` Jonathan Corbet
2019-05-14 13:34 ` Jonathan Corbet
2019-05-14 13:34 ` corbet
2019-05-14 13:34 ` Jonathan Corbet
2019-05-14 18:08 ` Brendan Higgins
2019-05-14 18:08 ` Brendan Higgins
2019-05-14 18:08 ` Brendan Higgins
2019-05-14 18:08 ` brendanhiggins
2019-05-14 18:08 ` Brendan Higgins
2019-05-14 18:16 ` Jonathan Corbet
2019-05-14 18:16 ` Jonathan Corbet
2019-05-14 18:16 ` Jonathan Corbet
2019-05-14 18:16 ` corbet
2019-05-14 18:16 ` Jonathan Corbet
2019-05-14 18:16 ` Jonathan Corbet
2019-05-14 23:19 ` Brendan Higgins
2019-05-14 23:19 ` Brendan Higgins
2019-05-14 23:19 ` Brendan Higgins
2019-05-14 23:19 ` brendanhiggins
2019-05-14 23:19 ` Brendan Higgins
2019-05-15 13:45 ` Jonathan Corbet
2019-05-15 13:45 ` Jonathan Corbet
2019-05-15 13:45 ` Jonathan Corbet
2019-05-15 13:45 ` corbet
2019-05-15 13:45 ` Jonathan Corbet
2019-05-15 13:45 ` Jonathan Corbet
2019-06-04 21:56 ` Brendan Higgins
2019-06-04 21:56 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 16/18] MAINTAINERS: add entry for KUnit the unit testing framework Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` [PATCH v3 11/18] kunit: test: add the concept of assertions Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` [PATCH v3 12/18] kunit: test: add tests for KUnit managed resources Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` Brendan Higgins
2019-05-14 5:42 ` brendanhiggins
2019-05-14 5:42 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514181233.GB109557@google.com \
--to=brendanhiggins@google.com \
--cc=Alexander.Levin@microsoft.com \
--cc=Tim.Bird@sony.com \
--cc=amir73il@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=joel@jms.id.au \
--cc=jpoimboe@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@google.com \
--cc=khilman@baylibre.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-um@lists.infradead.org \
--cc=mcgrof@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tytso@mit.edu \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.