From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 03/11 V2] libxfs: remove unused cruft
Date: Wed, 15 May 2019 15:56:46 +1000 [thread overview]
Message-ID: <20190515055646.GW29573@dread.disaster.area> (raw)
In-Reply-To: <7b7e0bb3-3fac-6602-cff0-c868d6d0540c@sandeen.net>
On Tue, May 14, 2019 at 07:17:44PM -0500, Eric Sandeen wrote:
> Remove many unused #defines and functions.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
....
> /* miscellaneous kernel routines not in user space */
> -#define down_read(a) ((void) 0)
> -#define up_read(a) ((void) 0)
> #define spin_lock_init(a) ((void) 0)
> #define spin_lock(a) ((void) 0)
> #define spin_unlock(a) ((void) 0)
The lack of locking in the userspace code scares me somewhat :P
> @@ -400,7 +397,6 @@ roundup_64(uint64_t x, uint32_t y)
>
> #define XBRW_READ LIBXFS_BREAD
> #define XBRW_WRITE LIBXFS_BWRITE
> -#define xfs_buf_iomove(bp,off,len,data,f) libxfs_iomove(bp,off,len,data,f)
> #define xfs_buf_zero(bp,off,len) libxfs_iomove(bp,off,len,NULL,LIBXFS_BZERO)
>
> /* mount stuff */
> @@ -436,8 +432,6 @@ roundup_64(uint64_t x, uint32_t y)
> #define xfs_sort qsort
>
> #define xfs_ilock(ip,mode) ((void) 0)
> -#define xfs_ilock_nowait(ip,mode) ((void) 0)
> -#define xfs_ilock_demote(ip,mode) ((void) 0)
Especially that we have transactions that run without inode locks.
But that's not a problem this patch solves, so may as well get rid
of the unused interfaces...
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-05-15 5:56 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 20:18 [PATCH 00/11] libxfs: spring cleaning Eric Sandeen
2019-05-10 20:18 ` [PATCH 01/11] libxfs: remove i_transp Eric Sandeen
2019-05-15 5:51 ` Dave Chinner
2019-05-15 6:50 ` Christoph Hellwig
2019-05-10 20:18 ` [PATCH 02/11] libxfs: remove xfs_inode_log_item ili_flags Eric Sandeen
2019-05-15 5:53 ` Dave Chinner
2019-05-15 6:50 ` Christoph Hellwig
2019-05-10 20:18 ` [PATCH 03/11] libxfs: remove unused cruft Eric Sandeen
2019-05-15 0:17 ` [PATCH 03/11 V2] " Eric Sandeen
2019-05-15 5:56 ` Dave Chinner [this message]
2019-05-15 6:51 ` [PATCH 03/11] " Christoph Hellwig
2019-05-10 20:18 ` [PATCH 04/11] libxfs: rename bp_transp to b_transp in ASSERTs Eric Sandeen
2019-05-15 5:57 ` Dave Chinner
2019-05-15 6:51 ` Christoph Hellwig
2019-05-10 20:18 ` [PATCH 05/11] libxfs: de-libxfsify core(-ish) functions Eric Sandeen
2019-05-10 21:41 ` Eric Sandeen
2019-05-15 6:52 ` Christoph Hellwig
2019-05-15 12:38 ` Eric Sandeen
2019-05-10 20:18 ` [PATCH 06/11] libxfs: create new file trans_buf.c Eric Sandeen
2019-05-15 6:07 ` Dave Chinner
2019-05-15 6:52 ` Christoph Hellwig
2019-05-15 12:40 ` Eric Sandeen
2019-05-15 12:42 ` Eric Sandeen
2019-05-10 20:18 ` [PATCH 07/11] libxfs: create new file buf_item.c Eric Sandeen
2019-05-10 20:18 ` [PATCH 08/11] libxfs: create new file inode_item.c Eric Sandeen
2019-05-10 20:18 ` [PATCH 09/11] libxfs: create new file trans_inode.c Eric Sandeen
2019-05-10 20:18 ` [PATCH 10/11] libxfs: reorder trans.c to match xfs_trans.c Eric Sandeen
2019-05-10 20:18 ` [PATCH 11/11] libxfs: minor sync-ups to kernel-ish functions Eric Sandeen
2019-05-15 6:25 ` Dave Chinner
2019-05-15 12:49 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515055646.GW29573@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.