From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 06/11] libxfs: create new file trans_buf.c
Date: Wed, 15 May 2019 07:42:19 -0500 [thread overview]
Message-ID: <8808a6c0-eebe-85b9-3f13-86ed8effdac5@sandeen.net> (raw)
In-Reply-To: <20190515060750.GY29573@dread.disaster.area>
On 5/15/19 1:07 AM, Dave Chinner wrote:
> On Fri, May 10, 2019 at 03:18:25PM -0500, Eric Sandeen wrote:
>> Pull functions out of libxfs/*.c into trans_buf.c, if they roughly match
>> the kernel's xfs_trans_buf.c file.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> So I have no problems with this, but I'm not sure what the eventual
> goal is? Just sharing code, or is there some functionality that
> requires a more complete transaction subsystem in userspace?
>
> I'm asking because if the goal is eventual unification with the
> kernel code, then we probably should name the files the same as the
> kernel code so we don't have to rename them again when we do the
> unification. That will make history searching a bit easier - less
> file names to follow across and git blame works a whole lot better...
>
>> +int
>> +xfs_trans_read_buf_map(
>> + xfs_mount_t *mp,
>> + xfs_trans_t *tp,
>> + struct xfs_buftarg *btp,
>> + struct xfs_buf_map *map,
>> + int nmaps,
>> + uint flags,
>> + xfs_buf_t **bpp,
>> + const struct xfs_buf_ops *ops)
>
> Hmmmm. Will there be any follow-up to de-typedef these new files?
>
> /me would love to just have a flag day that de-typedefs all of the
> userspace code.
Yes, after I moved stuff enough to see how/if it matches the kernel,
I de-typdefed to match where the kernel has done so.
I could certainly roll that into this patch. I was trying to do small
steps but maybe that just makes things more complex to follow...
-Eric
next prev parent reply other threads:[~2019-05-15 12:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 20:18 [PATCH 00/11] libxfs: spring cleaning Eric Sandeen
2019-05-10 20:18 ` [PATCH 01/11] libxfs: remove i_transp Eric Sandeen
2019-05-15 5:51 ` Dave Chinner
2019-05-15 6:50 ` Christoph Hellwig
2019-05-10 20:18 ` [PATCH 02/11] libxfs: remove xfs_inode_log_item ili_flags Eric Sandeen
2019-05-15 5:53 ` Dave Chinner
2019-05-15 6:50 ` Christoph Hellwig
2019-05-10 20:18 ` [PATCH 03/11] libxfs: remove unused cruft Eric Sandeen
2019-05-15 0:17 ` [PATCH 03/11 V2] " Eric Sandeen
2019-05-15 5:56 ` Dave Chinner
2019-05-15 6:51 ` [PATCH 03/11] " Christoph Hellwig
2019-05-10 20:18 ` [PATCH 04/11] libxfs: rename bp_transp to b_transp in ASSERTs Eric Sandeen
2019-05-15 5:57 ` Dave Chinner
2019-05-15 6:51 ` Christoph Hellwig
2019-05-10 20:18 ` [PATCH 05/11] libxfs: de-libxfsify core(-ish) functions Eric Sandeen
2019-05-10 21:41 ` Eric Sandeen
2019-05-15 6:52 ` Christoph Hellwig
2019-05-15 12:38 ` Eric Sandeen
2019-05-10 20:18 ` [PATCH 06/11] libxfs: create new file trans_buf.c Eric Sandeen
2019-05-15 6:07 ` Dave Chinner
2019-05-15 6:52 ` Christoph Hellwig
2019-05-15 12:40 ` Eric Sandeen
2019-05-15 12:42 ` Eric Sandeen [this message]
2019-05-10 20:18 ` [PATCH 07/11] libxfs: create new file buf_item.c Eric Sandeen
2019-05-10 20:18 ` [PATCH 08/11] libxfs: create new file inode_item.c Eric Sandeen
2019-05-10 20:18 ` [PATCH 09/11] libxfs: create new file trans_inode.c Eric Sandeen
2019-05-10 20:18 ` [PATCH 10/11] libxfs: reorder trans.c to match xfs_trans.c Eric Sandeen
2019-05-10 20:18 ` [PATCH 11/11] libxfs: minor sync-ups to kernel-ish functions Eric Sandeen
2019-05-15 6:25 ` Dave Chinner
2019-05-15 12:49 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8808a6c0-eebe-85b9-3f13-86ed8effdac5@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.