From: Charles Keepax <ckeepax@opensource.cirrus.com> To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>, Mauro Carvalho Chehab <mchehab@infradead.org>, <linux-kernel@vger.kernel.org>, Jonathan Corbet <corbet@lwn.net>, Richard Fitzgerald <rf@opensource.cirrus.com>, Lee Jones <lee.jones@linaro.org>, <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com> Subject: Re: [PATCH 07/10] mfd: madera: point to the right pinctrl binding file Date: Mon, 20 May 2019 16:42:45 +0100 [thread overview] Message-ID: <20190520154244.GA99937@ediswmail.ad.cirrus.com> (raw) In-Reply-To: <fb47879d405e624374d7d4e099988296ed2af668.1558362030.git.mchehab+samsung@kernel.org> On Mon, May 20, 2019 at 11:47:36AM -0300, Mauro Carvalho Chehab wrote: > The reference to Documentation/pinctrl.txt doesn't exist, but > there is an specific binding for the madera driver. > > So, point to it. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > --- > include/linux/mfd/madera/pdata.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mfd/madera/pdata.h b/include/linux/mfd/madera/pdata.h > index 8dc852402dbb..c7e0658eb74b 100644 > --- a/include/linux/mfd/madera/pdata.h > +++ b/include/linux/mfd/madera/pdata.h > @@ -34,7 +34,8 @@ struct madera_codec_pdata; > * @micvdd: Substruct of pdata for the MICVDD regulator > * @irq_flags: Mode for primary IRQ (defaults to active low) > * @gpio_base: Base GPIO number > - * @gpio_configs: Array of GPIO configurations (See Documentation/pinctrl.txt) > + * @gpio_configs: Array of GPIO configurations > + * (See Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt) I believe this is trying to point at the generic pinctrl docs which now live here: Documentation/driver-api/pinctl.rst There is a patch to do this already: https://lkml.org/lkml/2019/1/9/853 With the latest resend here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2001752.html Thanks, Charles > * @n_gpio_configs: Number of entries in gpio_configs > * @gpsw: General purpose switch mode setting. Depends on the external > * hardware connected to the switch. (See the SW1_MODE field > -- > 2.21.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com> To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>, Mauro Carvalho Chehab <mchehab@infradead.org>, linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>, Richard Fitzgerald <rf@opensource.cirrus.com>, Lee Jones <lee.jones@linaro.org>, alsa-devel@alsa-project.org, patches@opensource.cirrus.com Subject: Re: [PATCH 07/10] mfd: madera: point to the right pinctrl binding file Date: Mon, 20 May 2019 16:42:45 +0100 [thread overview] Message-ID: <20190520154244.GA99937@ediswmail.ad.cirrus.com> (raw) In-Reply-To: <fb47879d405e624374d7d4e099988296ed2af668.1558362030.git.mchehab+samsung@kernel.org> On Mon, May 20, 2019 at 11:47:36AM -0300, Mauro Carvalho Chehab wrote: > The reference to Documentation/pinctrl.txt doesn't exist, but > there is an specific binding for the madera driver. > > So, point to it. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> > --- > include/linux/mfd/madera/pdata.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mfd/madera/pdata.h b/include/linux/mfd/madera/pdata.h > index 8dc852402dbb..c7e0658eb74b 100644 > --- a/include/linux/mfd/madera/pdata.h > +++ b/include/linux/mfd/madera/pdata.h > @@ -34,7 +34,8 @@ struct madera_codec_pdata; > * @micvdd: Substruct of pdata for the MICVDD regulator > * @irq_flags: Mode for primary IRQ (defaults to active low) > * @gpio_base: Base GPIO number > - * @gpio_configs: Array of GPIO configurations (See Documentation/pinctrl.txt) > + * @gpio_configs: Array of GPIO configurations > + * (See Documentation/devicetree/bindings/pinctrl/cirrus,madera-pinctrl.txt) I believe this is trying to point at the generic pinctrl docs which now live here: Documentation/driver-api/pinctl.rst There is a patch to do this already: https://lkml.org/lkml/2019/1/9/853 With the latest resend here: https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2001752.html Thanks, Charles > * @n_gpio_configs: Number of entries in gpio_configs > * @gpsw: General purpose switch mode setting. Depends on the external > * hardware connected to the switch. (See the SW1_MODE field > -- > 2.21.0 >
next prev parent reply other threads:[~2019-05-20 15:43 UTC|newest] Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-20 14:47 [PATCH 00/10] Fix broken documentation references at v5.2-rc1 Mauro Carvalho Chehab 2019-05-20 14:47 ` [PATCH 01/10] scripts/documentation-file-ref-check: better handle translations Mauro Carvalho Chehab 2019-05-20 14:47 ` [PATCH 02/10] scripts/documentation-file-ref-check: exclude false-positives Mauro Carvalho Chehab 2019-05-20 14:47 ` [PATCH 03/10] scripts/documentation-file-ref-check: improve tools ref handling Mauro Carvalho Chehab 2019-05-20 14:47 ` [PATCH 04/10] scripts/documentation-file-ref-check: teach about .txt -> .yaml renames Mauro Carvalho Chehab 2019-05-20 14:47 ` [PATCH 05/10] ABI: sysfs-devices-system-cpu: point to the right docs Mauro Carvalho Chehab 2019-05-20 14:47 ` [PATCH 06/10] isdn: mISDN: remove a bogus reference to a non-existing doc Mauro Carvalho Chehab 2019-05-20 14:47 ` [PATCH 07/10] mfd: madera: point to the right pinctrl binding file Mauro Carvalho Chehab 2019-05-20 15:42 ` Charles Keepax [this message] 2019-05-20 15:42 ` Charles Keepax 2019-05-20 18:48 ` Mauro Carvalho Chehab 2019-05-20 18:48 ` Mauro Carvalho Chehab 2019-05-20 14:47 ` [PATCH 08/10] dt: fix refs that were renamed to json with the same file name Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 15:57 ` Rob Herring 2019-05-20 15:57 ` Rob Herring 2019-05-20 16:13 ` Mauro Carvalho Chehab 2019-05-20 16:13 ` Mauro Carvalho Chehab 2019-05-20 23:00 ` Rob Herring 2019-05-20 23:00 ` Rob Herring 2019-05-20 14:47 ` [PATCH 09/10] dt: fix broken references to nand.txt Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 15:37 ` Miquel Raynal 2019-05-20 15:37 ` Miquel Raynal 2019-05-20 15:37 ` Miquel Raynal 2019-05-20 15:37 ` Miquel Raynal 2019-05-20 14:47 ` [PATCH 10/10] docs: fix broken documentation links Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 14:47 ` [Xen-devel] " Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 14:47 ` mchehab+samsung 2019-05-20 14:47 ` Mauro Carvalho Chehab 2019-05-20 15:05 ` Wolfram Sang 2019-05-20 15:05 ` Wolfram Sang 2019-05-20 15:05 ` [Xen-devel] " Wolfram Sang 2019-05-20 15:05 ` Wolfram Sang 2019-05-20 15:05 ` Wolfram Sang 2019-05-20 15:05 ` Wolfram Sang 2019-05-20 15:05 ` wsa 2019-05-20 15:05 ` Wolfram Sang 2019-05-20 15:05 ` Wolfram Sang 2019-05-21 22:56 ` Federico Vaga 2019-05-21 22:56 ` Federico Vaga 2019-05-21 22:56 ` [Xen-devel] " Federico Vaga 2019-05-21 22:56 ` Federico Vaga 2019-05-21 22:56 ` Federico Vaga 2019-05-21 22:56 ` Federico Vaga 2019-05-21 22:56 ` federico.vaga 2019-05-21 22:56 ` Federico Vaga 2019-05-21 22:56 ` Federico Vaga 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-27 8:43 ` [Devel] " Rafael J. Wysocki 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-27 8:43 ` [Xen-devel] " Rafael J. Wysocki 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-27 8:43 ` rafael 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-27 8:43 ` Rafael J. Wysocki 2019-05-21 22:54 ` [PATCH 00/10] Fix broken documentation references at v5.2-rc1 Federico Vaga 2019-05-22 0:26 ` Mauro Carvalho Chehab 2019-05-22 20:18 ` Federico Vaga
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190520154244.GA99937@ediswmail.ad.cirrus.com \ --to=ckeepax@opensource.cirrus.com \ --cc=alsa-devel@alsa-project.org \ --cc=corbet@lwn.net \ --cc=lee.jones@linaro.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mchehab+samsung@kernel.org \ --cc=mchehab@infradead.org \ --cc=patches@opensource.cirrus.com \ --cc=rf@opensource.cirrus.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.