From: Greg KH <gregkh@linuxfoundation.org>
To: Liming Sun <lsun@mellanox.com>
Cc: Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Vadim Pasternak <vadimp@mellanox.com>,
David Woods <dwoods@mellanox.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc
Date: Mon, 20 May 2019 21:12:09 +0200 [thread overview]
Message-ID: <20190520191209.GA29776@kroah.com> (raw)
In-Reply-To: <DB6PR05MB32232CA5DD05D1A923A28215A1060@DB6PR05MB3223.eurprd05.prod.outlook.com>
On Mon, May 20, 2019 at 06:07:44PM +0000, Liming Sun wrote:
> > > +static struct platform_driver mlxbf_bootctl_driver = {
> > > + .probe = mlxbf_bootctl_probe,
> > > + .driver = {
> > > + .name = "mlxbf-bootctl",
> > > + .groups = mlxbf_bootctl_groups,
> > > + .acpi_match_table = mlxbf_bootctl_acpi_ids,
> >
> > Why is an acpi driver a platform driver? Isn't there a "real" acpi
> > driver interface you should be tieing into instead?
> >
> > Only use a platform driver as an absolute last resort. I don't think
> > that is the case here.
>
> The driver is trying to configure boot-swapping and display secure state,
> and is defined/initiated in ACPI table in UEFI. It seems a little hard to
> categorize this driver to any existing subsystem. Any suggestion
> where it might be a better fit (like drivers/misc, drivers/firmware, etc)?
> Please correct me if I misunderstand the comments. Thanks!.
The comment was asking why an acpi driver is a platform driver, but then
I went and looked now at a bunch of acpi drivers, and they all are
platform drivers :(
Anyway, drivers/acpi/ seems like the best place for this file, right?
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-20 19:12 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 20:59 [PATCH v1 1/1] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc Liming Sun
2019-01-29 22:03 ` Andy Shevchenko
2019-01-30 6:24 ` Vadim Pasternak
2019-01-30 20:56 ` Liming Sun
2019-01-30 20:47 ` Liming Sun
2019-01-30 21:17 ` Andy Shevchenko
2019-01-31 16:53 ` Liming Sun
2019-01-31 16:53 ` [PATCH v2] " Liming Sun
2019-01-31 17:02 ` Andy Shevchenko
2019-01-31 17:18 ` Liming Sun
2019-01-31 19:20 ` Liming Sun
2019-01-31 19:19 ` [PATCH v3] " Liming Sun
2019-02-01 5:16 ` [PATCH v1 1/1] " kbuild test robot
2019-02-01 5:16 ` kbuild test robot
2019-02-01 20:48 ` Liming Sun
2019-02-01 20:48 ` Liming Sun
2019-02-01 20:46 ` [PATCH v4] " Liming Sun
2019-02-05 17:21 ` Andy Shevchenko
2019-05-17 17:49 ` Liming Sun
2019-05-17 17:49 ` [PATCH v5 1/2] " Liming Sun
2019-05-20 15:56 ` Greg KH
2019-05-20 18:07 ` Liming Sun
2019-05-20 18:07 ` Liming Sun
2019-05-20 19:12 ` Greg KH [this message]
2019-05-20 19:12 ` Greg KH
2019-05-20 20:43 ` Liming Sun
2019-05-20 20:43 ` Liming Sun
2019-05-21 7:58 ` Arnd Bergmann
2019-05-21 7:58 ` Arnd Bergmann
2019-05-22 15:12 ` Liming Sun
2019-05-22 15:12 ` Liming Sun
2019-05-22 13:34 ` Mark Rutland
2019-05-22 14:51 ` Liming Sun
2019-05-22 14:51 ` Liming Sun
2019-05-17 17:49 ` [PATCH v5 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions Liming Sun
2019-05-17 17:59 ` Greg Kroah-Hartman
2019-05-17 20:36 ` Liming Sun
2019-05-17 20:36 ` Liming Sun
2019-05-18 6:35 ` Greg Kroah-Hartman
2019-05-18 6:35 ` Greg Kroah-Hartman
2019-05-20 15:20 ` Liming Sun
2019-05-20 15:20 ` Liming Sun
2019-05-20 15:53 ` Greg Kroah-Hartman
2019-05-20 15:53 ` Greg Kroah-Hartman
2019-10-07 15:48 ` [PATCH v6 1/2] platform/mellanox: Add bootctl driver for Mellanox BlueField Soc Liming Sun
2019-10-07 15:48 ` [PATCH v6 2/2] platform/mellanox/mlxbf-bootctl: Add the ABI definitions Liming Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520191209.GA29776@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=dwoods@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lsun@mellanox.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.