From: Viresh Kumar <viresh.kumar@linaro.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Anson Huang <anson.huang@nxp.com>, Abel Vesa <abel.vesa@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] cpufreq: Switch imx7d to imx-cpufreq-dt for speed grading
Date: Mon, 3 Jun 2019 12:41:08 +0530 [thread overview]
Message-ID: <20190603071108.toainiom76pth4qs@vireshk-i7> (raw)
In-Reply-To: <VI1PR04MB50551BDB2D0AA64D7192D98CEE140@VI1PR04MB5055.eurprd04.prod.outlook.com>
On 03-06-19, 07:01, Leonard Crestez wrote:
> On 6/3/2019 8:39 AM, Viresh Kumar wrote:
> > On 29-05-19, 12:03, Leonard Crestez wrote:
> >> This driver can handle speed grading bits on imx7d just like on imx8mq
> >> and imx8mm.
> >>
> >> diff --git a/drivers/cpufreq/imx-cpufreq-dt.c b/drivers/cpufreq/imx-cpufreq-dt.c
> >> index 5061503cb0a1..ce26ffc18ce6 100644
> >> --- a/drivers/cpufreq/imx-cpufreq-dt.c
> >> +++ b/drivers/cpufreq/imx-cpufreq-dt.c
> >> @@ -18,10 +18,11 @@
> >> #define OCOTP_CFG3_SPEED_GRADE_MASK (0x3 << 8)
> >> #define OCOTP_CFG3_MKT_SEGMENT_SHIFT 6
> >> #define OCOTP_CFG3_MKT_SEGMENT_MASK (0x3 << 6)
> >>
> >> static const struct of_device_id imx_cpufreq_dt_match_list[] = {
> >> + { .compatible = "fsl,imx7d" },
> >> { .compatible = "fsl,imx8mm" },
> >> { .compatible = "fsl,imx8mq" }, >> {}
> >> };
> >
> > What is the purpose of this array and can we get rid of it instead ? I am asking
> > as this driver gets probed only if the platform code has created the
> > imx-cpufreq-dt device and it shouldn't get created for other machines than what
> > is supported.
>
> Maybe it will be useful in the future to add .data here if a chip starts
> using 3 speed grading bits?
>
> It can be removed for now.
Yep, please remove it then for now. And it would be better to break the current
patch into arch and cpufreq part, so I can apply only the cpufreq parts easily.
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Aisheng Dong <aisheng.dong@nxp.com>, Jacky Bai <ping.bai@nxp.com>,
Anson Huang <anson.huang@nxp.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Abel Vesa <abel.vesa@nxp.com>
Subject: Re: [PATCH 3/3] cpufreq: Switch imx7d to imx-cpufreq-dt for speed grading
Date: Mon, 3 Jun 2019 12:41:08 +0530 [thread overview]
Message-ID: <20190603071108.toainiom76pth4qs@vireshk-i7> (raw)
In-Reply-To: <VI1PR04MB50551BDB2D0AA64D7192D98CEE140@VI1PR04MB5055.eurprd04.prod.outlook.com>
On 03-06-19, 07:01, Leonard Crestez wrote:
> On 6/3/2019 8:39 AM, Viresh Kumar wrote:
> > On 29-05-19, 12:03, Leonard Crestez wrote:
> >> This driver can handle speed grading bits on imx7d just like on imx8mq
> >> and imx8mm.
> >>
> >> diff --git a/drivers/cpufreq/imx-cpufreq-dt.c b/drivers/cpufreq/imx-cpufreq-dt.c
> >> index 5061503cb0a1..ce26ffc18ce6 100644
> >> --- a/drivers/cpufreq/imx-cpufreq-dt.c
> >> +++ b/drivers/cpufreq/imx-cpufreq-dt.c
> >> @@ -18,10 +18,11 @@
> >> #define OCOTP_CFG3_SPEED_GRADE_MASK (0x3 << 8)
> >> #define OCOTP_CFG3_MKT_SEGMENT_SHIFT 6
> >> #define OCOTP_CFG3_MKT_SEGMENT_MASK (0x3 << 6)
> >>
> >> static const struct of_device_id imx_cpufreq_dt_match_list[] = {
> >> + { .compatible = "fsl,imx7d" },
> >> { .compatible = "fsl,imx8mm" },
> >> { .compatible = "fsl,imx8mq" }, >> {}
> >> };
> >
> > What is the purpose of this array and can we get rid of it instead ? I am asking
> > as this driver gets probed only if the platform code has created the
> > imx-cpufreq-dt device and it shouldn't get created for other machines than what
> > is supported.
>
> Maybe it will be useful in the future to add .data here if a chip starts
> using 3 speed grading bits?
>
> It can be removed for now.
Yep, please remove it then for now. And it would be better to break the current
patch into arch and cpufreq part, so I can apply only the cpufreq parts easily.
--
viresh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-03 7:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:03 [PATCH 1/3] ARM: dts: imx7d: Update cpufreq OPP table Leonard Crestez
2019-05-29 12:03 ` Leonard Crestez
2019-05-29 12:03 ` [PATCH 2/3] ARM: imx_v6_v7_defconfig: Enable CONFIG_ARM_IMX_CPUFREQ_DT Leonard Crestez
2019-05-29 12:03 ` Leonard Crestez
2019-05-29 12:03 ` [PATCH 3/3] cpufreq: Switch imx7d to imx-cpufreq-dt for speed grading Leonard Crestez
2019-05-29 12:03 ` Leonard Crestez
2019-06-03 5:38 ` Viresh Kumar
2019-06-03 5:38 ` Viresh Kumar
2019-06-03 7:01 ` Leonard Crestez
2019-06-03 7:01 ` Leonard Crestez
2019-06-03 7:11 ` Viresh Kumar [this message]
2019-06-03 7:11 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190603071108.toainiom76pth4qs@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.