From: Lee Jones <lee.jones@linaro.org> To: Johan Hovold <johan@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>, balbi@kernel.org, wsa+renesas@sang-engineering.com, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, david.brown@linaro.org, alokc@codeaurora.org, kramasub@codeaurora.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, jlhugo@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Date: Wed, 5 Jun 2019 09:20:47 +0100 [thread overview] Message-ID: <20190605082047.GM4797@dell> (raw) In-Reply-To: <20190605075656.GC29637@localhost> On Wed, 05 Jun 2019, Johan Hovold wrote: > On Wed, Jun 05, 2019 at 08:16:25AM +0100, Lee Jones wrote: > > On Tue, 04 Jun 2019, Bjorn Andersson wrote: > > > > > On Tue 04 Jun 03:44 PDT 2019, Lee Jones wrote: > > > > > > > The Qualcomm Geni I2C driver currently probes silently which can be > > > > confusing when debugging potential issues. Add a low level (INFO) > > > > print when each I2C controller is successfully initially set-up. > > > > > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > --- > > > > drivers/i2c/busses/i2c-qcom-geni.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > > > > index 0fa93b448e8d..e27466d77767 100644 > > > > --- a/drivers/i2c/busses/i2c-qcom-geni.c > > > > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > > > > @@ -598,6 +598,8 @@ static int geni_i2c_probe(struct platform_device *pdev) > > > > return ret; > > > > } > > > > > > > > + dev_info(&pdev->dev, "Geni-I2C adaptor successfully added\n"); > > > > + > > > > > > I would prefer that we do not add such prints, as it would be to accept > > > the downstream behaviour of spamming the log to the point where no one > > > will ever look through it. > > > > We should be able to find a middle ground. Spamming the log with all > > sorts of device specific information/debug is obviously not > > constructive, but a single liner to advertise that an important > > device/controller has been successfully initialised is more helpful > > than it is hinderous. > > > > This print was added due to the silent initialisation costing me > > several hours of debugging ACPI device/driver code (albeit learning a > > lot about ACPI as I go) just to find out that it was already doing the > > right thing - just very quietly. > > No, we don't add noise like this to the logs just because it may be > useful while debugging. Even one-liners add up. One line per device is should not cause an issue. Problems occur when developers try to print all kinds of device specifics to the boot log. A simple, single line for such an important device/controller has more benefits than drawbacks. > There are plenty of options for debugging already ranging from adding a > temporary dev_info() to the probe function in question to using dynamic > debugging to have driver core log every successful probe. This is what I ended up doing. It was time consuming to parse though a log of that size when you have no paging or keyboard. > And in this case you say the driver was in fact already bound; that can > easily be verified through sysfs too in case things aren't behaving the > way you expect. Not in a non-booting system with no keyboard you can't. ;) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Johan Hovold <johan@kernel.org> Cc: balbi@kernel.org, david.brown@linaro.org, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>, wsa+renesas@sang-engineering.com, alokc@codeaurora.org, kramasub@codeaurora.org, linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, jlhugo@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Date: Wed, 5 Jun 2019 09:20:47 +0100 [thread overview] Message-ID: <20190605082047.GM4797@dell> (raw) In-Reply-To: <20190605075656.GC29637@localhost> On Wed, 05 Jun 2019, Johan Hovold wrote: > On Wed, Jun 05, 2019 at 08:16:25AM +0100, Lee Jones wrote: > > On Tue, 04 Jun 2019, Bjorn Andersson wrote: > > > > > On Tue 04 Jun 03:44 PDT 2019, Lee Jones wrote: > > > > > > > The Qualcomm Geni I2C driver currently probes silently which can be > > > > confusing when debugging potential issues. Add a low level (INFO) > > > > print when each I2C controller is successfully initially set-up. > > > > > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > > --- > > > > drivers/i2c/busses/i2c-qcom-geni.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > > > > index 0fa93b448e8d..e27466d77767 100644 > > > > --- a/drivers/i2c/busses/i2c-qcom-geni.c > > > > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > > > > @@ -598,6 +598,8 @@ static int geni_i2c_probe(struct platform_device *pdev) > > > > return ret; > > > > } > > > > > > > > + dev_info(&pdev->dev, "Geni-I2C adaptor successfully added\n"); > > > > + > > > > > > I would prefer that we do not add such prints, as it would be to accept > > > the downstream behaviour of spamming the log to the point where no one > > > will ever look through it. > > > > We should be able to find a middle ground. Spamming the log with all > > sorts of device specific information/debug is obviously not > > constructive, but a single liner to advertise that an important > > device/controller has been successfully initialised is more helpful > > than it is hinderous. > > > > This print was added due to the silent initialisation costing me > > several hours of debugging ACPI device/driver code (albeit learning a > > lot about ACPI as I go) just to find out that it was already doing the > > right thing - just very quietly. > > No, we don't add noise like this to the logs just because it may be > useful while debugging. Even one-liners add up. One line per device is should not cause an issue. Problems occur when developers try to print all kinds of device specifics to the boot log. A simple, single line for such an important device/controller has more benefits than drawbacks. > There are plenty of options for debugging already ranging from adding a > temporary dev_info() to the probe function in question to using dynamic > debugging to have driver core log every successful probe. This is what I ended up doing. It was time consuming to parse though a log of that size when you have no paging or keyboard. > And in this case you say the driver was in fact already bound; that can > easily be verified through sysfs too in case things aren't behaving the > way you expect. Not in a non-booting system with no keyboard you can't. ;) -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-05 8:20 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-04 10:44 [PATCH 1/8] i2c: i2c-qcom-geni: Provide support for ACPI Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-04 10:44 ` [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 6:20 ` Bjorn Andersson 2019-06-05 6:20 ` Bjorn Andersson 2019-06-05 7:16 ` Lee Jones 2019-06-05 7:16 ` Lee Jones 2019-06-05 7:22 ` Ard Biesheuvel 2019-06-05 7:22 ` Ard Biesheuvel 2019-06-05 8:23 ` Lee Jones 2019-06-05 8:23 ` Lee Jones 2019-06-05 7:56 ` Johan Hovold 2019-06-05 7:56 ` Johan Hovold 2019-06-05 8:20 ` Lee Jones [this message] 2019-06-05 8:20 ` Lee Jones 2019-06-05 8:33 ` Johan Hovold 2019-06-05 8:33 ` Johan Hovold 2019-06-05 8:49 ` Lee Jones 2019-06-05 8:49 ` Lee Jones 2019-06-05 8:55 ` Johan Hovold 2019-06-05 8:55 ` Johan Hovold 2019-06-05 14:18 ` Wolfram Sang 2019-06-05 14:18 ` Wolfram Sang 2019-06-05 18:49 ` Lee Jones 2019-06-05 18:49 ` Lee Jones 2019-06-12 14:54 ` Johan Hovold 2019-06-12 14:54 ` Johan Hovold 2019-06-04 10:44 ` [PATCH 3/8] pinctrl: msm: Add ability for drivers to supply a reserved GPIO list Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-04 10:44 ` [PATCH 4/8] pinctrl: qcom: sdm845: Provide ACPI support Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 6:17 ` Bjorn Andersson 2019-06-05 6:17 ` Bjorn Andersson 2019-06-05 7:31 ` Lee Jones 2019-06-05 7:31 ` Lee Jones 2019-06-05 19:06 ` Bjorn Andersson 2019-06-05 19:06 ` Bjorn Andersson 2019-06-05 19:35 ` Lee Jones 2019-06-05 19:35 ` Lee Jones 2019-06-04 10:44 ` [PATCH 5/8] soc: qcom: geni: Add support for ACPI Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-04 10:44 ` [PATCH 6/8] usb: dwc3: qcom: Add support for booting with ACPI Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 6:35 ` Bjorn Andersson 2019-06-05 6:35 ` Bjorn Andersson 2019-06-05 7:09 ` Lee Jones 2019-06-05 7:09 ` Lee Jones 2019-06-05 9:55 ` Lee Jones 2019-06-05 9:55 ` Lee Jones 2019-06-04 10:44 ` [PATCH 7/8] usb: dwc3: qcom: Start USB in 'host mode' on the SDM845 Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 7:00 ` Bjorn Andersson 2019-06-05 7:00 ` Bjorn Andersson 2019-06-05 8:34 ` Lee Jones 2019-06-05 8:34 ` Lee Jones 2019-06-05 14:07 ` Jeffrey Hugo 2019-06-05 14:07 ` Jeffrey Hugo 2019-06-05 18:50 ` Lee Jones 2019-06-05 18:50 ` Lee Jones 2019-06-05 19:14 ` Bjorn Andersson 2019-06-05 19:14 ` Bjorn Andersson 2019-06-05 19:29 ` Lee Jones 2019-06-05 19:29 ` Lee Jones 2019-06-04 10:44 ` [PATCH 8/8] usb: dwc3: qcom: Improve error handling Lee Jones 2019-06-04 10:44 ` Lee Jones 2019-06-05 7:03 ` Bjorn Andersson 2019-06-05 7:03 ` Bjorn Andersson 2019-06-05 11:42 [PATCH 1/8] i2c: i2c-qcom-geni: Provide support for ACPI Lee Jones 2019-06-05 11:42 ` [PATCH 2/8] i2c: i2c-qcom-geni: Signify successful driver probe Lee Jones 2019-06-05 11:42 ` Lee Jones 2019-06-05 11:42 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190605082047.GM4797@dell \ --to=lee.jones@linaro.org \ --cc=alokc@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=balbi@kernel.org \ --cc=bjorn.andersson@linaro.org \ --cc=david.brown@linaro.org \ --cc=gregkh@linuxfoundation.org \ --cc=jlhugo@gmail.com \ --cc=johan@kernel.org \ --cc=kramasub@codeaurora.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.