From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Alan Stern <stern@rowland.harvard.edu> Cc: David Howells <dhowells@redhat.com>, viro@zeniv.linux.org.uk, linux-usb@vger.kernel.org, raven@themaw.net, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-block@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] usb: Add USB subsystem notifications [ver #3] Date: Thu, 6 Jun 2019 17:31:50 +0200 [thread overview] Message-ID: <20190606153150.GB28997@kroah.com> (raw) In-Reply-To: <Pine.LNX.4.44L0.1906061051310.1641-100000@iolanthe.rowland.org> On Thu, Jun 06, 2019 at 10:55:24AM -0400, Alan Stern wrote: > On Thu, 6 Jun 2019, Greg Kroah-Hartman wrote: > > > On Thu, Jun 06, 2019 at 10:24:18AM -0400, Alan Stern wrote: > > > On Thu, 6 Jun 2019, David Howells wrote: > > > > > > > Add a USB subsystem notification mechanism whereby notifications about > > > > hardware events such as device connection, disconnection, reset and I/O > > > > errors, can be reported to a monitoring process asynchronously. > > > > > > USB I/O errors covers an awfully large and vague field. Do we really > > > want to include them? I'm doubtful. > > > > See the other patch on the linux-usb list that wanted to start adding > > KOBJ_CHANGE notifications about USB "i/o errors". > > That patch wanted to add notifications only for enumeration failures > (assuming you're talking about the patch from Eugeniu Rosca), not I/O > errors in general. Yes, sorry, I was thinking that as a "I/O failed in enumeration" :) > > So for "severe" issues, yes, we should do this, but perhaps not for all > > of the "normal" things we see when a device is yanked out of the system > > and the like. > > Then what counts as a "severe" issue? Anything besides enumeration > failure? Not that I can think of at the moment, other than the other recently added KOBJ_CHANGE issue. I'm sure we have other "hard failure" issues in the USB stack that people will want exposed over time. thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: Alan Stern <stern@rowland.harvard.edu> Cc: David Howells <dhowells@redhat.com>, viro@zeniv.linux.org.uk, linux-usb@vger.kernel.org, raven@themaw.net, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-block@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] usb: Add USB subsystem notifications [ver #3] Date: Thu, 06 Jun 2019 15:31:50 +0000 [thread overview] Message-ID: <20190606153150.GB28997@kroah.com> (raw) In-Reply-To: <Pine.LNX.4.44L0.1906061051310.1641-100000@iolanthe.rowland.org> On Thu, Jun 06, 2019 at 10:55:24AM -0400, Alan Stern wrote: > On Thu, 6 Jun 2019, Greg Kroah-Hartman wrote: > > > On Thu, Jun 06, 2019 at 10:24:18AM -0400, Alan Stern wrote: > > > On Thu, 6 Jun 2019, David Howells wrote: > > > > > > > Add a USB subsystem notification mechanism whereby notifications about > > > > hardware events such as device connection, disconnection, reset and I/O > > > > errors, can be reported to a monitoring process asynchronously. > > > > > > USB I/O errors covers an awfully large and vague field. Do we really > > > want to include them? I'm doubtful. > > > > See the other patch on the linux-usb list that wanted to start adding > > KOBJ_CHANGE notifications about USB "i/o errors". > > That patch wanted to add notifications only for enumeration failures > (assuming you're talking about the patch from Eugeniu Rosca), not I/O > errors in general. Yes, sorry, I was thinking that as a "I/O failed in enumeration" :) > > So for "severe" issues, yes, we should do this, but perhaps not for all > > of the "normal" things we see when a device is yanked out of the system > > and the like. > > Then what counts as a "severe" issue? Anything besides enumeration > failure? Not that I can think of at the moment, other than the other recently added KOBJ_CHANGE issue. I'm sure we have other "hard failure" issues in the USB stack that people will want exposed over time. thanks, greg k-h
next prev parent reply other threads:[~2019-06-06 15:31 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-06 9:41 [RFC][PATCH 00/10] Mount, FS, Block and Keyrings notifications [ver #3] David Howells 2019-06-06 9:41 ` David Howells 2019-06-06 9:42 ` [PATCH 01/10] security: Override creds in __fput() with last fputter's creds " David Howells 2019-06-06 9:42 ` David Howells 2019-06-06 9:42 ` David Howells 2019-06-06 14:57 ` Andy Lutomirski 2019-06-06 14:57 ` Andy Lutomirski 2019-06-06 15:06 ` David Howells 2019-06-06 15:06 ` David Howells 2019-06-06 17:18 ` Andy Lutomirski 2019-06-06 17:18 ` Andy Lutomirski 2019-06-06 19:09 ` Casey Schaufler 2019-06-06 19:09 ` Casey Schaufler 2019-06-06 19:34 ` Andy Lutomirski 2019-06-06 19:34 ` Andy Lutomirski 2019-06-06 9:42 ` [PATCH 02/10] General notification queue with user mmap()'able ring buffer " David Howells 2019-06-06 9:42 ` David Howells 2019-06-06 9:42 ` [PATCH 03/10] keys: Add a notification facility " David Howells 2019-06-06 9:42 ` David Howells 2019-06-06 9:42 ` [PATCH 04/10] vfs: Add a mount-notification " David Howells 2019-06-06 9:42 ` David Howells 2019-06-06 9:42 ` [PATCH 05/10] vfs: Add superblock notifications " David Howells 2019-06-06 9:42 ` David Howells 2019-06-06 9:42 ` [PATCH 06/10] fsinfo: Export superblock notification counter " David Howells 2019-06-06 9:42 ` David Howells 2019-06-06 9:43 ` [PATCH 07/10] Add a general, global device notification watch list " David Howells 2019-06-06 9:43 ` David Howells 2019-06-06 9:43 ` [PATCH 08/10] block: Add block layer notifications " David Howells 2019-06-06 9:43 ` David Howells 2019-06-06 9:43 ` [PATCH 09/10] usb: Add USB subsystem " David Howells 2019-06-06 9:43 ` David Howells 2019-06-06 14:24 ` Alan Stern 2019-06-06 14:24 ` Alan Stern 2019-06-06 14:24 ` Alan Stern 2019-06-06 14:33 ` Greg Kroah-Hartman 2019-06-06 14:33 ` Greg Kroah-Hartman 2019-06-06 14:55 ` Alan Stern 2019-06-06 14:55 ` Alan Stern 2019-06-06 14:55 ` Alan Stern 2019-06-06 15:31 ` Greg Kroah-Hartman [this message] 2019-06-06 15:31 ` Greg Kroah-Hartman 2019-06-07 6:40 ` Felipe Balbi 2019-06-07 6:40 ` Felipe Balbi 2019-06-07 14:01 ` Alan Stern 2019-06-07 14:01 ` Alan Stern 2019-06-07 14:01 ` Alan Stern 2019-06-11 6:28 ` Felipe Balbi 2019-06-11 6:28 ` Felipe Balbi 2019-06-11 13:53 ` Alan Stern 2019-06-11 13:53 ` Alan Stern 2019-06-11 13:53 ` Alan Stern 2019-06-12 6:58 ` Felipe Balbi 2019-06-12 6:58 ` Felipe Balbi 2019-06-06 9:43 ` [PATCH 10/10] Add sample notification program " David Howells 2019-06-06 9:43 ` David Howells 2019-06-06 21:21 ` Eugeniu Rosca 2019-06-06 21:21 ` Eugeniu Rosca 2019-06-06 21:21 ` Eugeniu Rosca 2019-06-06 22:52 ` David Howells 2019-06-06 22:52 ` David Howells 2019-06-07 14:37 ` David Howells 2019-06-07 14:37 ` David Howells 2019-06-06 12:32 ` [RFC][PATCH 00/10] Mount, FS, Block and Keyrings notifications " Stephen Smalley 2019-06-06 12:32 ` Stephen Smalley 2019-06-06 13:16 ` David Howells 2019-06-06 13:16 ` David Howells 2019-06-06 14:05 ` Stephen Smalley 2019-06-06 14:05 ` Stephen Smalley 2019-06-06 16:43 ` Casey Schaufler 2019-06-06 16:43 ` Casey Schaufler 2019-06-06 17:11 ` Andy Lutomirski 2019-06-06 17:11 ` Andy Lutomirski 2019-06-06 18:33 ` Casey Schaufler 2019-06-06 18:33 ` Casey Schaufler 2019-06-06 18:51 ` Andy Lutomirski 2019-06-06 18:51 ` Andy Lutomirski 2019-06-06 17:16 ` Stephen Smalley 2019-06-06 17:16 ` Stephen Smalley 2019-06-06 18:56 ` Casey Schaufler 2019-06-06 18:56 ` Casey Schaufler 2019-06-06 19:54 ` Andy Lutomirski 2019-06-06 19:54 ` Andy Lutomirski 2019-06-06 21:17 ` David Howells 2019-06-06 21:17 ` David Howells 2019-06-06 21:54 ` Andy Lutomirski 2019-06-06 21:54 ` Andy Lutomirski 2019-06-06 22:38 ` David Howells 2019-06-06 22:38 ` David Howells 2019-06-06 22:42 ` Andy Lutomirski 2019-06-06 22:42 ` Andy Lutomirski 2019-06-06 22:50 ` David Howells 2019-06-06 22:50 ` David Howells 2019-06-06 14:34 ` Christian Brauner 2019-06-06 14:34 ` Christian Brauner
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190606153150.GB28997@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=dhowells@redhat.com \ --cc=keyrings@vger.kernel.org \ --cc=linux-api@vger.kernel.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=raven@themaw.net \ --cc=stern@rowland.harvard.edu \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.