From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
axboe@fb.com, Matias Bjorling <mb@lightnvm.io>,
linux-block@vger.kernel.org
Subject: Re: [PATCH 3/6] block: remove the bi_phys_segments field in struct bio
Date: Fri, 7 Jun 2019 18:45:32 +0200 [thread overview]
Message-ID: <20190607164532.GD7307@lst.de> (raw)
In-Reply-To: <481003ba-aa95-0d0e-ba1f-ce48f2c61105@suse.de>
On Fri, Jun 07, 2019 at 08:02:55AM +0200, Hannes Reinecke wrote:
> > +void blk_queue_split(struct request_queue *q, struct bio **bio)
> > +{
> > + unsigned int nr_segs;
> > +
> > + __blk_queue_split(q, bio, &nr_segs);
> > +}
> > EXPORT_SYMBOL(blk_queue_split);
> >
> That looks a bit weird, and I guess some or other compiler might
> complain here about nr_segs being unused.
> Can't we modify __blk_queue_split() to accept a NULL argument here?
We could. But that would bloat the fast path for absolutely no
reason. Passing a by reference output argument that is then ignored
is a pretty common pattern.
next prev parent reply other threads:[~2019-06-07 16:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 10:28 remove bi_phys_segments and related cleanups Christoph Hellwig
2019-06-06 10:28 ` [PATCH 1/6] block: initialize the write priority in blk_rq_bio_prep Christoph Hellwig
2019-06-07 5:58 ` Hannes Reinecke
2019-06-07 12:20 ` Minwoo Im
2019-06-20 13:40 ` Minwoo Im
2019-06-06 10:29 ` [PATCH 2/6] block: remove blk_init_request_from_bio Christoph Hellwig
2019-06-07 5:59 ` Hannes Reinecke
2019-06-07 12:23 ` Minwoo Im
2019-06-07 12:57 ` Javier González
2019-06-09 19:51 ` Matias Bjørling
2019-06-06 10:29 ` [PATCH 3/6] block: remove the bi_phys_segments field in struct bio Christoph Hellwig
2019-06-07 6:02 ` Hannes Reinecke
2019-06-07 16:45 ` Christoph Hellwig [this message]
2019-06-09 22:17 ` Nikolay Borisov
2019-06-10 18:30 ` Bart Van Assche
2019-06-06 10:29 ` [PATCH 4/6] block: simplify blk_recalc_rq_segments Christoph Hellwig
2019-06-07 6:03 ` Hannes Reinecke
2019-06-06 10:29 ` [PATCH 5/6] block: untangle the end of blk_bio_segment_split Christoph Hellwig
2019-06-07 6:04 ` Hannes Reinecke
2019-06-06 10:29 ` [PATCH 6/6] block: mark blk_rq_bio_prep as inline Christoph Hellwig
2019-06-07 6:04 ` Hannes Reinecke
2019-06-20 9:44 ` remove bi_phys_segments and related cleanups Christoph Hellwig
2019-06-20 16:33 ` Jens Axboe
2019-07-01 16:46 ` Jens Axboe
2019-07-02 13:34 ` Christoph Hellwig
[not found] ` <bfe8a4b5-901e-5ac4-e11c-0e6ccc4faec2@kernel.dk>
2019-07-02 18:29 ` Christoph Hellwig
2019-07-02 18:37 ` Jens Axboe
2019-07-03 0:00 ` Christoph Hellwig
2019-07-03 1:10 ` Jens Axboe
2019-07-03 1:32 ` Jens Axboe
2019-07-03 1:35 ` Christoph Hellwig
2019-07-03 12:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607164532.GD7307@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.