From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Matias Bjorling <mb@lightnvm.io>,
linux-block@vger.kernel.org
Subject: Re: remove bi_phys_segments and related cleanups
Date: Wed, 3 Jul 2019 02:00:55 +0200 [thread overview]
Message-ID: <20190703000055.GA28981@lst.de> (raw)
In-Reply-To: <ef4a5fb5-9d79-75e1-1231-fdfc14f91835@kernel.dk>
On Tue, Jul 02, 2019 at 12:37:59PM -0600, Jens Axboe wrote:
> > I couldn't get that to boot in my test systems even with mainline,
> > but that seems to be do to systemd waiting for some crap not supported
> > in the config.
> >
> > But with my usual test config I've just completed a test run with
> > KASAN enabled on a VWC=1 driver with no issues, so this keeps puzzling
> > me.
>
> Let me know what you want me to try. I can't reproduce it in qemu, but
> it's 100% on my laptop. My qemu drives also have VWC=1, so it's not
> (just) that.
I seriously have no idea unfortunately. It works fine for me both
on qemu and on a real WD SN720 drive on my laptop. Just for curiosity
you could try to pad the bio structure and see if bloating it to the
old size makes any difference.
The other things that comes to mind is that when Johannes removed
BIO_SEG_VALID there also were some unexplainable side effects,
I'll look into seeing if there was any similarity.
next prev parent reply other threads:[~2019-07-03 0:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 10:28 remove bi_phys_segments and related cleanups Christoph Hellwig
2019-06-06 10:28 ` [PATCH 1/6] block: initialize the write priority in blk_rq_bio_prep Christoph Hellwig
2019-06-07 5:58 ` Hannes Reinecke
2019-06-07 12:20 ` Minwoo Im
2019-06-20 13:40 ` Minwoo Im
2019-06-06 10:29 ` [PATCH 2/6] block: remove blk_init_request_from_bio Christoph Hellwig
2019-06-07 5:59 ` Hannes Reinecke
2019-06-07 12:23 ` Minwoo Im
2019-06-07 12:57 ` Javier González
2019-06-09 19:51 ` Matias Bjørling
2019-06-06 10:29 ` [PATCH 3/6] block: remove the bi_phys_segments field in struct bio Christoph Hellwig
2019-06-07 6:02 ` Hannes Reinecke
2019-06-07 16:45 ` Christoph Hellwig
2019-06-09 22:17 ` Nikolay Borisov
2019-06-10 18:30 ` Bart Van Assche
2019-06-06 10:29 ` [PATCH 4/6] block: simplify blk_recalc_rq_segments Christoph Hellwig
2019-06-07 6:03 ` Hannes Reinecke
2019-06-06 10:29 ` [PATCH 5/6] block: untangle the end of blk_bio_segment_split Christoph Hellwig
2019-06-07 6:04 ` Hannes Reinecke
2019-06-06 10:29 ` [PATCH 6/6] block: mark blk_rq_bio_prep as inline Christoph Hellwig
2019-06-07 6:04 ` Hannes Reinecke
2019-06-20 9:44 ` remove bi_phys_segments and related cleanups Christoph Hellwig
2019-06-20 16:33 ` Jens Axboe
2019-07-01 16:46 ` Jens Axboe
2019-07-02 13:34 ` Christoph Hellwig
[not found] ` <bfe8a4b5-901e-5ac4-e11c-0e6ccc4faec2@kernel.dk>
2019-07-02 18:29 ` Christoph Hellwig
2019-07-02 18:37 ` Jens Axboe
2019-07-03 0:00 ` Christoph Hellwig [this message]
2019-07-03 1:10 ` Jens Axboe
2019-07-03 1:32 ` Jens Axboe
2019-07-03 1:35 ` Christoph Hellwig
2019-07-03 12:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703000055.GA28981@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=mb@lightnvm.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.