From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
shaggy@kernel.org, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca,
jk@ozlabs.org, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, viro@zeniv.linux.org.uk,
linux-xfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: Re: [Jfs-discussion] [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS
Date: Tue, 11 Jun 2019 17:35:38 -0700 [thread overview]
Message-ID: <20190612003538.GW1871505@magnolia> (raw)
In-Reply-To: <fb974a33-2192-30ab-9f31-885c3796360b@oracle.com>
On Tue, Jun 11, 2019 at 08:41:06AM -0500, Dave Kleikamp wrote:
> On 6/10/19 11:45 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag
> > values so that we can standardize the implementations that follow ext4's
> > flag values.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> -- clip --
>
> > diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> > index ba34dae8bd9f..c8446d2cd0c7 100644
> > --- a/fs/jfs/ioctl.c
> > +++ b/fs/jfs/ioctl.c
> > @@ -98,6 +98,12 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> > /* Lock against other parallel changes of flags */
> > inode_lock(inode);
> >
> > + oldflags = jfs_map_ext2(jfs_inode->mode2 & JFS_FL_USER_VISIBLE,
> > + 0);
> > + err = vfs_ioc_setflags_check(inode, oldflags, flags);
> > + if (err)
> > + goto setflags_out;
>
> inode_unlock(inode) is not called on the error path.
>
> > +
> > oldflags = jfs_inode->mode2;
> >
> > /*
>
> This patch leaves jfs's open-coded version of the same check.
Heh, thanks for pointing that out. I'll fix both of those things.
--D
> Thanks,
> Shaggy
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: matthew.garrett@nebula.com, yuchao0@huawei.com, tytso@mit.edu,
shaggy@kernel.org, ard.biesheuvel@linaro.org,
josef@toxicpanda.com, clm@fb.com, adilger.kernel@dilger.ca,
jk@ozlabs.org, jack@suse.com, dsterba@suse.com,
jaegeuk@kernel.org, viro@zeniv.linux.org.uk,
linux-xfs@vger.kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
reiserfs-devel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com,
linux-nilfs@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [Jfs-discussion] [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS
Date: Tue, 11 Jun 2019 17:35:38 -0700 [thread overview]
Message-ID: <20190612003538.GW1871505@magnolia> (raw)
In-Reply-To: <fb974a33-2192-30ab-9f31-885c3796360b@oracle.com>
On Tue, Jun 11, 2019 at 08:41:06AM -0500, Dave Kleikamp wrote:
> On 6/10/19 11:45 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag
> > values so that we can standardize the implementations that follow ext4's
> > flag values.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> -- clip --
>
> > diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> > index ba34dae8bd9f..c8446d2cd0c7 100644
> > --- a/fs/jfs/ioctl.c
> > +++ b/fs/jfs/ioctl.c
> > @@ -98,6 +98,12 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> > /* Lock against other parallel changes of flags */
> > inode_lock(inode);
> >
> > + oldflags = jfs_map_ext2(jfs_inode->mode2 & JFS_FL_USER_VISIBLE,
> > + 0);
> > + err = vfs_ioc_setflags_check(inode, oldflags, flags);
> > + if (err)
> > + goto setflags_out;
>
> inode_unlock(inode) is not called on the error path.
>
> > +
> > oldflags = jfs_inode->mode2;
> >
> > /*
>
> This patch leaves jfs's open-coded version of the same check.
Heh, thanks for pointing that out. I'll fix both of those things.
--D
> Thanks,
> Shaggy
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, yuchao0@huawei.com, clm@fb.com,
adilger.kernel@dilger.ca, ocfs2-devel@oss.oracle.com,
matthew.garrett@nebula.com, linux-nilfs@vger.kernel.org,
cluster-devel@redhat.com, linux-ext4@vger.kernel.org,
reiserfs-devel@vger.kernel.org, josef@toxicpanda.com,
viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org,
tytso@mit.edu, ard.biesheuvel@linaro.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, jk@ozlabs.org, jack@suse.com,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS
Date: Tue, 11 Jun 2019 17:35:38 -0700 [thread overview]
Message-ID: <20190612003538.GW1871505@magnolia> (raw)
In-Reply-To: <fb974a33-2192-30ab-9f31-885c3796360b@oracle.com>
On Tue, Jun 11, 2019 at 08:41:06AM -0500, Dave Kleikamp wrote:
> On 6/10/19 11:45 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag
> > values so that we can standardize the implementations that follow ext4's
> > flag values.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> -- clip --
>
> > diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> > index ba34dae8bd9f..c8446d2cd0c7 100644
> > --- a/fs/jfs/ioctl.c
> > +++ b/fs/jfs/ioctl.c
> > @@ -98,6 +98,12 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> > /* Lock against other parallel changes of flags */
> > inode_lock(inode);
> >
> > + oldflags = jfs_map_ext2(jfs_inode->mode2 & JFS_FL_USER_VISIBLE,
> > + 0);
> > + err = vfs_ioc_setflags_check(inode, oldflags, flags);
> > + if (err)
> > + goto setflags_out;
>
> inode_unlock(inode) is not called on the error path.
>
> > +
> > oldflags = jfs_inode->mode2;
> >
> > /*
>
> This patch leaves jfs's open-coded version of the same check.
Heh, thanks for pointing that out. I'll fix both of those things.
--D
> Thanks,
> Shaggy
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, clm@fb.com, adilger.kernel@dilger.ca,
ocfs2-devel@oss.oracle.com, matthew.garrett@nebula.com,
linux-nilfs@vger.kernel.org, cluster-devel@redhat.com,
linux-ext4@vger.kernel.org, reiserfs-devel@vger.kernel.org,
josef@toxicpanda.com, viro@zeniv.linux.org.uk, dsterba@suse.com,
jaegeuk@kernel.org, tytso@mit.edu, ard.biesheuvel@linaro.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, jk@ozlabs.org, jack@suse.com,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org
Subject: Re: [f2fs-dev] [Jfs-discussion] [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS
Date: Tue, 11 Jun 2019 17:35:38 -0700 [thread overview]
Message-ID: <20190612003538.GW1871505@magnolia> (raw)
Message-ID: <20190612003538.Lntn_4ZI7Fv_o6WRuhKXsINbOgxp-Tyzah7rHHDI3aU@z> (raw)
In-Reply-To: <fb974a33-2192-30ab-9f31-885c3796360b@oracle.com>
On Tue, Jun 11, 2019 at 08:41:06AM -0500, Dave Kleikamp wrote:
> On 6/10/19 11:45 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag
> > values so that we can standardize the implementations that follow ext4's
> > flag values.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> -- clip --
>
> > diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> > index ba34dae8bd9f..c8446d2cd0c7 100644
> > --- a/fs/jfs/ioctl.c
> > +++ b/fs/jfs/ioctl.c
> > @@ -98,6 +98,12 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> > /* Lock against other parallel changes of flags */
> > inode_lock(inode);
> >
> > + oldflags = jfs_map_ext2(jfs_inode->mode2 & JFS_FL_USER_VISIBLE,
> > + 0);
> > + err = vfs_ioc_setflags_check(inode, oldflags, flags);
> > + if (err)
> > + goto setflags_out;
>
> inode_unlock(inode) is not called on the error path.
>
> > +
> > oldflags = jfs_inode->mode2;
> >
> > /*
>
> This patch leaves jfs's open-coded version of the same check.
Heh, thanks for pointing that out. I'll fix both of those things.
--D
> Thanks,
> Shaggy
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Cc: shaggy@kernel.org, jfs-discussion@lists.sourceforge.net,
linux-efi@vger.kernel.org, yuchao0@huawei.com, clm@fb.com,
adilger.kernel@dilger.ca, ocfs2-devel@oss.oracle.com,
matthew.garrett@nebula.com, linux-nilfs@vger.kernel.org,
cluster-devel@redhat.com, linux-ext4@vger.kernel.org,
reiserfs-devel@vger.kernel.org, josef@toxicpanda.com,
viro@zeniv.linux.org.uk, dsterba@suse.com, jaegeuk@kernel.org,
tytso@mit.edu, ard.biesheuvel@linaro.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-xfs@vger.kernel.org, jk@ozlabs.org, jack@suse.com,
linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-btrfs@vger.kernel.org
Subject: Re: [Jfs-discussion] [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS
Date: Tue, 11 Jun 2019 17:35:38 -0700 [thread overview]
Message-ID: <20190612003538.GW1871505@magnolia> (raw)
In-Reply-To: <fb974a33-2192-30ab-9f31-885c3796360b@oracle.com>
On Tue, Jun 11, 2019 at 08:41:06AM -0500, Dave Kleikamp wrote:
> On 6/10/19 11:45 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag
> > values so that we can standardize the implementations that follow ext4's
> > flag values.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> -- clip --
>
> > diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> > index ba34dae8bd9f..c8446d2cd0c7 100644
> > --- a/fs/jfs/ioctl.c
> > +++ b/fs/jfs/ioctl.c
> > @@ -98,6 +98,12 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> > /* Lock against other parallel changes of flags */
> > inode_lock(inode);
> >
> > + oldflags = jfs_map_ext2(jfs_inode->mode2 & JFS_FL_USER_VISIBLE,
> > + 0);
> > + err = vfs_ioc_setflags_check(inode, oldflags, flags);
> > + if (err)
> > + goto setflags_out;
>
> inode_unlock(inode) is not called on the error path.
>
> > +
> > oldflags = jfs_inode->mode2;
> >
> > /*
>
> This patch leaves jfs's open-coded version of the same check.
Heh, thanks for pointing that out. I'll fix both of those things.
--D
> Thanks,
> Shaggy
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Darrick J. Wong <darrick.wong@oracle.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [Jfs-discussion] [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS
Date: Tue, 11 Jun 2019 17:35:38 -0700 [thread overview]
Message-ID: <20190612003538.GW1871505@magnolia> (raw)
In-Reply-To: <fb974a33-2192-30ab-9f31-885c3796360b@oracle.com>
On Tue, Jun 11, 2019 at 08:41:06AM -0500, Dave Kleikamp wrote:
> On 6/10/19 11:45 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Create a generic checking function for the incoming FS_IOC_SETFLAGS flag
> > values so that we can standardize the implementations that follow ext4's
> > flag values.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> -- clip --
>
> > diff --git a/fs/jfs/ioctl.c b/fs/jfs/ioctl.c
> > index ba34dae8bd9f..c8446d2cd0c7 100644
> > --- a/fs/jfs/ioctl.c
> > +++ b/fs/jfs/ioctl.c
> > @@ -98,6 +98,12 @@ long jfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> > /* Lock against other parallel changes of flags */
> > inode_lock(inode);
> >
> > + oldflags = jfs_map_ext2(jfs_inode->mode2 & JFS_FL_USER_VISIBLE,
> > + 0);
> > + err = vfs_ioc_setflags_check(inode, oldflags, flags);
> > + if (err)
> > + goto setflags_out;
>
> inode_unlock(inode) is not called on the error path.
>
> > +
> > oldflags = jfs_inode->mode2;
> >
> > /*
>
> This patch leaves jfs's open-coded version of the same check.
Heh, thanks for pointing that out. I'll fix both of those things.
--D
> Thanks,
> Shaggy
next prev parent reply other threads:[~2019-06-12 0:36 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 4:45 [PATCH 0/4] vfs: clean up SETFLAGS and FSSETXATTR option processing Darrick J. Wong
2019-06-11 4:45 ` [Cluster-devel] " Darrick J. Wong
2019-06-11 4:45 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:45 ` Darrick J. Wong
2019-06-11 4:45 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-11 4:45 ` [PATCH 1/4] vfs: create a generic checking function for FS_IOC_SETFLAGS Darrick J. Wong
2019-06-11 4:45 ` [Cluster-devel] " Darrick J. Wong
2019-06-11 4:45 ` Darrick J. Wong
2019-06-11 4:45 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:45 ` Darrick J. Wong
2019-06-11 4:45 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-11 13:41 ` [Jfs-discussion] " Dave Kleikamp
2019-06-11 13:41 ` [Cluster-devel] " Dave Kleikamp
2019-06-11 13:41 ` [f2fs-dev] " Dave Kleikamp
2019-06-11 13:41 ` Dave Kleikamp
2019-06-11 13:41 ` [Ocfs2-devel] " Dave Kleikamp
2019-06-12 0:35 ` Darrick J. Wong [this message]
2019-06-12 0:35 ` [Cluster-devel] " Darrick J. Wong
2019-06-12 0:35 ` Darrick J. Wong
2019-06-12 0:35 ` [f2fs-dev] " Darrick J. Wong
2019-06-12 0:35 ` Darrick J. Wong
2019-06-12 0:35 ` [Ocfs2-devel] [Jfs-discussion] " Darrick J. Wong
2019-06-12 0:42 ` [PATCH v2 " Darrick J. Wong
2019-06-12 0:42 ` [Cluster-devel] " Darrick J. Wong
2019-06-12 0:42 ` Darrick J. Wong
2019-06-12 0:42 ` [f2fs-dev] " Darrick J. Wong
2019-06-12 0:42 ` Darrick J. Wong
2019-06-12 0:42 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-20 13:34 ` Jan Kara
2019-06-20 13:34 ` [Cluster-devel] " Jan Kara
2019-06-20 13:34 ` Jan Kara
2019-06-20 13:34 ` [f2fs-dev] " Jan Kara
2019-06-20 13:34 ` [Ocfs2-devel] " Jan Kara
2019-06-11 4:45 ` [PATCH 2/4] vfs: create a generic checking function for FS_IOC_FSSETXATTR Darrick J. Wong
2019-06-11 4:45 ` [Cluster-devel] " Darrick J. Wong
2019-06-11 4:45 ` Darrick J. Wong
2019-06-11 4:45 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:45 ` Darrick J. Wong
2019-06-11 4:45 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-20 13:38 ` Jan Kara
2019-06-20 13:38 ` [Cluster-devel] " Jan Kara
2019-06-20 13:38 ` Jan Kara
2019-06-20 13:38 ` [f2fs-dev] " Jan Kara
2019-06-20 13:38 ` [Ocfs2-devel] " Jan Kara
2019-06-11 4:45 ` [PATCH 3/4] fs: teach vfs_ioc_fssetxattr_check to check project id info Darrick J. Wong
2019-06-11 4:45 ` [Cluster-devel] " Darrick J. Wong
2019-06-11 4:45 ` Darrick J. Wong
2019-06-11 4:45 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:45 ` Darrick J. Wong
2019-06-11 4:45 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-20 13:41 ` Jan Kara
2019-06-20 13:41 ` [Cluster-devel] " Jan Kara
2019-06-20 13:41 ` Jan Kara
2019-06-20 13:41 ` [f2fs-dev] " Jan Kara
2019-06-20 13:41 ` [Ocfs2-devel] " Jan Kara
2019-06-11 4:46 ` [PATCH 4/4] vfs: teach vfs_ioc_fssetxattr_check to check extent size hints Darrick J. Wong
2019-06-11 4:46 ` [Cluster-devel] " Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [f2fs-dev] " Darrick J. Wong
2019-06-11 4:46 ` Darrick J. Wong
2019-06-11 4:46 ` [Ocfs2-devel] " Darrick J. Wong
2019-06-20 13:46 ` Jan Kara
2019-06-20 13:46 ` [Cluster-devel] " Jan Kara
2019-06-20 13:46 ` Jan Kara
2019-06-20 13:46 ` [f2fs-dev] " Jan Kara
2019-06-20 13:46 ` [Ocfs2-devel] " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612003538.GW1871505@magnolia \
--to=darrick.wong@oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=ard.biesheuvel@linaro.org \
--cc=clm@fb.com \
--cc=cluster-devel@redhat.com \
--cc=dave.kleikamp@oracle.com \
--cc=dsterba@suse.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jk@ozlabs.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=shaggy@kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.