From: Simon Horman <horms@verge.net.au> To: Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: linux-i2c@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/34] mtd: maps: pismo: simplify getting the adapter of a client Date: Thu, 13 Jun 2019 11:50:02 +0200 [thread overview] Message-ID: <20190613095002.r5shpabxw7jmsmcf@verge.net.au> (raw) In-Reply-To: <20190608105619.593-16-wsa+renesas@sang-engineering.com> On Sat, Jun 08, 2019 at 12:55:54PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > --- > > Please apply to your subsystem tree. > > drivers/mtd/maps/pismo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/maps/pismo.c b/drivers/mtd/maps/pismo.c > index 788d4996e2c1..7fcae3af435c 100644 > --- a/drivers/mtd/maps/pismo.c > +++ b/drivers/mtd/maps/pismo.c > @@ -211,7 +211,7 @@ static int pismo_remove(struct i2c_client *client) > static int pismo_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); > + struct i2c_adapter *adapter = client->adapter; > struct pismo_pdata *pdata = client->dev.platform_data; > struct pismo_eeprom eeprom; > struct pismo_data *pismo; > -- > 2.19.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au> To: Wolfram Sang <wsa+renesas@sang-engineering.com> Cc: Vignesh Raghavendra <vigneshr@ti.com>, Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Miquel Raynal <miquel.raynal@bootlin.com>, Brian Norris <computersforpeace@gmail.com>, David Woodhouse <dwmw2@infradead.org> Subject: Re: [PATCH 15/34] mtd: maps: pismo: simplify getting the adapter of a client Date: Thu, 13 Jun 2019 11:50:02 +0200 [thread overview] Message-ID: <20190613095002.r5shpabxw7jmsmcf@verge.net.au> (raw) In-Reply-To: <20190608105619.593-16-wsa+renesas@sang-engineering.com> On Sat, Jun 08, 2019 at 12:55:54PM +0200, Wolfram Sang wrote: > We have a dedicated pointer for that, so use it. Much easier to read and > less computation involved. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Reviewed-by: Simon Horman <horms+renesas@verge.net.au> > --- > > Please apply to your subsystem tree. > > drivers/mtd/maps/pismo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/maps/pismo.c b/drivers/mtd/maps/pismo.c > index 788d4996e2c1..7fcae3af435c 100644 > --- a/drivers/mtd/maps/pismo.c > +++ b/drivers/mtd/maps/pismo.c > @@ -211,7 +211,7 @@ static int pismo_remove(struct i2c_client *client) > static int pismo_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent); > + struct i2c_adapter *adapter = client->adapter; > struct pismo_pdata *pdata = client->dev.platform_data; > struct pismo_eeprom eeprom; > struct pismo_data *pismo; > -- > 2.19.1 > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-06-13 15:41 UTC|newest] Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-08 10:55 [PATCH 00/34] treewide: simplify getting the adapter of an I2C client Wolfram Sang 2019-06-08 10:55 ` Wolfram Sang 2019-06-08 10:55 ` Wolfram Sang 2019-06-08 10:55 ` Wolfram Sang 2019-06-08 10:55 ` [PATCH 01/34] clk: clk-cdce706: simplify getting the adapter of a client Wolfram Sang 2019-06-13 9:45 ` Simon Horman 2019-06-25 22:55 ` Stephen Boyd 2019-06-25 22:55 ` Stephen Boyd 2019-06-08 10:55 ` [PATCH 02/34] gpu: drm: bridge: sii9234: " Wolfram Sang 2019-06-08 11:40 ` Laurent Pinchart 2019-06-08 11:40 ` Laurent Pinchart 2019-06-12 14:04 ` Andrzej Hajda 2019-06-08 10:55 ` [PATCH 03/34] iio: light: bh1780: " Wolfram Sang 2019-06-08 11:39 ` Jonathan Cameron 2019-06-08 10:55 ` [PATCH 04/34] leds: leds-pca955x: " Wolfram Sang 2019-06-09 11:03 ` Jacek Anaszewski 2019-06-09 11:05 ` Pavel Machek 2019-06-09 11:17 ` Jacek Anaszewski 2019-06-08 10:55 ` [PATCH 05/34] leds: leds-tca6507: " Wolfram Sang 2019-06-13 9:47 ` Simon Horman 2019-06-08 10:55 ` [PATCH 06/34] media: i2c: ak881x: " Wolfram Sang 2019-06-13 9:47 ` Simon Horman 2019-06-08 10:55 ` [PATCH 07/34] media: i2c: mt9m001: " Wolfram Sang 2019-06-13 9:47 ` Simon Horman 2019-06-08 10:55 ` [PATCH 08/34] media: i2c: mt9m111: " Wolfram Sang 2019-06-13 9:47 ` Simon Horman 2019-06-08 10:55 ` [PATCH 09/34] media: i2c: mt9p031: " Wolfram Sang 2019-06-08 11:42 ` Laurent Pinchart 2019-06-08 10:55 ` [PATCH 10/34] media: i2c: ov2640: " Wolfram Sang 2019-06-13 9:48 ` Simon Horman 2019-06-08 10:55 ` [PATCH 11/34] media: i2c: tw9910: " Wolfram Sang 2019-06-13 9:48 ` Simon Horman 2019-06-08 10:55 ` [PATCH 12/34] misc: fsa9480: " Wolfram Sang 2019-06-13 9:49 ` Simon Horman 2019-06-08 10:55 ` [PATCH 13/34] misc: isl29003: " Wolfram Sang 2019-06-13 9:49 ` Simon Horman 2019-06-08 10:55 ` [PATCH 14/34] misc: tsl2550: " Wolfram Sang 2019-06-13 9:49 ` Simon Horman 2019-06-08 10:55 ` [PATCH 15/34] mtd: maps: pismo: " Wolfram Sang 2019-06-08 10:55 ` Wolfram Sang 2019-06-13 9:50 ` Simon Horman [this message] 2019-06-13 9:50 ` Simon Horman 2019-06-08 10:55 ` [PATCH 16/34] power: supply: bq24190_charger: " Wolfram Sang 2019-06-13 9:50 ` Simon Horman 2019-06-08 10:55 ` [PATCH 17/34] power: supply: bq24257_charger: " Wolfram Sang 2019-06-13 9:50 ` Simon Horman 2019-06-08 10:55 ` [PATCH 18/34] power: supply: bq25890_charger: " Wolfram Sang 2019-06-13 9:50 ` Simon Horman 2019-06-08 10:55 ` [PATCH 19/34] power: supply: max14656_charger_detector: " Wolfram Sang 2019-06-13 9:51 ` Simon Horman 2019-06-08 10:55 ` [PATCH 20/34] power: supply: max17040_battery: " Wolfram Sang 2019-06-13 9:52 ` Simon Horman 2019-06-08 10:56 ` [PATCH 21/34] power: supply: max17042_battery: " Wolfram Sang 2019-06-13 9:52 ` Simon Horman 2019-06-08 10:56 ` [PATCH 22/34] power: supply: rt5033_battery: " Wolfram Sang 2019-06-13 9:52 ` Simon Horman 2019-06-08 10:56 ` [PATCH 23/34] power: supply: rt9455_charger: " Wolfram Sang 2019-06-13 9:52 ` Simon Horman 2019-06-08 10:56 ` [PATCH 24/34] power: supply: sbs-manager: " Wolfram Sang 2019-06-13 9:53 ` Simon Horman 2019-06-08 10:56 ` [PATCH 25/34] regulator: max8952: " Wolfram Sang 2019-06-10 17:34 ` Applied "regulator: max8952: simplify getting the adapter of a client" to the regulator tree Mark Brown 2019-06-10 17:34 ` Mark Brown 2019-06-08 10:56 ` [PATCH 26/34] rtc: fm3130: simplify getting the adapter of a client Wolfram Sang 2019-06-09 14:48 ` Alexandre Belloni 2019-06-08 10:56 ` [PATCH 27/34] rtc: m41t80: " Wolfram Sang 2019-06-09 14:48 ` Alexandre Belloni 2019-06-08 10:56 ` [PATCH 28/34] rtc: rv8803: " Wolfram Sang 2019-06-09 14:49 ` Alexandre Belloni 2019-06-08 10:56 ` [PATCH 29/34] rtc: rx8010: " Wolfram Sang 2019-06-09 14:49 ` Alexandre Belloni 2019-06-08 10:56 ` [PATCH 30/34] rtc: rx8025: " Wolfram Sang 2019-06-09 14:49 ` Alexandre Belloni 2019-06-08 10:56 ` [PATCH 31/34] staging: media: soc_camera: imx074: " Wolfram Sang 2019-06-08 10:56 ` Wolfram Sang 2019-06-08 10:56 ` Wolfram Sang 2019-06-13 9:53 ` Simon Horman 2019-06-13 9:53 ` Simon Horman 2019-06-13 9:53 ` Simon Horman 2019-06-08 10:56 ` [PATCH 32/34] staging: media: soc_camera: mt9t031: " Wolfram Sang 2019-06-13 9:54 ` Simon Horman 2019-06-13 9:54 ` Simon Horman 2019-06-08 10:56 ` [PATCH 33/34] staging: media: soc_camera: soc_mt9v022: " Wolfram Sang 2019-06-13 9:54 ` Simon Horman 2019-06-13 9:54 ` Simon Horman 2019-06-08 10:56 ` [PATCH 34/34] usb: typec: tcpm: fusb302: " Wolfram Sang 2019-06-08 12:59 ` Guenter Roeck 2019-06-13 9:54 ` Simon Horman 2019-06-09 16:37 ` [PATCH 00/34] treewide: simplify getting the adapter of an I2C client Peter Rosin 2019-06-09 16:37 ` Peter Rosin 2019-06-09 16:37 ` Peter Rosin 2019-06-09 16:37 ` Peter Rosin 2019-06-10 7:15 ` Wolfram Sang 2019-06-10 7:15 ` Wolfram Sang 2019-06-10 7:15 ` Wolfram Sang 2019-06-10 7:15 ` Wolfram Sang 2019-06-27 18:28 ` Sebastian Reichel 2019-06-27 18:28 ` Sebastian Reichel 2019-06-27 18:28 ` Sebastian Reichel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190613095002.r5shpabxw7jmsmcf@verge.net.au \ --to=horms@verge.net.au \ --cc=computersforpeace@gmail.com \ --cc=dwmw2@infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.