From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org,
linux-media@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Yishai Hadas <yishaih@mellanox.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Alexander Deucher <Alexander.Deucher@amd.com>,
Christian Koenig <Christian.Koenig@amd.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jens Wiklander <jens.wiklander@linaro.org>
Subject: Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel
Date: Mon, 24 Jun 2019 18:38:06 +0100 [thread overview]
Message-ID: <20190624173805.GK29120@arrakis.emea.arm.com> (raw)
In-Reply-To: <0999c80cd639b78ae27c0674069d552833227564.1561386715.git.andreyknvl@google.com>
On Mon, Jun 24, 2019 at 04:33:00PM +0200, Andrey Konovalov wrote:
> --- /dev/null
> +++ b/tools/testing/selftests/arm64/tags_test.c
> @@ -0,0 +1,29 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <stdint.h>
> +#include <sys/prctl.h>
> +#include <sys/utsname.h>
> +
> +#define SHIFT_TAG(tag) ((uint64_t)(tag) << 56)
> +#define SET_TAG(ptr, tag) (((uint64_t)(ptr) & ~SHIFT_TAG(0xff)) | \
> + SHIFT_TAG(tag))
> +
> +int main(void)
> +{
> + static int tbi_enabled = 0;
> + struct utsname *ptr, *tagged_ptr;
> + int err;
> +
> + if (prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0) == 0)
> + tbi_enabled = 1;
Nitpick: with the latest prctl() patch, you can skip the last three
arguments as they are ignored.
Either way:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org,
linux-media@vger.kernel.org, kvm@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Yishai Hadas <yishaih@mellanox.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Alexander Deucher <Alexander.Deucher@amd.com>,
Christian Koenig <Christian.Koenig@amd.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Jens Wiklander <jens.wiklander@linaro.org>,
Alex Williamson <alex.williamson@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>,
Dave Martin <Dave.Martin@arm.com>,
Khalid Aziz <khalid.aziz@oracle.com>, enh <enh@google.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Christoph Hellwig <hch@infradead.org>,
Dmitry Vyukov <dvyukov@google.com>,
Kostya Serebryany <kcc@google.com>,
Evgeniy Stepanov <eugenis@google.com>,
Lee Smith <Lee.Smith@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Jacob Bramley <Jacob.Bramley@arm.com>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Brodsky <kevin.brodsky@arm.com>,
Szabolcs Nagy <Szabolcs.Nagy@arm.com>
Subject: Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel
Date: Mon, 24 Jun 2019 18:38:06 +0100 [thread overview]
Message-ID: <20190624173805.GK29120@arrakis.emea.arm.com> (raw)
In-Reply-To: <0999c80cd639b78ae27c0674069d552833227564.1561386715.git.andreyknvl@google.com>
On Mon, Jun 24, 2019 at 04:33:00PM +0200, Andrey Konovalov wrote:
> --- /dev/null
> +++ b/tools/testing/selftests/arm64/tags_test.c
> @@ -0,0 +1,29 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <stdint.h>
> +#include <sys/prctl.h>
> +#include <sys/utsname.h>
> +
> +#define SHIFT_TAG(tag) ((uint64_t)(tag) << 56)
> +#define SET_TAG(ptr, tag) (((uint64_t)(ptr) & ~SHIFT_TAG(0xff)) | \
> + SHIFT_TAG(tag))
> +
> +int main(void)
> +{
> + static int tbi_enabled = 0;
> + struct utsname *ptr, *tagged_ptr;
> + int err;
> +
> + if (prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0) == 0)
> + tbi_enabled = 1;
Nitpick: with the latest prctl() patch, you can skip the last three
arguments as they are ignored.
Either way:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
kvm@vger.kernel.org, Szabolcs Nagy <Szabolcs.Nagy@arm.com>,
Will Deacon <will.deacon@arm.com>,
dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
Khalid Aziz <khalid.aziz@oracle.com>,
linux-kselftest@vger.kernel.org,
Felix Kuehling <Felix.Kuehling@amd.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Jacob Bramley <Jacob.Bramley@arm.com>,
Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Christoph Hellwig <hch@infradead.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dmitry Vyukov <dvyukov@google.com>,
Dave Martin <Dave.Martin@arm.com>,
Evgeniy Stepanov <eugenis@google.com>,
linux-media@vger.kernel.org,
Kevin Brodsky <kevin.brodsky@arm.com>,
Kees Cook <keescook@chromium.org>,
Ruben Ayrapetyan <Ruben.Ayrapetyan@arm.com>,
Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
Alex Williamson <alex.williamson@redhat.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Kostya Serebryany <kcc@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Yishai Hadas <yishaih@mellanox.com>,
linux-kernel@vger.kernel.org,
Jens Wiklander <jens.wiklander@linaro.org>,
Lee Smith <Lee.Smith@arm.com>,
Alexander Deucher <Alexander.Deucher@amd.com>,
Andrew Morton <akpm@linux-foundation.org>, enh <enh@google.com>,
Robin Murphy <robin.murphy@arm.com>,
Christian Koenig <Christian.Koenig@amd.com>,
Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Subject: Re: [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel
Date: Mon, 24 Jun 2019 18:38:06 +0100 [thread overview]
Message-ID: <20190624173805.GK29120@arrakis.emea.arm.com> (raw)
In-Reply-To: <0999c80cd639b78ae27c0674069d552833227564.1561386715.git.andreyknvl@google.com>
On Mon, Jun 24, 2019 at 04:33:00PM +0200, Andrey Konovalov wrote:
> --- /dev/null
> +++ b/tools/testing/selftests/arm64/tags_test.c
> @@ -0,0 +1,29 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <unistd.h>
> +#include <stdint.h>
> +#include <sys/prctl.h>
> +#include <sys/utsname.h>
> +
> +#define SHIFT_TAG(tag) ((uint64_t)(tag) << 56)
> +#define SET_TAG(ptr, tag) (((uint64_t)(ptr) & ~SHIFT_TAG(0xff)) | \
> + SHIFT_TAG(tag))
> +
> +int main(void)
> +{
> + static int tbi_enabled = 0;
> + struct utsname *ptr, *tagged_ptr;
> + int err;
> +
> + if (prctl(PR_SET_TAGGED_ADDR_CTRL, PR_TAGGED_ADDR_ENABLE, 0, 0, 0) == 0)
> + tbi_enabled = 1;
Nitpick: with the latest prctl() patch, you can skip the last three
arguments as they are ignored.
Either way:
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-24 17:38 UTC|newest]
Thread overview: 177+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 14:32 [PATCH v18 00/15] arm64: untag user pointers passed to the kernel Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 01/15] arm64: untag user pointers in access_ok and __uaccess_mask_ptr Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 02/15] arm64: Introduce prctl() options to control the tagged user addresses ABI Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 15:04 ` Kees Cook
2019-06-24 15:04 ` Kees Cook
2019-06-24 15:04 ` Kees Cook
2019-06-24 14:32 ` [PATCH v18 03/15] lib: untag user pointers in strn*_user Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 04/15] mm: untag user pointers passed to memory syscalls Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 05/15] mm: untag user pointers in mm/gup.c Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 06/15] mm: untag user pointers in get_vaddr_frames Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 07/15] fs/namespace: untag user pointers in copy_mount_options Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 17:50 ` Catalin Marinas
2019-06-24 17:50 ` Catalin Marinas
2019-06-24 17:50 ` Catalin Marinas
2019-07-15 16:00 ` Andrey Konovalov
2019-07-15 16:00 ` Andrey Konovalov
2019-07-15 16:00 ` Andrey Konovalov
2019-07-15 16:00 ` Andrey Konovalov
2019-07-22 16:46 ` Kees Cook
2019-07-22 16:46 ` Kees Cook
2019-07-22 16:46 ` Kees Cook
2019-07-22 16:46 ` Kees Cook
2019-06-24 14:32 ` [PATCH v18 08/15] userfaultfd: untag user pointers Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 17:51 ` Catalin Marinas
2019-06-24 17:51 ` Catalin Marinas
2019-06-24 17:51 ` Catalin Marinas
2019-07-15 16:00 ` Andrey Konovalov
2019-07-15 16:00 ` Andrey Konovalov
2019-07-15 16:00 ` Andrey Konovalov
2019-07-15 16:00 ` Andrey Konovalov
2019-07-17 11:09 ` Mike Rapoport
2019-07-17 11:09 ` Mike Rapoport
2019-07-17 11:09 ` Mike Rapoport
2019-07-17 11:46 ` Andrey Konovalov
2019-07-17 11:46 ` Andrey Konovalov
2019-07-17 11:46 ` Andrey Konovalov
2019-07-17 11:46 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 09/15] drm/amdgpu: " Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 15:00 ` Kees Cook
2019-06-24 15:00 ` Kees Cook
2019-06-24 15:00 ` Kees Cook
2019-06-24 14:32 ` [PATCH v18 10/15] drm/radeon: untag user pointers in radeon_gem_userptr_ioctl Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 15:01 ` Kees Cook
2019-06-24 15:01 ` Kees Cook
2019-06-24 15:01 ` Kees Cook
2019-06-24 15:02 ` Kees Cook
2019-06-24 15:02 ` Kees Cook
2019-06-24 15:02 ` Kees Cook
2019-06-26 17:50 ` Khalid Aziz
2019-06-26 17:50 ` Khalid Aziz
2019-06-26 17:50 ` Khalid Aziz
2019-06-24 14:32 ` [PATCH v18 11/15] IB/mlx4: untag user pointers in mlx4_get_umem_mr Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 15:01 ` Kees Cook
2019-06-24 15:01 ` Kees Cook
2019-06-24 15:01 ` Kees Cook
2019-06-24 17:40 ` Catalin Marinas
2019-06-24 17:40 ` Catalin Marinas
2019-06-24 17:40 ` Catalin Marinas
2019-07-15 16:01 ` Andrey Konovalov
2019-07-15 16:01 ` Andrey Konovalov
2019-07-15 16:01 ` Andrey Konovalov
2019-07-15 16:01 ` Andrey Konovalov
2019-07-15 18:05 ` Jason Gunthorpe
2019-07-15 18:05 ` Jason Gunthorpe
2019-07-15 18:05 ` Jason Gunthorpe
2019-07-15 18:05 ` Jason Gunthorpe
2019-07-16 10:42 ` Andrey Konovalov
2019-07-16 10:42 ` Andrey Konovalov
2019-07-16 10:42 ` Andrey Konovalov
2019-07-16 10:42 ` Andrey Konovalov
2019-07-16 12:06 ` Jason Gunthorpe
2019-07-16 12:06 ` Jason Gunthorpe
2019-07-16 12:06 ` Jason Gunthorpe
2019-07-16 12:06 ` Jason Gunthorpe
2019-07-17 11:42 ` Andrey Konovalov
2019-07-17 11:42 ` Andrey Konovalov
2019-07-17 11:42 ` Andrey Konovalov
2019-07-17 11:42 ` Andrey Konovalov
2019-07-17 11:44 ` Andrey Konovalov
2019-07-17 11:44 ` Andrey Konovalov
2019-07-17 11:44 ` Andrey Konovalov
2019-07-17 11:44 ` Andrey Konovalov
2019-07-17 11:58 ` Jason Gunthorpe
2019-07-17 11:58 ` Jason Gunthorpe
2019-07-17 11:58 ` Jason Gunthorpe
2019-07-17 11:58 ` Jason Gunthorpe
2019-07-17 13:36 ` Andrey Konovalov
2019-07-17 13:36 ` Andrey Konovalov
2019-07-17 13:36 ` Andrey Konovalov
2019-07-17 13:36 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 12/15] media/v4l2-core: untag user pointers in videobuf_dma_contig_user_get Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 13/15] tee/shm: untag user pointers in tee_shm_register Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` [PATCH v18 14/15] vfio/type1: untag user pointers in vaddr_get_pfn Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:32 ` Andrey Konovalov
2019-06-24 14:33 ` [PATCH v18 15/15] selftests, arm64: add a selftest for passing tagged pointers to kernel Andrey Konovalov
2019-06-24 14:33 ` Andrey Konovalov
2019-06-24 14:33 ` Andrey Konovalov
2019-06-24 14:33 ` Andrey Konovalov
2019-06-24 15:02 ` Kees Cook
2019-06-24 15:02 ` Kees Cook
2019-06-24 15:02 ` Kees Cook
2019-06-24 17:38 ` Catalin Marinas [this message]
2019-06-24 17:38 ` Catalin Marinas
2019-06-24 17:38 ` Catalin Marinas
2019-08-23 13:56 ` Cristian Marussi
2019-08-23 13:56 ` Cristian Marussi
2019-08-23 13:56 ` Cristian Marussi
2019-08-23 17:16 ` Andrey Konovalov
2019-08-23 17:16 ` Andrey Konovalov
2019-08-23 17:16 ` Andrey Konovalov
2019-08-23 17:16 ` Andrey Konovalov
2019-08-23 17:49 ` Cristian Marussi
2019-08-23 17:49 ` Cristian Marussi
2019-08-23 17:49 ` Cristian Marussi
2019-08-23 17:49 ` Cristian Marussi
2019-08-26 9:09 ` Amit Kachhap
2019-08-26 9:09 ` Amit Kachhap
2019-08-26 9:09 ` Amit Kachhap
2019-09-04 14:52 ` Andrey Konovalov
2019-09-04 14:52 ` Andrey Konovalov
2019-09-04 14:52 ` Andrey Konovalov
2019-09-04 14:52 ` Andrey Konovalov
2019-09-04 16:22 ` Cristian Marussi
2019-09-04 16:22 ` Cristian Marussi
2019-09-04 16:22 ` Cristian Marussi
2019-09-04 16:22 ` Cristian Marussi
2019-09-04 16:42 ` Andrey Konovalov
2019-09-04 16:42 ` Andrey Konovalov
2019-09-04 16:42 ` Andrey Konovalov
2019-09-04 16:42 ` Andrey Konovalov
2019-06-26 17:18 ` [PATCH v18 00/15] arm64: untag user pointers passed to the kernel Catalin Marinas
2019-06-26 17:18 ` Catalin Marinas
2019-06-26 17:18 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624173805.GK29120@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andreyknvl@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jens.wiklander@linaro.org \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=vincenzo.frascino@arm.com \
--cc=will.deacon@arm.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.