From: Herbert Xu <herbert@gondor.apana.org.au>
To: Imre Deak <imre.deak@intel.com>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
"David S. Miller" <davem@davemloft.net>,
horia.geanta@nxp.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 1/4] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE
Date: Tue, 25 Jun 2019 09:20:59 +0800 [thread overview]
Message-ID: <20190625012059.albyfaca73uoaoxr@gondor.apana.org.au> (raw)
In-Reply-To: <20190624173533.GA809@ideak-desk.fi.intel.com>
On Mon, Jun 24, 2019 at 08:35:33PM +0300, Imre Deak wrote:
> Hi,
>
> On Thu, Jun 20, 2019 at 02:02:21PM +0800, Herbert Xu wrote:
> > On Mon, Jun 17, 2019 at 09:15:02PM +0000, Christophe Leroy wrote:
> > > All mapping iterator logic is based on the assumption that sg->offset
> > > is always lower than PAGE_SIZE.
> > >
> > > But there are situations where sg->offset is such that the SG item
> > > is on the second page.
>
> could you explain how sg->offset becomes >= PAGE_SIZE?
The network stack can produce SG list elements that are longer
than PAGE_SIZE. If you the iterate over it one page at a time
then the offset can exceed PAGE_SIZE.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Imre Deak <imre.deak@intel.com>
Cc: horia.geanta@nxp.com, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 1/4] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE
Date: Tue, 25 Jun 2019 09:20:59 +0800 [thread overview]
Message-ID: <20190625012059.albyfaca73uoaoxr@gondor.apana.org.au> (raw)
In-Reply-To: <20190624173533.GA809@ideak-desk.fi.intel.com>
On Mon, Jun 24, 2019 at 08:35:33PM +0300, Imre Deak wrote:
> Hi,
>
> On Thu, Jun 20, 2019 at 02:02:21PM +0800, Herbert Xu wrote:
> > On Mon, Jun 17, 2019 at 09:15:02PM +0000, Christophe Leroy wrote:
> > > All mapping iterator logic is based on the assumption that sg->offset
> > > is always lower than PAGE_SIZE.
> > >
> > > But there are situations where sg->offset is such that the SG item
> > > is on the second page.
>
> could you explain how sg->offset becomes >= PAGE_SIZE?
The network stack can produce SG list elements that are longer
than PAGE_SIZE. If you the iterate over it one page at a time
then the offset can exceed PAGE_SIZE.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-06-25 1:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 21:15 [PATCH v4 0/4] Additional fixes on Talitos driver Christophe Leroy
2019-06-17 21:15 ` Christophe Leroy
2019-06-17 21:15 ` [PATCH v4 1/4] lib/scatterlist: Fix mapping iterator when sg->offset is greater than PAGE_SIZE Christophe Leroy
2019-06-17 21:15 ` Christophe Leroy
2019-06-20 6:02 ` Herbert Xu
2019-06-20 6:02 ` Herbert Xu
2019-06-24 17:35 ` Imre Deak
2019-06-24 17:35 ` Imre Deak
2019-06-25 1:20 ` Herbert Xu [this message]
2019-06-25 1:20 ` Herbert Xu
2019-06-17 21:15 ` [PATCH v4 2/4] crypto: talitos - move struct talitos_edesc into talitos.h Christophe Leroy
2019-06-17 21:15 ` Christophe Leroy
2019-06-17 21:15 ` [PATCH v4 3/4] crypto: talitos - fix hash on SEC1 Christophe Leroy
2019-06-17 21:15 ` Christophe Leroy
2019-06-17 21:15 ` [PATCH v4 4/4] crypto: talitos - drop icv_ool Christophe Leroy
2019-06-17 21:15 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625012059.albyfaca73uoaoxr@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=christophe.leroy@c-s.fr \
--cc=davem@davemloft.net \
--cc=horia.geanta@nxp.com \
--cc=imre.deak@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.