From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Nicholas Piggin <npiggin@gmail.com>,
Khalid Aziz <khalid.aziz@oracle.com>,
Andrey Konovalov <andreyknvl@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-mips@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/16] mm: move the powerpc hugepd code to mm/gup.c
Date: Wed, 26 Jun 2019 05:49:34 +0000 [thread overview]
Message-ID: <20190626054934.GA23547@lst.de> (raw)
In-Reply-To: <20190625123757.ec7e886747bb5a9bc364107d@linux-foundation.org>
On Tue, Jun 25, 2019 at 12:37:57PM -0700, Andrew Morton wrote:
> On Tue, 25 Jun 2019 16:37:13 +0200 Christoph Hellwig <hch@lst.de> wrote:
>
> > +static int gup_huge_pd(hugepd_t hugepd
>
> Naming nitlet: we have hugepd and we also have huge_pd. We have
> hugepte and we also have huge_pte. It make things a bit hard to
> remember and it would be nice to make it all consistent sometime.
>
> We're consistent with huge_pud and almost consistent with huge_pmd.
>
> To be fully consistent I guess we should make all of them have the
> underscore. Or not have it.
Either way is fine with me. Feel free to fix up per your preference.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
Nicholas Piggin <npiggin@gmail.com>,
Khalid Aziz <khalid.aziz@oracle.com>,
Andrey Konovalov <andreyknvl@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
linux-mips@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/16] mm: move the powerpc hugepd code to mm/gup.c
Date: Wed, 26 Jun 2019 07:49:34 +0200 [thread overview]
Message-ID: <20190626054934.GA23547@lst.de> (raw)
In-Reply-To: <20190625123757.ec7e886747bb5a9bc364107d@linux-foundation.org>
On Tue, Jun 25, 2019 at 12:37:57PM -0700, Andrew Morton wrote:
> On Tue, 25 Jun 2019 16:37:13 +0200 Christoph Hellwig <hch@lst.de> wrote:
>
> > +static int gup_huge_pd(hugepd_t hugepd
>
> Naming nitlet: we have hugepd and we also have huge_pd. We have
> hugepte and we also have huge_pte. It make things a bit hard to
> remember and it would be nice to make it all consistent sometime.
>
> We're consistent with huge_pud and almost consistent with huge_pmd.
>
> To be fully consistent I guess we should make all of them have the
> underscore. Or not have it.
Either way is fine with me. Feel free to fix up per your preference.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: x86@kernel.org, Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-sh@vger.kernel.org, James Hogan <jhogan@kernel.org>,
linuxppc-dev@lists.ozlabs.org,
Khalid Aziz <khalid.aziz@oracle.com>,
Nicholas Piggin <npiggin@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-mm@kvack.org, Paul Burton <paul.burton@mips.com>,
Paul Mackerras <paulus@samba.org>,
Andrey Konovalov <andreyknvl@google.com>,
sparclinux@vger.kernel.org, linux-mips@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/16] mm: move the powerpc hugepd code to mm/gup.c
Date: Wed, 26 Jun 2019 07:49:34 +0200 [thread overview]
Message-ID: <20190626054934.GA23547@lst.de> (raw)
In-Reply-To: <20190625123757.ec7e886747bb5a9bc364107d@linux-foundation.org>
On Tue, Jun 25, 2019 at 12:37:57PM -0700, Andrew Morton wrote:
> On Tue, 25 Jun 2019 16:37:13 +0200 Christoph Hellwig <hch@lst.de> wrote:
>
> > +static int gup_huge_pd(hugepd_t hugepd
>
> Naming nitlet: we have hugepd and we also have huge_pd. We have
> hugepte and we also have huge_pte. It make things a bit hard to
> remember and it would be nice to make it all consistent sometime.
>
> We're consistent with huge_pud and almost consistent with huge_pmd.
>
> To be fully consistent I guess we should make all of them have the
> underscore. Or not have it.
Either way is fine with me. Feel free to fix up per your preference.
next prev parent reply other threads:[~2019-06-26 5:49 UTC|newest]
Thread overview: 252+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 14:40 switch the remaining architectures to use generic GUP v3 Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` [PATCH 01/16] mm: use untagged_addr() for get_user_pages_fast addresses Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 19:22 ` Khalid Aziz
2019-06-11 19:22 ` Khalid Aziz
2019-06-11 19:22 ` Khalid Aziz
2019-06-21 13:16 ` Jason Gunthorpe
2019-06-21 13:16 ` Jason Gunthorpe
2019-06-21 13:16 ` Jason Gunthorpe
2019-06-21 13:39 ` Jason Gunthorpe
2019-06-21 13:39 ` Jason Gunthorpe
2019-06-21 13:39 ` Jason Gunthorpe
2019-06-21 15:35 ` Khalid Aziz
2019-06-21 15:35 ` Khalid Aziz
2019-06-21 15:35 ` Khalid Aziz
2019-06-21 15:54 ` Jason Gunthorpe
2019-06-21 15:54 ` Jason Gunthorpe
2019-06-21 15:54 ` Jason Gunthorpe
2019-06-25 7:41 ` Christoph Hellwig
2019-06-25 7:41 ` Christoph Hellwig
2019-06-25 7:41 ` Christoph Hellwig
2019-06-25 7:43 ` Christoph Hellwig
2019-06-25 7:43 ` Christoph Hellwig
2019-06-25 7:43 ` Christoph Hellwig
2019-06-11 14:40 ` [PATCH 02/16] mm: simplify gup_fast_permitted Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-21 13:40 ` Jason Gunthorpe
2019-06-21 13:40 ` Jason Gunthorpe
2019-06-21 13:40 ` Jason Gunthorpe
2019-06-11 14:40 ` [PATCH 03/16] mm: lift the x86_32 PAE version of gup_get_pte to common code Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-21 13:45 ` Jason Gunthorpe
2019-06-21 13:45 ` Jason Gunthorpe
2019-06-21 13:45 ` Jason Gunthorpe
2019-06-11 14:40 ` [PATCH 04/16] MIPS: use the generic get_user_pages_fast code Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-21 14:05 ` Jason Gunthorpe
2019-06-21 14:05 ` Jason Gunthorpe
2019-06-21 14:05 ` Jason Gunthorpe
2019-06-25 7:46 ` Christoph Hellwig
2019-06-25 7:46 ` Christoph Hellwig
2019-06-25 7:46 ` Christoph Hellwig
2019-06-11 14:40 ` [PATCH 05/16] sh: add the missing pud_page definition Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` [PATCH 06/16] sh: use the generic get_user_pages_fast code Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` [PATCH 07/16] sparc64: add the missing pgd_page definition Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` [PATCH 08/16] sparc64: define untagged_addr() Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 19:23 ` Khalid Aziz
2019-06-11 19:23 ` Khalid Aziz
2019-06-11 19:23 ` Khalid Aziz
2019-06-11 14:40 ` [PATCH 09/16] sparc64: use the generic get_user_pages_fast code Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 19:35 ` Khalid Aziz
2019-06-11 19:35 ` Khalid Aziz
2019-06-11 19:35 ` Khalid Aziz
2019-06-11 14:40 ` [PATCH 10/16] mm: rename CONFIG_HAVE_GENERIC_GUP to CONFIG_HAVE_FAST_GUP Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 19:35 ` Khalid Aziz
2019-06-11 19:35 ` Khalid Aziz
2019-06-11 19:35 ` Khalid Aziz
2019-06-21 14:28 ` Jason Gunthorpe
2019-06-21 14:28 ` Jason Gunthorpe
2019-06-21 14:28 ` Jason Gunthorpe
2019-06-25 7:50 ` Christoph Hellwig
2019-06-25 7:50 ` Christoph Hellwig
2019-06-25 7:50 ` Christoph Hellwig
2019-06-11 14:40 ` [PATCH 11/16] mm: consolidate the get_user_pages* implementations Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-21 14:41 ` Jason Gunthorpe
2019-06-21 14:41 ` Jason Gunthorpe
2019-06-21 14:41 ` Jason Gunthorpe
2019-06-25 7:56 ` Christoph Hellwig
2019-06-25 7:56 ` Christoph Hellwig
2019-06-25 7:56 ` Christoph Hellwig
2019-06-25 11:56 ` Jason Gunthorpe
2019-06-25 11:56 ` Jason Gunthorpe
2019-06-25 11:56 ` Jason Gunthorpe
2019-06-11 14:40 ` [PATCH 12/16] mm: validate get_user_pages_fast flags Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` [PATCH 13/16] mm: move the powerpc hugepd code to mm/gup.c Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:40 ` Christoph Hellwig
2019-06-11 14:41 ` [PATCH 14/16] mm: switch gup_hugepte to use try_get_compound_head Christoph Hellwig
2019-06-11 14:41 ` Christoph Hellwig
2019-06-11 14:41 ` Christoph Hellwig
2019-06-11 14:41 ` [PATCH 15/16] mm: mark the page referenced in gup_hugepte Christoph Hellwig
2019-06-11 14:41 ` Christoph Hellwig
2019-06-11 14:41 ` Christoph Hellwig
2019-06-11 14:41 ` [PATCH 16/16] mm: pass get_user_pages_fast iterator arguments in a structure Christoph Hellwig
2019-06-11 14:41 ` Christoph Hellwig
2019-06-11 14:41 ` Christoph Hellwig
2019-06-12 0:52 ` Nicholas Piggin
2019-06-12 0:52 ` Nicholas Piggin
2019-06-12 0:52 ` Nicholas Piggin
2019-06-12 1:09 ` Linus Torvalds
2019-06-12 1:09 ` Linus Torvalds
2019-06-12 1:09 ` Linus Torvalds
2019-06-12 1:09 ` Linus Torvalds
2019-06-20 12:18 ` Nicholas Piggin
2019-06-20 12:18 ` Nicholas Piggin
2019-06-20 12:18 ` Nicholas Piggin
2019-06-20 17:21 ` Linus Torvalds
2019-06-20 17:21 ` Linus Torvalds
2019-06-20 17:21 ` Linus Torvalds
2019-06-20 17:21 ` Linus Torvalds
2019-06-21 8:15 ` Christoph Hellwig
2019-06-21 8:15 ` Christoph Hellwig
2019-06-21 8:15 ` Christoph Hellwig
2019-06-21 23:55 ` Nicholas Piggin
2019-06-21 23:55 ` Nicholas Piggin
2019-06-21 23:55 ` Nicholas Piggin
2019-06-21 8:29 ` Nicholas Piggin
2019-06-21 8:29 ` Nicholas Piggin
2019-06-21 8:29 ` Nicholas Piggin
2019-06-12 1:27 ` Nadav Amit
2019-06-12 1:27 ` Nadav Amit
2019-06-12 1:27 ` Nadav Amit
2019-06-20 11:45 ` switch the remaining architectures to use generic GUP v3 Christoph Hellwig
2019-06-20 11:45 ` Christoph Hellwig
2019-06-20 11:45 ` Christoph Hellwig
2019-06-21 14:43 ` Jason Gunthorpe
2019-06-21 14:43 ` Jason Gunthorpe
2019-06-21 14:43 ` Jason Gunthorpe
2019-06-25 14:36 ` switch the remaining architectures to use generic GUP v4 Christoph Hellwig
2019-06-25 14:36 ` Christoph Hellwig
2019-06-25 14:36 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 01/16] mm: use untagged_addr() for get_user_pages_fast addresses Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 02/16] mm: simplify gup_fast_permitted Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 03/16] mm: lift the x86_32 PAE version of gup_get_pte to common code Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 04/16] MIPS: use the generic get_user_pages_fast code Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-29 14:37 ` Guenter Roeck
2019-06-29 14:37 ` Guenter Roeck
2019-06-29 14:37 ` Guenter Roeck
2019-06-25 14:37 ` [PATCH 05/16] sh: add the missing pud_page definition Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 06/16] sh: use the generic get_user_pages_fast code Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-29 15:15 ` Guenter Roeck
2019-06-29 15:15 ` Guenter Roeck
2019-06-29 15:15 ` Guenter Roeck
2019-06-25 14:37 ` [PATCH 07/16] sparc64: add the missing pgd_page definition Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 08/16] sparc64: define untagged_addr() Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 09/16] sparc64: use the generic get_user_pages_fast code Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-07-17 21:59 ` Dmitry V. Levin
2019-07-17 21:59 ` Dmitry V. Levin
2019-07-17 22:04 ` Linus Torvalds
2019-07-17 22:04 ` Linus Torvalds
2019-07-17 22:04 ` Linus Torvalds
2019-07-17 23:30 ` Dmitry V. Levin
2019-07-17 23:30 ` Dmitry V. Levin
2019-07-18 0:17 ` Linus Torvalds
2019-07-18 0:17 ` Linus Torvalds
2019-07-18 0:17 ` Linus Torvalds
2019-07-18 1:21 ` David Miller
2019-07-18 1:21 ` David Miller
2019-07-18 21:43 ` David Miller
2019-07-18 21:43 ` David Miller
2019-07-18 21:14 ` David Miller
2019-07-18 21:14 ` David Miller
2019-07-19 6:00 ` Christoph Hellwig
2019-07-19 6:00 ` Christoph Hellwig
2019-07-24 19:32 ` Anatoly Pugachev
2019-07-24 19:32 ` Anatoly Pugachev
2019-07-24 19:32 ` Anatoly Pugachev
2019-07-24 20:13 ` David Miller
2019-07-24 20:13 ` David Miller
2019-07-25 18:33 ` Anatoly Pugachev
2019-07-25 18:33 ` Anatoly Pugachev
2019-07-25 18:33 ` Anatoly Pugachev
2019-07-25 22:52 ` David Miller
2019-07-25 22:52 ` David Miller
2019-07-28 2:09 ` David Miller
2019-07-28 2:09 ` David Miller
2019-07-28 20:00 ` Anatoly Pugachev
2019-07-28 20:00 ` Anatoly Pugachev
2019-07-28 20:00 ` Anatoly Pugachev
2019-07-26 17:58 ` Khalid Aziz
2019-07-26 17:58 ` Khalid Aziz
2019-08-09 19:59 ` Anatoly Pugachev
2019-08-09 19:59 ` Anatoly Pugachev
2019-08-09 19:59 ` Anatoly Pugachev
2019-08-10 7:17 ` Christoph Hellwig
2019-08-10 7:17 ` Christoph Hellwig
2019-08-10 19:36 ` Mikael Pettersson
2019-08-10 19:36 ` Mikael Pettersson
2019-08-10 19:36 ` Mikael Pettersson
2019-08-11 20:30 ` Anatoly Pugachev
2019-08-11 20:30 ` Anatoly Pugachev
2019-08-11 20:30 ` Anatoly Pugachev
2019-06-25 14:37 ` [PATCH 10/16] mm: rename CONFIG_HAVE_GENERIC_GUP to CONFIG_HAVE_FAST_GUP Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 11/16] mm: reorder code blocks in gup.c Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 12/16] mm: consolidate the get_user_pages* implementations Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 13/16] mm: validate get_user_pages_fast flags Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 14/16] mm: move the powerpc hugepd code to mm/gup.c Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 19:37 ` Andrew Morton
2019-06-25 19:37 ` Andrew Morton
2019-06-25 19:37 ` Andrew Morton
2019-06-26 5:49 ` Christoph Hellwig [this message]
2019-06-26 5:49 ` Christoph Hellwig
2019-06-26 5:49 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 15/16] mm: switch gup_hugepte to use try_get_compound_head Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` [PATCH 16/16] mm: mark the page referenced in gup_hugepte Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
2019-06-25 14:37 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2019-06-01 7:49 RFC: switch the remaining architectures to use generic GUP v2 Christoph Hellwig
2019-06-01 7:49 ` [PATCH 14/16] mm: move the powerpc hugepd code to mm/gup.c Christoph Hellwig
2019-06-01 7:49 ` Christoph Hellwig
2019-06-01 7:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626054934.GA23547@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=benh@kernel.crashing.org \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=jhogan@kernel.org \
--cc=khalid.aziz@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.